ZDoom

Posted: **Sun Nov 24, 2024 10:16 am**

Hello all, I am trying to cut/copy/paste the crt-shader code from Torrid Gristle's Retro Shader mod, as the retro shader class clashes with another retro shader I use; I thought I could just lift everything in the code related to this particular crt-curve.fp, or really, remove everything that was NOT for the crt-shader. I've done this successfully with some other mods, but for some reason this one is crashing Zdoom when I try to start a level. It says:

Code: Select all

E1M1 - Hangar
FREEN
UM execution aborted: tried to read from address zero. In function parameter
"self"
Called from CVar.GetInt [Nativel Called from CrtHandler.UiTick at
CRT Shader wad :zscript.zc, line 8

Here is what's in the mod:

Spoiler:

CVARinfo

Code: Select all

user bool gl_retro_crt_enablescanlines = true;
user float gl_retro_crt_scanlinemult = 1250.0;
user float gl_retro_crt_curveamntx = 0.25;
user float gl_retro_crt_curveamnty = 0.25;
user int gl_retro_crt_enablecurve = 1;
user bool gl_retro_crt_cubed = false;

GLdefs

Code: Select all

HardwareShader PostProcess screen
{
	Name "CrtShader"
	Shader "shaders/crt-curve.fp" 330
	Uniform int EnableScanLines
	Uniform float ScanLineMult
	Uniform int EnableCurve
	Uniform int Cubed
	Uniform float CrtCurveAmntX
	Uniform float CrtCurveAmntY
}

HardwareShader PostProcess scene
{
	Name "CrtShaderVisor"
	Shader "shaders/crt-curve.fp" 330
	Uniform int EnableScanLines
	Uniform float ScanLineMult
	Uniform int EnableCurve
	Uniform int Cubed
	Uniform float CrtCurveAmntX
	Uniform float CrtCurveAmntY
}

MAPinfo

Code: Select all

GameInfo
{
	AddEventHandlers = "CrtHandler"
}

MENUdefs

Code: Select all

AddOptionMenu "OptionsMenu"
{
	Submenu "CRT Shader", "CRT Options"
}

OptionValue "Smoothing"
{
	0, "Squared"
	1, "Cubed"
}

OptionValue "CurveOptions"
{
	0, "Off"
	1, "On"
	2, "Visor"
}

OptionMenu "CRT Options"
{

	StaticText "CRT Stuff"
	Option "Screen Curve", "gl_retro_crt_enablecurve", "CurveOPtions"
	Slider "Curve Amount X", "gl_retro_crt_curveamntx", 0, 6, 0.01, 2
	Slider "Curve Amount Y", "gl_retro_crt_curveamnty", 0, 6, 0.01, 2
	Option "Smoothing", "gl_retro_crt_cubed", "Smoothing"
	Option "Scan Lines", "gl_retro_crt_enablescanlines", YesNo
	Slider "Scan Line Multiplier", "gl_retro_crt_scanlinemult", 100, 10000, 0.1, 1
}

Zscript

Code: Select all

version "2.5"

class CrtHandler : EventHandler
{
	override void UiTick()
	{
		PlayerInfo p = players[consoleplayer];
		if (Cvar.GetCVar("gl_retro", p).GetInt() > 0 && Cvar.GetCVar("gl_retro_crt_enablescanlines", p).GetInt() + Cvar.GetCVar("gl_retro_crt_enablecurve", p).GetInt() > 0)
		{
			if (Cvar.GetCVar("gl_retro_crt_enablecurve", p).GetInt() == 2)
			{
				Shader.SetEnabled(p, "CrtShader", false);
				Shader.SetUniform1f(p, "CrtShaderVisor", "EnableScanLines", Cvar.GetCVar("gl_retro_crt_enablescanlines", p).GetInt());
				Shader.SetUniform1f(p, "CrtShaderVisor", "ScanLineMult", Cvar.GetCVar("gl_retro_crt_scanlinemult", p).GetFloat());
				Shader.SetUniform1f(p, "CrtShaderVisor", "EnableCurve", Cvar.GetCVar("gl_retro_crt_enablecurve", p).GetInt());
				Shader.SetUniform1f(p, "CrtShaderVisor", "CrtCurveAmntX", 0.0 - Cvar.GetCVar("gl_retro_crt_curveamntx", p).GetFloat());
				Shader.SetUniform1f(p, "CrtShaderVisor", "CrtCurveAmntY", 0.0 - Cvar.GetCVar("gl_retro_crt_curveamnty", p).GetFloat());
				Shader.SetUniform1f(p, "CrtShaderVisor", "Cubed", Cvar.GetCVar("gl_retro_crt_cubed", p).GetInt());
				Shader.SetEnabled(p, "CrtShaderVisor", true);
			}
			else
			{
				Shader.SetEnabled(p, "CrtShaderVisor", false);
				Shader.SetUniform1f(p, "CrtShader", "EnableScanLines", Cvar.GetCVar("gl_retro_crt_enablescanlines", p).GetInt());
				Shader.SetUniform1f(p, "CrtShader", "ScanLineMult", Cvar.GetCVar("gl_retro_crt_scanlinemult", p).GetFloat());
				Shader.SetUniform1f(p, "CrtShader", "EnableCurve", Cvar.GetCVar("gl_retro_crt_enablecurve", p).GetInt());
				Shader.SetUniform1f(p, "CrtShader", "CrtCurveAmntX", Cvar.GetCVar("gl_retro_crt_curveamntx", p).GetFloat());
				Shader.SetUniform1f(p, "CrtShader", "CrtCurveAmntY", Cvar.GetCVar("gl_retro_crt_curveamnty", p).GetFloat());
				Shader.SetUniform1f(p, "CrtShader", "Cubed", Cvar.GetCVar("gl_retro_crt_cubed", p).GetInt());
				Shader.SetEnabled(p, "CrtShader", true);
			}
		}
		else
		{
			Shader.SetEnabled(p, "CrtShader", false);
			Shader.SetEnabled(p, "CrtShaderVisor", false);
		}
	}
}

That is everything left in the mod, except for the shader itself.
I know this might not be possible, but does anything look off to anyone else? Something basic every mod needs or something else I overlooked or don't know? I'd really like to add this shader to my "stack" and I do not think it should be too hard.

ZDoom

Tried to read from address zero - CRT curve shader

Tried to read from address zero - CRT curve shader