[0.6.0-452-gfc466849ce] Lighting isn't diminishing properly

Moderator: Raze Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
User avatar
mjr4077au
Posts: 830
Joined: Sun Jun 16, 2019 9:17 pm
Graphics Processor: nVidia with Vulkan support
Location: Gosford NSW, Australia

[0.6.0-452-gfc466849ce] Lighting isn't diminishing properly

Post by mjr4077au »

Might be known and might be a WIP, thought I'd call it out just in case :). Happens cross-platform and with fresh configs.

Current master:



Older builds:

User avatar
sinisterseed
Posts: 1349
Joined: Tue Nov 05, 2019 6:48 am
Preferred Pronouns: He/Him
Graphics Processor: nVidia with Vulkan support

Re: [0.6.0-452-gfc466849ce] Lighting isn't diminishing prope

Post by sinisterseed »

It still darkens I see, so things didn't turn completely flat.

Honestly I'm better off having it this way than the traditional Build style. The stock Build engine light fading is abysmal.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49183
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [0.6.0-452-gfc466849ce] Lighting isn't diminishing prope

Post by Graf Zahl »

The code is in transition right now, I only pushed this WIP state because of the shader compile errors.
Obviously my goal here is to have something like GZDoom - one light mode that tries to get as close to the original as possible and a few options implementing something nicer to look at.
TBH, this shitty fade algorithm in Build is really taking away from the games, the lighting just looks atrocious. I think it is worst in Exhumed of the supported games.
User avatar
sinisterseed
Posts: 1349
Joined: Tue Nov 05, 2019 6:48 am
Preferred Pronouns: He/Him
Graphics Processor: nVidia with Vulkan support

Re: [0.6.0-452-gfc466849ce] Lighting isn't diminishing prope

Post by sinisterseed »

With palette emulation is looks a bit better, but without it ON, it reveals how subpar the lighting actually is since it darkens so quickly and close to the player.

Can't wait for the sector light modes, I find the vanilla style worst in SW, made all the more aggravating due to the ninjas... But the original will still be offered as an option even then.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49183
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [0.6.0-452-gfc466849ce] Lighting isn't diminishing prope

Post by Graf Zahl »

lowskill. wrote: But the original will still be offered as an option even then.

Sure, that's absolutely necessary - but I feel the poor lighting often draws unwanted attention. But in order to do something here I first need to be able to run the scene through GZDoom's render interface. Until then a few more things may temporarily break.
User avatar
mjr4077au
Posts: 830
Joined: Sun Jun 16, 2019 9:17 pm
Graphics Processor: nVidia with Vulkan support
Location: Gosford NSW, Australia

Re: [0.6.0-452-gfc466849ce] Lighting isn't diminishing prope

Post by mjr4077au »

Graf Zahl wrote:The code is in transition right now, I only pushed this WIP state because of the shader compile errors.
I thought as much but posted just in case and appreciate the push to get things working on Linux. Interesting that there were shader errors on Linux but not when I was testing on Windows, but oh well.

I also posted because it's far easier to crack onto potential issues instead of backtracing through potentially hundreds of commits down the track. Isolating those demo issues with Blood cost 1.5 hours worth of time for example and ain't nobody got time for that!

Graf Zahl wrote:Obviously my goal here is to have something like GZDoom - one light mode that tries to get as close to the original as possible and a few options implementing something nicer to look at.
TBH, this shitty fade algorithm in Build is really taking away from the games, the lighting just looks atrocious. I think it is worst in Exhumed of the supported games.
Will definitely appreciate a few options to keep things fresh :). I'll probably play it as close to vanilla as possible but appreciate the easy ability to turn off palette emulation as I prefer to have anisotrophic filtering etc. If only I could have my cake and eat it too :wink:
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49183
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [0.6.0-452-gfc466849ce] Lighting isn't diminishing prope

Post by Graf Zahl »

Can you please re-verify? For me it looks correct, I wasn't able to reproduce this issue.
User avatar
mjr4077au
Posts: 830
Joined: Sun Jun 16, 2019 9:17 pm
Graphics Processor: nVidia with Vulkan support
Location: Gosford NSW, Australia

Re: [0.6.0-452-gfc466849ce] Lighting isn't diminishing prope

Post by mjr4077au »

It looks the same for me, both cleanly built on Windows and Linux. Could my 9-series video card be doing something different from your 10-series?
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49183
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [0.6.0-452-gfc466849ce] Lighting isn't diminishing prope

Post by Graf Zahl »

No idea. But light looks correct for me (well, as correct as it can with this code... :twisted:)
User avatar
mjr4077au
Posts: 830
Joined: Sun Jun 16, 2019 9:17 pm
Graphics Processor: nVidia with Vulkan support
Location: Gosford NSW, Australia

Re: [0.6.0-452-gfc466849ce] Lighting isn't diminishing prope

Post by mjr4077au »

Let's see what lowskill gets when he comes online and has a chance to test. Happy for it to be closed off if it's just isolated to me for some stupid reason :)
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49183
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [0.6.0-452-gfc466849ce] Lighting isn't diminishing prope

Post by Graf Zahl »

Have you tried deleting your config?
User avatar
mjr4077au
Posts: 830
Joined: Sun Jun 16, 2019 9:17 pm
Graphics Processor: nVidia with Vulkan support
Location: Gosford NSW, Australia

Re: [0.6.0-452-gfc466849ce] Lighting isn't diminishing prope

Post by mjr4077au »

Sure have, here it is at 0.6.0-477 and all its trilinear glory ;)

User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49183
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [0.6.0-452-gfc466849ce] Lighting isn't diminishing prope

Post by Graf Zahl »

Just to rule out some strange things, can you zip up your EXE, DLLs and PK3? I'd like to check your files on my system.
User avatar
mjr4077au
Posts: 830
Joined: Sun Jun 16, 2019 9:17 pm
Graphics Processor: nVidia with Vulkan support
Location: Gosford NSW, Australia

Re: [0.6.0-452-gfc466849ce] Lighting isn't diminishing prope

Post by mjr4077au »

Right here: https://drive.google.com/file/d/1MncC09 ... sp=sharing

Release x64 build with MSVC 16.6.1 Community Edition.
User avatar
sinisterseed
Posts: 1349
Joined: Tue Nov 05, 2019 6:48 am
Preferred Pronouns: He/Him
Graphics Processor: nVidia with Vulkan support

Re: [0.6.0-452-gfc466849ce] Lighting isn't diminishing prope

Post by sinisterseed »

For me it shows correctly too, I'm not getting the flat lighting either - https://i.imgur.com/Mgccavd.png .

VS2019 Community 16.6.1, CMake 3.17.3, Release x64, build off of 5330964a7a622fe6d8b54a0982c336dd2456d9f4, W10 version 1909, GTX 950, driver version 446.14. I can upload my build too, if wanted.

Return to “Closed Bugs [Raze]”