[0.5.0] [SW] Missing voice line after exiting previous level

[markanini]

Lo Wang's line "I must seek out master Leep's advice" can be heard when doing "levelwarp 3" but not when exiting the previous level normally. Save file: https://www.dropbox.com/transfer/AAAAAO ... j5DMvosPzA

[sinisterseed]

Confirmed.

This is also the same behavior as in VoidSW, but different from everything else - SWP, DOS, and Redux. I think this happens because after you proceed through the portal Lo Wang still breathes at the beginning of the next map as if he just emerged from the water he jumped into - which he technically did I guess :v , and that breath probably replaces Wang's line.

[Graf Zahl]

Can you try to find out which sound this is? Then I could search for the code playing it. Otherwise I'd have to look this up myself which would keep me from fixing bugs in that time...

[sinisterseed]

I think I found it.

The name of the exhale sound might be "JG7009".

[Graf Zahl]

I meant the voice sound, actually, because I need to check what it does.

[sinisterseed]

I meant the voice sound, actually, because I need to check what it does.

JG4024 me thinks.

[Graf Zahl]

Fixed - but I'm not sure if this was ever meant to be this way, the way the code was written that speech would always have been blocked.
I changed it so that the surfacing sound (and only that one!) is being stopped when Lo Wang wants to talk.

[sinisterseed]

Fixed - but I'm not sure if this was ever meant to be this way, the way the code was written that speech would always have been blocked.
I changed it so that the surfacing sound (and only that one!) is being stopped when Lo Wang wants to talk.

How do SWP and Redux handle this, since the speech line doesn't get blocked in them (or DOS, for that matter)?

[Graf Zahl]

No idea, maybe a timing issue? Even now, the surfacing sound nearly plays out, but not fully, before the line starts.
The main problem with the timing is that whatever SW did there was pretty much broken by design, storing sound channels in unmaintained static variables so it had to be changed. It may well be that the code did not work right due to that.

[sinisterseed]

No idea, maybe a timing issue? Even now, the surfacing sound nearly plays out, but not fully, before the line starts.
The main problem with the timing is that whatever SW did there was pretty much broken by design, storing sound channels in unmaintained static variables so it had to be changed. It may well be that the code did not work right due to that.

Maybe not just that, could it also be related to level transitions? Just a guess that maybe it's not related to the sound engine, at least not directly.

Compiled a new build today and this isn't solved for sure. The line now plays, but it overlaps with the exhale sound near the end. Doesn't sound too good.

[Graf Zahl]

What should happen? The way the code is written, both will play - with a delay in-between.

[sinisterseed]

What should happen? The way the code is written, both will play - with a delay in-between.

The exhale sound should not be heard after transitioning to the level, according to 3 different versions (SWP, DOS, and Redux). Only the one-liner plays at the beginning.