Page 1 of 1

grpinfo crash at menu [split from MODINFO thread]

Posted: Sun Feb 09, 2020 3:05 pm
by Photonic
Ok so I've tested this with a couple TCs. (WGR2 and Borg Nukem) Both crash at the menu, no menu displayed.
WGR2 comes with a more than just a GRP file, it loaded well when in the game directory.
Borg Nukem is just a .grp file and probably the easiest test case. I used the grp file in the rather large Duke Nukem Add Ons pack.
Here it is as a zip. 18 MB
https://drive.google.com/file/d/1kKrTEn ... sp=sharing

Code: Select all

grpinfo
{
    name "Borg Nukem"
    scriptname "borg3d.con"
    defname "loadhud.def"
    size 51563845
    dependency 0
    crc 1859103666
}
I have some crash report files it generated. I'm new... not too sure if just posting this here is fine or if it requires a proper bug report yet.

Re: grpinfo crash at menu [split from MODINFO thread]

Posted: Sun Feb 09, 2020 3:29 pm
by wildweasel
I've opted to split this into a Bugs thread where it can be more easily tracked.

Re: grpinfo crash at menu [split from MODINFO thread]

Posted: Sun Feb 09, 2020 3:37 pm
by Graf Zahl
I cannot reproduce these crashes. There was one with WGR2 after starting the game and another one when dying, but the menu works fine for both.
But without a crash log I cannot tell what's up.

Re: grpinfo crash at menu [split from MODINFO thread]

Posted: Sun Feb 09, 2020 4:07 pm
by Photonic
I've attached the 2 crash reports, one from each game.

Re: grpinfo crash at menu [split from MODINFO thread]

Posted: Fri Feb 14, 2020 2:22 am
by Graf Zahl
What precise version were these reports generated with? And does it still happen with 0.4.4?

Re: grpinfo crash at menu [split from MODINFO thread]

Posted: Fri Feb 14, 2020 2:01 pm
by Photonic
Raze version 0.4.1 (fa057282dfc5d275a2b5e35209ca28a11acbc594)
And yes it is still happening as described above in 0.4.4

Re: grpinfo crash at menu [split from MODINFO thread]

Posted: Sun Feb 16, 2020 10:08 am
by Graf Zahl
I still haven't found a way to reproduce this. I can start these mods without problems.
How, precisely, are you starting it?

Re: grpinfo crash at menu [split from MODINFO thread]

Posted: Sun Feb 16, 2020 10:57 am
by Photonic
I have the GRPs in a folder in the raze directory. I start by executing "raze.exe" with no arguments. If it's more than one game in raze's subfolders then I need to select which game to play (I hid my detecable steam/gog installs.) The .grpinfo file is in the folder next to the game .grp.

So far everything works as expected. All comercial games play normally. Only these "standalone" total conversions crash at the menu. It feels as if raze doesn't know that it's based on Duke3d and should run that frontend, the .grpinfo assumes Duke3D frontend for eduke32, but with raze it feels as if it doesn't know what game it's running, so it just never draws a menu then crashes.

I've tested with multiple games since, all react the same. I went so far as to extract all of the contents from duke3d.grp into a subfolder, created a .grpinfo workaround to load the game without the .grp present, same issue it gets to the menu screen, draws no menu, crash.

Re: grpinfo crash at menu [split from MODINFO thread]

Posted: Sun Feb 16, 2020 11:20 am
by Graf Zahl
Can you post the GRPINFO entry for these mods?

Re: grpinfo crash at menu [split from MODINFO thread]

Posted: Sun Feb 16, 2020 11:53 am
by Photonic

Code: Select all

grpinfo
{
    name "Borg Nukem"
    scriptname "borg3d.con"
    defname "loadhud.def"
    size 51563845
    dependency 0
    crc 1859103666
}
Here is the entire folder. In a zip 18MB
https://drive.google.com/file/d/1lJPK1c ... sp=sharing

Here is the workaround .grpinfo I've made for loading contents straight out of subfolders to match my eduke32 style of development. 1KB
https://drive.google.com/file/d/15Q2vqv ... sp=sharing

Re: grpinfo crash at menu [split from MODINFO thread]

Posted: Sun Feb 16, 2020 12:31 pm
by Graf Zahl
What happens if you add a line

flags GAMEFLAG_DUKE

to it? I am using the version from Nightfright's addon pack and cannot make it crash.

Re: grpinfo crash at menu [split from MODINFO thread]

Posted: Sun Feb 16, 2020 1:03 pm
by Photonic
That did it! Thank you.
I had to remove the line "dependency 0" also.
Works as far back as 0.4.1(my oldest revision) to 0.4.4

Re: grpinfo crash at menu [split from MODINFO thread]

Posted: Sun Feb 16, 2020 1:06 pm
by Graf Zahl
Ok, good to know. Seems there are some cases in the GRPINFO handler that don't work right.
I'll have to see if I can add something that lets this pass without problems.

Re: grpinfo crash at menu [split from MODINFO thread]

Posted: Sun Feb 16, 2020 1:18 pm
by Graf Zahl
This case now gets validated.