Page 45 of 58
Re: WadSmoosh - merge all official id releases into one PK3
Posted: Thu Aug 06, 2020 9:22 pm
by TheArchvile
JPL, this is not really a bug per se, but more of an oversight that you probably didn't bother adding because it is very minimal and almost silly. For E1M10 (the infamous secret map Sewers for UD), it has been written on both Doom wiki and Doom fandom that the blood splat actually appears outside of the boundaries of the map. If you were to add it on a future update, where would you place it?
Also, the update works wonders, excellent work!
Re: WadSmoosh - merge all official id releases into one PK3
Posted: Sat Aug 22, 2020 12:17 am
by Xerenogan
Thank you so much for this. I, at first heard of it in my periphery but discounted it for too long. This has just replaced doom2 as my default wad.
I know the stance on unofficial wads (which I agree with), but to those who are interested, I was able to get the "lost episodes" working after a fashion. The script update back there has some problems with my setup. That's fine. For those using the old scrips for incorporating "the lost episodes" , in the "wadsmoosh_data.py" that you included, you are missing a comma at the end of line 48.
The rest of it though, is outstanding. The script is easy to change. I really like the constant support over the years, though I just found out about it today. I was missing out.
No problems yet. Will let you know.
Thank you so much for this JP. Good job!
Re: WadSmoosh - merge all official id releases into one PK3
Posted: Sun Aug 23, 2020 7:26 pm
by strangebit
I was just looking at the zscript code and I noticed that DoDoom1PoisonTextureReplacements() will never be called if there's a custom sky (if CheckSkyOverriden() returns true), because of the early return statements in the WorldLoaded event handler. I don't understand the custom sky stuff so maybe I'm wrong, but on the surface it doesn't look intentional to me, so just letting you know.
Code: Select all
override void WorldLoaded(WorldEvent e)
{
if ( CVar.FindCVar("ws_finaldoom_texswap").GetBool() )
DoFinalDoomTextureReplacements();
if ( CVar.FindCVar("ws_d2sky_compat").GetBool() )
{
if ( CheckSkyOverriden("RSKY1", "SKY1") )
return;
else if ( CheckSkyOverriden("RSKY2", "SKY2") )
return;
CheckSkyOverriden("RSKY3", "SKY3");
}
if ( CVar.FindCVar("ws_d1pois_texswap").GetBool() )
DoDoom1PoisonTextureReplacements();
}
Re: WadSmoosh - merge all official id releases into one PK3
Posted: Mon Aug 24, 2020 3:18 am
by Gez
strangebit wrote:I was just looking at the zscript code and I noticed that DoDoom1PoisonTextureReplacements() will never be called if there's a custom sky (if CheckSkyOverriden() returns true), because of the early return statements in the WorldLoaded event handler. I don't understand the custom sky stuff so maybe I'm wrong, but on the surface it doesn't look intentional to me, so just letting you know.
The sky checks are for whether the level's regular sky is RSKY1/2/3 and a custom SKY1/2/3 is provided. In other words, they'll only return true when in a Doom II level. When in a Ultimate Doom level, they will return false and therefore won't trigger the early returns, and the Doom1Poison function only works in Ult. Doom levels.
So it should work fine.
Re: WadSmoosh - merge all official id releases into one PK3
Posted: Mon Aug 24, 2020 11:34 am
by strangebit
Gez wrote:strangebit wrote:I was just looking at the zscript code and I noticed that DoDoom1PoisonTextureReplacements() will never be called if there's a custom sky (if CheckSkyOverriden() returns true), because of the early return statements in the WorldLoaded event handler. I don't understand the custom sky stuff so maybe I'm wrong, but on the surface it doesn't look intentional to me, so just letting you know.
The sky checks are for whether the level's regular sky is RSKY1/2/3 and a custom SKY1/2/3 is provided. In other words, they'll only return true when in a Doom II level. When in a Ultimate Doom level, they will return false and therefore won't trigger the early returns, and the Doom1Poison function only works in Ult. Doom levels.
So it should work fine.
Ah, I didn't realize.
Re: WadSmoosh - merge all official id releases into one PK3
Posted: Sun Aug 30, 2020 6:07 pm
by Yarn366
I noticed that, for Master Levels and Final Doom, WadSmoosh uses FLOOR7_2 for the border graphic; they should use GRNROCK instead. (Doom 1, Doom 2, Sigil, and No Rest for the Living all use the correct border graphic.)
Re: WadSmoosh - merge all official id releases into one PK3
Posted: Mon Aug 31, 2020 12:26 am
by JPL
Yarn366 wrote:I noticed that, for Master Levels and Final Doom, WadSmoosh uses FLOOR7_2 for the border graphic; they should use GRNROCK instead. (Doom 1, Doom 2, Sigil, and No Rest for the Living all use the correct border graphic.)
Good catch, I didn't know about the "BorderTexture" MAPINFO property. Final Doom is an easy obvious fix. Is the use of GRNROCK for the Master Levels border based on the Playstation version?
Re: WadSmoosh - merge all official id releases into one PK3
Posted: Mon Aug 31, 2020 12:40 am
by Yarn366
JPL wrote:Is the use of GRNROCK for the Master Levels border based on the Playstation version?
No, it's based on the PC version.
Re: WadSmoosh - merge all official id releases into one PK3
Posted: Mon Aug 31, 2020 9:58 am
by JPL
Yarn366 wrote:JPL wrote:Is the use of GRNROCK for the Master Levels border based on the Playstation version?
No, it's based on the PC version.
Since the Master Levels run off Doom 2 wouldn't they use the same border graphic as Doom 2?
Re: WadSmoosh - merge all official id releases into one PK3
Posted: Mon Aug 31, 2020 8:56 pm
by Yarn366
JPL wrote:Yarn366 wrote:JPL wrote:Is the use of GRNROCK for the Master Levels border based on the Playstation version?
No, it's based on the PC version.
Since the Master Levels run off Doom 2 wouldn't they use the same border graphic as Doom 2?
Yes, they do. In vanilla, Doom 2 and Final Doom use GRNROCK, while Doom 1 uses FLOOR7_2. Mods use the same border graphics as their base games unless they replace the texture.
Re: WadSmoosh - merge all official id releases into one PK3
Posted: Mon Aug 31, 2020 11:33 pm
by JPL
Yarn366 wrote:
Yes, they do. In vanilla, Doom 2 and Final Doom use GRNROCK, while Doom 1 uses FLOOR7_2. Mods use the same border graphics as their base games unless they replace the texture.
Okay, so everything except Ultimate Doom and Sigil should use GRNROCK, and those two (5 episodes) should use FLOOR7_2. It looks like Doom 2 was not in fact showing up correctly, then. I just confirmed it now works as it does with the vanilla IWADs.
Re: WadSmoosh - merge all official id releases into one PK3
Posted: Tue Sep 01, 2020 12:44 am
by Yarn366
JPL wrote:Yarn366 wrote:
Okay, so everything except Ultimate Doom and Sigil should use GRNROCK, and those two (5 episodes) should use FLOOR7_2. It looks like Doom 2 was not in fact showing up correctly, then. I just confirmed it now works as it does with the vanilla IWADs.
Doom 2 (minus the secret levels, which are defined in a different file) and No Rest for the Living actually were using the correct border because block was at the top of doom2_levels.txt:
Code: Select all
adddefaultmap
{
BorderTexture = "GRNROCK"
}
The "adddefaultmap" block sets properties for all maps in the file that come after the block. So, for instance, if
every map in a file should have a certain properties, you can place those properties in a single "adddefaultmap" block at the beginning of the file rather than in every map definition.
Re: WadSmoosh - merge all official id releases into one PK3
Posted: Tue Sep 01, 2020 6:51 pm
by JPL
Yarn366 wrote:
The "adddefaultmap" block sets properties for all maps in the file that come after the block. So, for instance, if every map in a file should have a certain properties, you can place those properties in a single "adddefaultmap" block at the beginning of the file rather than in every map definition.
Good to know, thanks!
Re: WadSmoosh - merge all official id releases into one PK3
Posted: Thu Sep 03, 2020 3:34 pm
by ShockwaveS08
Will there be support for the "Ultra-Violence+" difficulty that was just introduced in the Unity versions of Doom and Doom II?
Basically, weapon and monster spawns match those present only in co-op and deathmatch, and enemies are just as fast as they are on Nightmare.
Par times were also added for E1M8, E2M8, and E3M8.
Re: WadSmoosh - merge all official id releases into one PK3
Posted: Thu Sep 03, 2020 4:43 pm
by Gez
Creating a skill that's basically UV fast is possible, creating a skill that causes the engine to ignore the multiplayer-only flag would require a new engine feature I guess. But it would be an okay feature suggestion.
May I suggest taking the DSSECRET lump from extras.wad, if found? It's the official secret sound now.