GZDoomBuilder-Bugfix, a maintenance fork of GZDB

[ZZYZX]

Ok, I'm going to generate a 100mb random lump wad and try to fix saving properly. Not right now, but today
I'm also going to fix saving with different format (because currently it wouldn't delete all lumps of a Hexen map if you save UDMF map over Hexen map, and the other way around as well...)
There's also this suspicious comment:

Code: Select all

//TODO: I see a big, but kinda esoteric problem here if the source has several maps with the same name (mxd)

Anyway, as for sector drawing, you should understand that for old changes the only person that knows how or why it was changed is MaxED.
That particular change is probably in SVN, and there is no SVN link anywhere (anyone has that?), and it'd be quite hard to find the exact revision where he changed this.
(which means it's also hard to find the old version of the code at all, unless the DB2 one is compatible)

[ZZYZX]

I deleted CopyAllLumpsExceptMap completely and it doesn't seem to break anything.
I think that function was a result of continuous algorithm stacking and what it was doing is already done elsewhere, because essentially, SaveMap would first copy the file on disk using system WinAPI function, then open it with WAD class and perform the same copying lump-wise. Honestly was afraid of touching that code, because I have absolutely NO idea why MaxED wrote that, so please double alertness and report any problems with the map saving, if any appear.
(I desperately need Kappes Buur as GZDB's keeper of knowledge...)

I'm going to make a build, please test if it's any faster for you now (because I also added a Compress() after the save).

[ZZYZX]

Fixed/broke map loading/saving.
Changes:

• On saving the map, all maps with the same name as the saved one will be deleted. It's a bad idea to have two maps with the same name in an archive.
• The map format for deleting a map is autodetected from the longest matching lump sequence for UDMF, Doom, Hexen or Strife formats. This means that now, if you save a UDMF map in place of a Hexen map (either with "Save into" or with regular save), it should no more leave junk lumps from the old format (e.g. regular Hexen lumps + leftover TEXTMAP+ZNODES+ENDMAP).
• When there are multiple lumps with the same name and that name happens to be your map it won't try to load/save over the non-map lumps.
• When there are multiple maps with the same name, only the LAST one will be loaded (that's how GZDoom does it as well).
  The old behavior was to try to load the first %anything% that goes after the first lump with the matching name, and if it wasn't a map, it'd error out about missing required lumps.

[Sarah]

Fixed/broke map loading/saving.
Changes:

• On saving the map, all maps with the same name as the saved one will be deleted. It's a bad idea to have two maps with the same name in an archive.

Please do not take the liberty of deleting any files but those that GZDB temporarily produces. Or please include a setting to disable this, or even better a dialogue to pick and choose what GZDB may delete. Some of us work outside of the standard formats and need GZDB to not muck about in our archives.

My primary concern is backups, not just those that GZDB makes.

[ZZYZX]

It doesn't delete files, it removes the old map lumps under MAP## marker in the target WAD.

The algorithm used is as follows:
1. Given we are saving map MAP01:
2. Find next lump called MAP01. If not found, stop searching.
3. Check all game configurations in Configurations directory.
4. For each game configuration, check what map lumps are supported and store the most matching lump set as "trylist".
5. Delete all lumps after MAP01 that are also in "trylist"; stop deleting once the first non-matching lump is found (this is generally either MAP02, ... or non-map lumps).
6. Goto 2.

Before my modification, GZDB would do the same, except it'd assume that there is only one map with the given name in the WAD (which is not always true and would produce esoteric bugs), and it would only delete lumps from the current game configuration (which would result in broken half-saved maps in the archive when you upgrade Hexen maps to UDMF, like this).

[Xabis]

Added pull request #42, which is my attempt to fix patrol/interpolation special event lines.

Test wad is attached to PR on comment 1.

Screenshot:

[Sarah]

@ZZYZX

Ah, my misunderstanding, I somehow read that as extending beyond the wad, possibly to the pk3 it's a part of, which left me thinking if I did something like "MAP01.wad.old" and left it next to the current version of the wad then GZDB would delete it on save, for (...reasons). So nevermind, carry on, sounds like you're fixing an oversight; I've honestly never considered having multiple map lumps named the same thing in a wad, but that doesn't mean others won't.

You still might produce some sort of alert and options, just in case there is some legitimate reason a user doesn't want the extra lumps deleted.

[camaxide]

Just want to report back that the freezing I used to have with every single previous build of GzDoomBuilder (happened some times when entering 3D-mode) seem to be gone.. it has never happened since I swapped to this new fork.. No idea what has been changed on that end, but very happy to not have those freezes any more

[blood]

Hum guys? Since a certain update I'm no longer able to test my maps with Zandronum 2.1.2 when I use a directory as a ressource.
It's working fine with Zandronum 3.0 but it's still a beta so I need to test my maps on 2.1.2.

Each time I start testing the it crashes with the following report.

Code: Select all

Code: C0000005 (Access Violation - tried to write address 00000004)
Address: 00563CA2
Flags: 00000000

Windows NT 6.2 Build 9200 

GS=002b  FS=0053  ES=002b  DS=002b
EAX=00000001  EBX=03800fec  ECX=a021eb50  EDX=008b8500
ESI=013bdce0  EDI=00000000
EBP=0019f2bc  EIP=00563ca2  ESP=0019f250  CS=0023  SS=002b
EFlags=00210202
 CF- PF- AF- ZF- SF- TF- IF+ DF- OF- NT- RF+ VM- AC- VI- VP-

FPU State:
 ControlWord=027f StatusWord=4020 TagWord=ffff
 ErrorOffset=755ab6c7
 ErrorSelector=00000000
 DataOffset=00000000
 DataSelector=00000000
 Cr0NpxState=00000000

MM0=0000000000000000
MM1=8000000000000000
MM2=8000000000000000
MM3=8000000000000000
MM4=0000002b00000000
MM5=013bdce000000000
MM6=0019f2bc00000001
MM7=0000002b0019f250

Running threads:
000320c8 at 00563CA2*
00032184
00031e58
00031eb8
000323c4
000320dc
00032174

Loaded modules:
00400000 - 0159FFFF *zandronum.exe
772D0000 - 77452FFF  ntdll.dll
74D30000 - 74E0FFFF  KERNEL32.DLL
746F0000 - 74890FFF  KERNELBASE.dll
76C70000 - 76C9AFFF  GDI32.dll
75510000 - 7566AFFF  gdi32full.dll
753B0000 - 7550EFFF  USER32.dll
75220000 - 75234FFF  win32u.dll
757B0000 - 76B88FFF  SHELL32.dll
77210000 - 772CDFFF  msvcrt.dll
73E00000 - 73E35FFF  cfgmgr32.dll
76CA0000 - 7720DFFF  windows.storage.dll
74450000 - 74660FFF  combase.dll
742E0000 - 743BFFFF  ucrtbase.dll
756D0000 - 75790FFF  RPCRT4.dll
73D90000 - 73DADFFF  SspiCli.dll
73D80000 - 73D89FFF  CRYPTBASE.dll
74670000 - 746C9FFF  bcryptPrimitives.dll
748A0000 - 748E0FFF  sechost.dll
73DB0000 - 73DF4FFF  powrprof.dll
749C0000 - 74A36FFF  advapi32.dll
76C10000 - 76C55FFF  shlwapi.dll
757A0000 - 757ACFFF  kernel.appcore.dll
743C0000 - 74447FFF  shcore.dll
76C00000 - 76C0EFFF  profapi.dll
74140000 - 74224FFF  COMDLG32.dll
74A40000 - 74B29FFF  ole32.dll
74000000 - 74093FFF  OLEAUT32.dll
74B30000 - 74BAAFFF  msvcp_win.dll
6D810000 - 6DA19FFF  COMCTL32.dll
663E0000 - 663E7FFF  WSOCK32.dll
6EA10000 - 6EA33FFF  WINMM.dll
748F0000 - 74952FFF  WS2_32.dll
10000000 - 101C2FFF  fmodex.dll
6EC20000 - 6EC44FFF  GLU32.dll
6EC50000 - 6ED2FFFF  OPENGL32.dll
001D0000 - 001F2FFF  WINMMBASE.dll
73670000 - 73687FFF  MSACM32.dll
6EB30000 - 6EC1CFFF  DDRAW.dll
6FB20000 - 6FB26FFF  DCIMAN32.dll
73F80000 - 73FA4FFF  IMM32.DLL
5E420000 - 5E4A0FFF  riched20.dll
5E3E0000 - 5E410FFF  msls31.dll
67260000 - 67276FFF  USP10.dll
6E960000 - 6E9D4FFF  uxtheme.dll
73E40000 - 73F74FFF  MSCTF.dll
03710000 - 0376DFFF  RTSSHooks.dll
729F0000 - 72A92FFF  MSVCR90.dll
6E940000 - 6E95EFFF  dwmapi.dll
740A0000 - 74123FFF  clbcatq.dll
70010000 - 70053FFF  dataexchange.dll
6D250000 - 6D362FFF  dcomp.dll
6FDE0000 - 7000EFFF  d3d11.dll
6D3C0000 - 6D443FFF  dxgi.dll
6C940000 - 6CA30FFF  twinapi.appcore.dll
6FD30000 - 6FD4AFFF  bcrypt.dll
739F0000 - 739FEFFF  wtsapi32.dll
6FC40000 - 6FC82FFF  WINSTA.dll

Bytes near EIP:
00563C92: 01 00 00 53 68 2c 74 85 00 c7 45 fc ff ff ff ff
00563CA2: 88 57 04 e8 76 5b eb ff 83 c4 08 80 7d ef 00 8b
00563CB2: cb 75 39 6a 00 8b d7 e8 b2 f5 13 00 8b f8 89 7d

Possible call trace:
 00563ca2  BOOM
 0080ccbb
 007e7dd0
 007E2BC9  call 007F01BD
 0041715C  call 007E0AF1 => jmp  007E0725
 00780052
 00417F5F  call 007E053E
 007e2ba9  call [0083133c]
 007E2BC9  call 007F01BD
 007e7dd0
 00419751  call 007E053E
 0056BB52  call 00569D30
 00563FE1  call 00563BE0
 00441200
 00419800
 00419800
 00441200
 004412E1  call 00563EC0
 007a0074
 00650072
 006c0064
 007a0074
 00650072
 006c0064
 0059A225  call 007E053E
 007F3A4F  call 007E1B52
 007f0400
 007F07B3  call 007F3A43
 007F07E0  call 007FF7FD
 007F0DCE  call 007E053E
 0040fba0
 006c0064
 00420054
 0053004f
 00740040
 0056B2F1  call 007E2010
 00569d99  call [esp+0x54]
 00569DAE  call 007E053E
 0056b2b0
 0056aa64  call [00831348]
 0056BC25  call 00569D30
 005990C8  call 0056BBE0
 005990F7  call 007E053E
 007e2c00
 007E68E0  call 007F01BD
 007e66d2  call [008311a4]
 007E66DC  call 007F01BD
 007e7dd0
 007E66DC  call 007F01BD
 00470E78  call 007E6650
 0080645E  jmp  0056AB30
 00419D06  call 00418840
 00596361  call 00440F10
 00595410
 0080E1A3  jmp  0041CEF0 => jmp  00470E90
 00444443
 005967a6  call [00831274]
 005967CE  call 00595EA0
 007E8C03  call 00596750
 007e8c71
 007e8c71
 007e8c71
 007e7dd0
 007e8c71

Stack Contents:
0019F250: 0085742c 03800fec a03819ec 013bdce0  ,t········8···;·
0019F260: 00000000 00000000 00000002 41ff0000  ···············A
0019F270: 00000001 00000000 00000002 00000000  ················
0019F280: 58963f36 00000000 58963f36 00000000  6?·X····6?·X····
0019F290: 58963ed8 00000000 00000000 03800fec  ·>·X············
0019F2A0: 0330b7a0 00000069 01802450 0019f258  ··0·i···P$··X···
0019F2B0: 0019fd34 0080ccbb ffffffff fffffffe  4···············
0019F2C0: 0019f38c 773467b0 e58f6f90 fffffffe  ·····g4w·o······
0019F2D0: 0019f320 77318bd8 00000000 03801338   ·····1w····8···
0019F2E0: 032dc3e1 032dc3e1 00000000 03801338  ··-···-·····8···
0019F2F0: 0019f2dc 77315b32 0019f38c 007e7dd0  ····2[1w·····}~·
0019F300: a0ad0af8 fffffffe 007e2bce 00417161  ·········+~·aqA·
0019F310: 00000017 032f25d8 00000001 00000018  ·····%/·········
0019F320: 0330a2d0 032f16a0 00000078 00000000  ··0···/·x·······
0019F330: 0330a2e0 00000064 00780052 0380899c  ··0·d···R·x·····
0019F340: 032f25d8 00000002 00417f64 03801344  ·%/·····dA·D···
0019F350: 0019f390 007e2baf 01630000 00000000  ·····+~···c·····
0019F360: 007e2bce a03818c0 00000017 032f25d8  ·+~···8······%/·
0019F370: 00000001 0000000d 00000005 00000017  ················
0019F380: 00000001 007e7dd0 03805478 038087a0  ·····}~·xT······
0019F390: 00000003 00000000 03805488 00000064  ·········T··d···
0019F3A0: 00030019 00419756 00000000 00000090  ····V·A·········
0019F3B0: 0019f3dc a03819bc 0056bb57 a03819ec  ······8·W·V···8·
0019F3C0: 00000005 00563fe6 03800fec 00000000  ·····?V·········
0019F3D0: 00441200 00419800 00000006 00000001  ··D···A·········
0019F3E0: 00000005 0019fd54 013bdce0 00419800  ····T·····;···A·
0019F3F0: 00000005 00441200 004412e6 a0381f50  ······D···D·P·8·
0019F400: 000000e0 000001f0 00000000 05c32514  ·············%··
0019F410: 00000001 05c324fc ffffffff 00000002  ·····$··········
0019F420: 00000000 00000000 0019f5a0 0019f5a0  ················
0019F430: 0019f3f8 000000c8 0019f544 773467b0  ········D····g4w
0019F440: e58f6b40 038072b4 00000000 00000000  @k···r··········
0019F450: 00000000 00000000 773decc0 0083d2d4  ··········=w····
0019F460: 008ea6bc 03800ad4 00000000 05c60001  ················
0019F470: 00000000 00000000 7733e80c 7730e382  ··········3w··0w
0019F480: 92aa19dc 00000000 05c61aa8 05c60000  ················
0019F490: 00000014 05c600b8 00000000 0019f480  ················
0019F4A0: 05c60001 0019f510 773467b0 e58f6c00  ·········g4w·l··
0019F4B0: fffffffe 0019f520 7730e23f 00000000  ···· ···?·0w····
0019F4C0: 05c600b8 0019f520 7730e27c 7730e2d4  ···· ···|·0w··0w
0019F4D0: 92aa1848 05c61aa8 05c60001 00000000  H···············
0019F4E0: 00000000 00000000 0000979c 00000000  ················
0019F4F0: 00000001 05c60000 00001c00 0000a000  ················
0019F500: 05c61aa8 05c60400 0019f4d0 00000000  ················
0019F510: 0019f5bc 773467b0 e58f6da0 fffffffe  ·····g4w·m······
0019F520: 7730e2d4 7730e053 0019f598 00000000  ··0wS·0w········
0019F530: 00000169 00000000 0152d900 0019f47c  i·········R·|···
0019F540: 00000000 0019f5bc 00000000 e58f6dc0  ·············m··
0019F550: 0019f5cc 7732a5f6 05c30002 05c61aa8  ······2w········
0019F560: 05c30002 05c30002 05c30002 0019fab0  ················
0019F570: 0188a318 0188e548 00000000 00000000  ····H···········
0019F580: 0188a328 00000064 00120025 01851e40  (···d···%···@···
0019F590: 0019f604 05c30002 00000003 0019f5ec  ················
0019F5A0: 772fd1ba 773e062c 772fd0ec 92aa1884  ··/w,·>w··/w····
0019F5B0: 0019fab0 05c30002 05c30002 05c30002  ················
0019F5C0: 01853ca8 ffffffff 00000000 01853c30  ·<··········0<··
0019F5D0: 01000000 0019f5ac 00000000 0019fb50  ············P···
0019F5E0: 773467b0 e58f91e8 fffffffe 772fd0ec  ·g4w··········/w
0019F5F0: 772fd070 05c30002 00000000 7733e87c  p·/w········|·3w
0019F600: 747b9efe ffffffff 05c30000 0019fab0  ··{t············
0019F610: 05c30002 0152d938 05c30000 0019f850  ····8·R·····P···
0019F620: 747c45c8 05c30002 00000000 00000020  ·E|t········ ···
0019F630: 747c45d5 00080006 0019fac8 00000169  ·E|t········i···
0019F640: 007a0074 00650072 002e0073 006c0064  t·z·r·e·s·.·d·l·
0019F650: 0000006c 92aa189c 0019f730 753bec0b  l·······0·····;u
0019F660: 753be8b6 5b4ed1be 00000000 00000000  ··;u··N[········
0019F670: 753be8e3 01840000 7731766b 0189ce58  ··;u····kv1wX···
0019F680: 00000000 77317447 92aa1ab0 00000390  ····Gt1w········
0019F690: 01840000 00000388 00000024 00000001  ········$·······
0019F6A0: 00000000 00000000 0a00000a ffffffff  ················
0019F6B0: 00000024 00000001 02000002 00000000  $···············
0019F6C0: 30000232 ffffffff ffffffff fffffe40  2··0········@···
0019F6D0: 01844ccc 00000000 00000000 00000000  ·L··············
0019F6E0: 00000000 00000000 5e448430 00000000  ········0·D^····
0019F6F0: 01d009f8 0189ce58 80000010 00000001  ····X···········
0019F700: 00000000 00000070 00000000 00000001  ····p···········
0019F710: 00bf139c 000001c0 01840000 753be4c0  ··············;u
0019F720: 0019f780 753e15b0 00000000 000007ff  ······>u········
0019F730: 00000232 018400c0 01845c50 00000000  2·······P\······
0019F740: 0000000f 00000000 00000390 00282000  ············· (·
0019F750: 00000001 5b4ed11e 000001b2 00000000  ······N[········
0019F760: 01190188 00000001 00000232 018400c0  ········2·······
0019F770: 00000001 00000000 00000000 0189ce50  ············P···
0019F780: 0189ce50 0028000a 0189ce58 0189ce58  P·····(·X···X···
0019F790: fffffffe 00000000 00f1e4a0 0a00000a  ················
0019F7A0: 000001c0 018925c0 00000000 00000000  ·····%··········
0019F7B0: 018400c0 00000000 00000140 01845bf8  ········@····[··
0019F7C0: 0019f7d4 00000000 0019fb50 773467b0  ········P····g4w
0019F7D0: e58f6fb0 fffffffe 0019f818 77315c95  ·o···········\1w
0019F7E0: 00000388 00000390 0184045c 0019f80c  ········\·······
0019F7F0: 0189ce58 74864c78 0019fa58 00000390  X···xL·tX·······
0019F800: 00000000 00000000 00000000 00000003  ················
0019F810: 00280008 0189ce58 0019f82c 77315b32  ··(·X···,···2[1w
0019F820: 00280008 74864c78 0189ce58 0019f850  ··(·xL·tX···P···
0019F830: 74864c78 0019f850 747c4798 0189ce58  xL·tP····G|tX···
0019F840: 00000000 0019fa58 00000020 0019f880  ····X··· ·······
0019F850: 0019fa44 747c402a 0152d8e0 00000001  D···*@|t··R·····
0019F860: 747c3f96 0019f888 0019fa58 0152d8e4  ·?|t····X·····R·
0019F870: 0152d938 00000000 0000040c 00bf139c  8·R·············
0019F880: 0040040c 007a0074 00650072 002e0073  ··@·t·z·r·e·s·.·
0019F890: 006c0064 002c006c 0033002d 00320036  d·l·l·,·-·3·6·2·
0019F8A0: 00000000 772f92e9 00000001 038009dc  ······/w········
0019F8B0: 01631410 0059a22a 016ef230 92aa15c0  ··c·*·Y·0·n·····
0019F8C0: 0019f918 00000000 007f3a54 0019f918  ········T:·····
0019F8D0: 008f8460 016314d8 0019fb67 007f0400  `·····c·g······
0019F8E0: 0019f97c 007f07b8 00000020 007f07e5  |······ ······
0019F8F0: 01631410 01631410 007f0dd3 00000020  ··c···c···· ···
0019F900: 0040fba0 00000000 00000000 002e0073  ··@·········s·.·
0019F910: 006c0064 00000000 008f8460 016314d8  d·l·····`·····c·
0019F920: 016305a8 0019fa01 00000000 00000000  ··c·············
0019F930: 00000000 00838957 00000000 00000002  ····W···········
0019F940: 00000000 00420054 0000000d 0019fb94  ····T·B·········
0019F950: 0019fbd0 00000001 0019fb67 ffffffff  ········g·······
0019F960: 002900e9 00000048 48000000 0189c140  ··)·H······H@···
0019F970: c5000000 6fc45c5a 756f2030 0019fbf4  ····Z\·o0 ou····
0019F980: 0019fcb4 0189b860 0000000c 00000000  ····`···········
0019F990: 756ef540 00000001 0189ba5c 00000000  @·nu····\·······
0019F9A0: 00000000 00000000 0189b9b0 0189bb24  ············$···
0019F9B0: 0187bac8 0189b860 0189b9b0 77317447  ····`·······Gt1w
0019F9C0: 92aa1678 00000048 01630000 0000003c  x···H·····c·<···
0019F9D0: 6fc42c74 0019fcac 03000003 77317447  t,·o········Gt1w
0019F9E0: 1f000817 00000030 01630000 00000024  ····0·····c·$···
0019F9F0: 03000003 00000000 1f000817 77317447  ············Gt1w
0019FA00: 92aa1638 00000018 03800000 00000010  8···············
0019FA10: 03000003 0019fba0 1f000817 0019fba8  ················
0019FA20: 32000032 ffffffe1 016358f4 032dc3c8  2··2·····Xc···-·
0019FA30: b3001ead 0053004f b3001ead 00000006  ····O·S·········
0019FA40: 32000032 ffffe156 038004a6 00000001  2··2V···········
0019FA50: 01630000 747c3e2c 01630288 00740040  ··c·,>|t··c·@·t·
0019FA60: 00000000 773192c9 92aa1608 03800a60  ······1w····`···
0019FA70: 03800000 773192c9 92aa1618 03800a78  ······1w····x···
0019FA80: 03800000 03800a80 00000032 00001eaa  ········2·······
0019FA90: 03800000 00000000 01000112 00000001  ················
0019FAA0: 00000000 773192c9 92aa16c8 01631408  ······1w······c·
0019FAB0: 01630000 01631410 03000003 77317447  ··c···c·····Gt1w
0019FAC0: 92aa1178 00000098 03800000 00000090  x···············
0019FAD0: 00000000 00000000 018307d0 03800000  ················
0019FAE0: 00000000 0000007f 03010002 03800a60  ···········`···
0019FAF0: dd001ec3 0000007f dd001ec3 00000008  ···············
0019FB00: 032d9fd0 ffffe150 038004c6 773192c9  ··-·P·········1w
0019FB10: 92aa1160 038009c8 03800000 038009d0  `···············
0019FB20: 03800a98 038000c0 00000001 038009d0  ················
0019FB30: 00000000 0000007f 01631410 ffffe150  ·········c·P···
0019FB40: 0000001f 01010000 03800260 00001eb0  ········`·······
0019FB50: 03800000 03800260 00000007 77310000  ····`·········1w
0019FB60: 00000000 03800a07 008e8c58 0000002c  ········X···,···
0019FB70: 0056b2f6 03800a07 0085e739 00000001  ··V·····9·······
0019FB80: 008e8c58 00000004 00000004 00000001  X···············
0019FB90: 0000002b 0085e739 00569d9d 00000001  +···9·····V·····
0019FBA0: 0085e71c 008e8c58 0019fddc 00569db3  ····X·········V·
0019FBB0: 75000000 00003000 658009c8 00000001  ···u·0·····e····
0019FBC0: 0019fcb0 000009d0 0019fc74 0000002b  ········t···+···
0019FBD0: 008e8c58 ffffffff 00000000 00000000  X···············
0019FBE0: 00000000 0085e739 038000c0 00837724  ····9·······$w··
0019FBF0: 0056b2b0 00000000 00858030 00000004  ··V·····0·······
0019FC00: 0019fdd0 00000000 00000000 0085e739  ············9···
0019FC10: 00000000 77315c95 00000000 00000098  ·····\1w········
0019FC20: 038002e0 0019fc44 0085e71c 00000090  ····D···········
0019FC30: 00000001 00000098 00000000 00000000  ················
0019FC40: 03800260 00000003 00000000 038009d0  `···············
0019FC50: 0019fc60 77315b32 00000000 00000000  `···2[1w········
0019FC60: 0019fddc 0056aa6a 032e9508 00000000  ····j·V···.·····
0019FC70: 00000090 30303239 a03810e0 0056bc2a  ····9200··8·*·V·
0019FC80: 0085e71c 0019fc9c 000000e0 0085d45c  ············\···
0019FC90: 005990cd 008e8c58 0085e71c 00843a00  ··Y·X········:··
0019FCA0: 0085d45c 00000006 00000002 000023f0  \············#··
0019FCB0: 000001f0 005990fc 0000009c 00000006  ······Y·········
0019FCC0: 00000002 000023f0 00000002 007e2c00  ·····#·······,~·
0019FCD0: 00000000 01631348 01631348 007e68e5  ····H·c·H·c··h~·
0019FCE0: 00000000 0019fd28 007e66d8 01630000  ····(····f~···c·
0019FCF0: 00000000 007e66e1 a0381678 a0381f5c  ·····f~·x·8·\·8·
0019FD00: 01631348 00000000 0019fd30 0019fcf4  H·c·····0·······
0019FD10: 0019fcf8 0019fdd0 0019fdd0 007e7dd0  ·············}~·
0019FD20: a0ad0998 fffffffe 007e66e1 00470e7d  ·········f~·}·G·
0019FD30: 01631348 0019fdd0 00806463 00000002  H·c·····cd······
0019FD40: 009abf00 00419d0b 00000004 00000000  ······A·········
0019FD50: 00010300 0019fddc 00596366 a038168c  ········fcY···8·
0019FD60: 000023f0 00000002 00400000 00000000  ·#········@·····
0019FD70: 00000000 000001f0 00000159 01840000  ········Y·······
0019FD80: 0000001a 01830898 00000000 00595410  ·············TY·
0019FD90: 00000000 00000000 00400000 0b751587  ··········@···u·
0019FDA0: 00010003 00000000 00000000 0085dfb0  ················
0019FDB0: 00000001 000f4240 0184dce0 00000000  ····@B··········
0019FDC0: 03800984 74d30000 00400000 0019fd5c  ·······t··@·\···
0019FDD0: 0019ff70 0080e1a8 00000000 00444443  p···········CDD·
0019FDE0: 00000000 00000000 00000000 00000000  ················
0019FDF0: 00000000 00000000 00000000 04010401  ················
0019FE00: 0000007c 207c00a0 00000000 00000000  |·····| ········
0019FE10: 00000000 00000000 00000000 00000000  ················
0019FE20: 00000000 00000000 00000000 00000000  ················
0019FE30: 00000000 00000000 00000000 00000000  ················
0019FE40: 00000000 00000020 00000780 00000438  ···· ·······8···
0019FE50: 00000000 0000003c 00000000 00000000  ····<···········
0019FE60: 00000000 00000000 00000000 00000000  ················
0019FE70: 00000000 00000000 2043435a 352e3176  ········ZCC v1.5
0019FE80: 415a2820 4f52444e 204d554e 2e312e32   (ZANDRONUM 2.1.
0019FE90: 20202932 30353128 2d383137 39323031  2)  (150718-1029
0019FEA0: 7400294d ffffffff fffffffe ffffffff  M)·t············
0019FEB0: 013c3434 00000000 00000000 00000002  44<·············
0019FEC0: 0019ff80 005967ac ffffffff fffffffe  ·····gY·········
0019FED0: ffffffff 013c3434 00000000 a038168c  ····44<·······8·
0019FEE0: 0019ff80 005967d3 00000001 007e8c08  ·····gY·······~·
0019FEF0: 00400000 00000000 01843df2 00000001  ··@······=······
0019FF00: a03814d0 007e8c71 007e8c71 00281000  ··8·q·~·q·~···(·
0019FF10: 00000044 0185c7f0 0185c810 0184e3d8  D···············
0019FF20: 00000000 00000000 00000000 00000000  ················
0019FF30: 00000000 00000000 00000000 00000401  ················
0019FF40: 00000001 00000000 00000000 00010001  ················
0019FF50: 00000000 c0000005 00000002 00000006  ················
0019FF60: 00000000 007e8c71 0019ff00 0019ec18  ····q·~·········
0019FF70: 0019ffcc 007e7dd0 a0ad0f10 00000001  ·····}~·········
0019FF80: 0019ff94 74d462c4 00281000 74d462a0  ·····b·t··(··b·t
0019FF90: 8e79a0e3 0019ffdc 77330fd9 00281000  ··y·······3w··(·
0019FFA0: 92aa12b4 00000000 00000000 00281000  ··············(·
0019FFB0: 00000000 00000000 00000000 00000000  ················
0019FFC0: 92aa12b4 0019ffa0 00000000 0019ffe4  ················
0019FFD0: 773467b0 e58f6a78 00000000 0019ffec  ·g4wxj··········
0019FFE0: 77330fa4 ffffffff 77352ef4 00000000  ··3w·····.5w····
0019FFF0: 00000000 007e8c71 00281000 00000000  ····q·~···(·····

EDIT: after loading the game with Zandronum 3.0 all the ressources weren't added, so I suppose that the "folder" ressource option is broken.

[ZZYZX]

It's very unlikely related to GZDB, but you might have some unsupported ACS in your resources especially given that 3.0 works normally — check for local arrays (in scripts and functions) and named scripts.
In case you don't have anything like that, I suggest you reporting it at the Zandronum bug tracker.

Folder as resource essentially utilizes GZDoom's own ability to pass directories with -file, and from what I know there is no further processing about it.
Anyway, does it work with regular GZDB (non bugfix)?

[meatman12]

Got this while pushing the OK button on the sector editing screen.

Code: Select all

***********SYSTEM INFO***********
OS: Microsoft Windows 10 Home
GPU: AMD Radeon(TM) R7 Graphics
GZDB: R2903

********EXCEPTION DETAILS********
Object reference not set to an instance of an object.
   at CodeImp.DoomBuilder.Windows.SectorEditFormUDMF.MakeUndo() in w:\dev\GZDoom-Builder\Source\Core\Windows\SectorEditFormUDMF.cs:line 663
   at CodeImp.DoomBuilder.Windows.SectorEditFormUDMF.apply_Click(Object sender, EventArgs e) in w:\dev\GZDoom-Builder\Source\Core\Windows\SectorEditFormUDMF.cs:line 827
   at System.Windows.Forms.Control.OnClick(EventArgs e)
   at System.Windows.Forms.Button.OnClick(EventArgs e)
   at System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent)
   at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ButtonBase.WndProc(Message& m)
   at System.Windows.Forms.Button.WndProc(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

[ZZYZX]

Did you simply edit a sector or create it?
What mode did you edit the sector from? (Draw grid, draw rectangle, make sector, sectors mode, visual mode?)

[blood]

It's very unlikely related to GZDB, but you might have some unsupported ACS in your resources especially given that 3.0 works normally — check for local arrays (in scripts and functions) and named scripts.
In case you don't have anything like that, I suggest you reporting it at the Zandronum bug tracker.

Folder as resource essentially utilizes GZDoom's own ability to pass directories with -file, and from what I know there is no further processing about it.
Anyway, does it work with regular GZDB (non bugfix)?

The crash happened in the last version of GZDB too. But by using the exact same ressources inside a .pk3 there are no crashes.

I've a question is it possible to make GZDB able to load the ressources even with errors like "double defined actors"?

I've been forced to use folder as ressources because when I use .pk3 GZDB freeze/crash in 3D View mode. And now that I can't even test my maps with folder anymore I'm stuck.
Zandronum is loading the pk3 fines and that problem didn't happen before.

[boris]

I ran into a really crazy problem while compiling GZDB-Bugfix. So I have a folder where I got all my programming projects, and so in that folder I have folders called GZDoom-Builder and GZDoom-Builder-Bugfix. Whenever I started GZDB-Bugfix from VS I got a message, that my BuilderModes.dll is from another build, and yes, it was. Took me some time to figure it out, but apparently it copies the BuilderEffects.dll and BuilderModes.dll from the GZDoom-Builder folder to the GZDoom-Builder-Bugfix folder instead of using the freshly compiled one from GZDoom-Builder-Bugfix\Source\Plugins\BuilderModes\obj. Renaming the GZDoom-Builder folder to something else fixed the problem, but that seems more like a workaround, since there's probably something else amiss.

[ZZYZX]

I've a question is it possible to make GZDB able to load the ressources even with errors like "double defined actors"?

I'm strongly against this idea, because errors such as this are to be caught ASAP (and ZScript doesn't allow duplicate definitions already).
However, there will be a checkbox "exclude from parsing" eventually (not now, now I'm busy with this because it blocks everyone).

I've been forced to use folder as ressources because when I use .pk3 GZDB freeze/crash in 3D View mode. And now that I can't even test my maps with folder anymore I'm stuck.

Send folder. Send PK3. Send whatever so I can test locally

I ran into a really crazy problem while compiling GZDB-Bugfix. So I have a folder where I got all my programming projects, and so in that folder I have folders called GZDoom-Builder and GZDoom-Builder-Bugfix. Whenever I started GZDB-Bugfix from VS I got a message, that my BuilderModes.dll is from another build, and yes, it was. Took me some time to figure it out, but apparently it copies the BuilderEffects.dll and BuilderModes.dll from the GZDoom-Builder folder to the GZDoom-Builder-Bugfix folder instead of using the freshly compiled one from GZDoom-Builder-Bugfix\Source\Plugins\BuilderModes\obj. Renaming the GZDoom-Builder folder to something else fixed the problem, but that seems more like a workaround, since there's probably something else amiss.

That's... odd. I personally have the directory called GZDoom-Builder for historical reasons so it didn't happen to me. Will check, but definitely not right now and would like you to at least find the cause if you have time.