Grouped action specials in DECORATE

[randi]

Will grouped action functions be added to the main branch, or will we need to wait for DoomScript before we see this change added?

Yes.

[Graf Zahl]

Best non-answer ever...

[randi]

I did another thing. And in so doing, I think I found some errors in FxConditional::Emit() that need fixing.

[Blzut3]

Yes, the braces are required. Because I see too many instances where somebody writes an if statement in ACS and doesn't understand why it doesn't work right because they forgot braces.

A little harsh I think. Granted I probably don't read as much of the forums, but I would think just making sure an if statement is not followed by a semicolon would solve most cases. That's usually the error I see since most beginner tutorials use the braces all the time (or at least they probably should).

More importantly right now it looks like there's no elegant "else if".

[randi]

More importantly right now it looks like there's no elegant "else if".

Humbug. You're right. I suppose maybe I should change that. I don't want to spend too much time buffing up DECORATE, though.

[Nash]

I'm curious as to how a clean (or expected) identation style would look like for this stuff. Does this look correct?

Code: Select all

Actor Heh
{
    States
    {
        POSS G 3
        {
            if (health > 1000)
            {
                A_Scream;
            }
            else
            {
                A_XScream;
            }
        }
        POSS F 3
        Stop
    }
}
 

or perhaps like this?

Code: Select all

Actor Heh
{
    States
    {
        POSS G 3
                {
                    if (health > 1000)
                    {
                        A_Scream;
                    }
                    else
                    {
                        A_XScream;
                    }
                }
        POSS F 3
        Stop
    }
}
 

[Blzut3]

I think in this case using the brace on the same line style would be preferrable:

Code: Select all

POSS G 3 {
    if (health > 1000) {
        A_Scream;
    } else {
        A_XScream;
    }
}
POSS F 3
stop

At the very least putting the first brace on the same line as the state would make it clear that it's an action function even if everything else is separate line. If you really feel like putting the opening brace on a separate line then your first example or a single tab should do. Don't try to align like your second example, large indentations become problematic to read eventually.

[Fishytza]

More importantly right now it looks like there's no elegant "else if".

...That and it looks like if statements within if statements are not yet possible(?) Nevermind.

[Gez]

Also, it doesn't include autoarrays, codepointer overloading, multiple inheritance, and multithreading. Boohoohoo.

[Edward-san]

Don't forget all the ownership thing. Bwheheheheee.

[randi]

Also, it doesn't include autoarrays, codepointer overloading, multiple inheritance, and multithreading.

And it never will.

[Gez]

Oh noes!

[Major Cooke]

Thank god for that, that's one thing I never enjoyed when programming within ZDooM's source code.

[Major Cooke]

Also, fellas, it appears for a single action it doesn't need braces.

Code: Select all

    // If it's not a '{', then it should be a single action. 
    // Otherwise, it's a sequence of actions.
    if (!sc.Compare("{"))
    {
        tcall->Code = ParseAction(sc, state, statestring, bag);
        return;
    }

So you could do this:

Code: Select all

POSS G 3
{
	if (health > 1)
		A_Jump(256,"Alive") //Or perhaps Goto Alive could work?
	else
		A_Jump(256,"Dead") //Or perhaps Goto Dead could work?
}

Except I dont know if gotos are allowed like that. Randi, does that seem like something which would work?

Oh man I'm excited to see this put into the main branch.

[NeuralStunner]

Since Goto is not a frame action, I don't see a reason for it to work as part of a frame.