[2.3.0] Bugs? : music error and decreased fps

[TimeOfDeath]

I saw that ZDoom 2.3.0 has improved performance on intensive maps, so I tried this map but got a lower framerate compared to 2.2.0 - start map01 on ultra-violence, don't move, check fps. (edit: I tried a couple other maps and also have a lower framerate compared to 2.2.0)

Also, the song in this map doesn't play - it says "song not found" in the console, but it works in 2.2.0.

[Graf Zahl]

What kind of system do you have (CPU, graphics card)?

One thing to note is that on older single core processors the new FMod may cause some performance loss.
On my dual core CPU the frame rate is precisely the same in 2.2.0 and 2.3.0.

The music problem is a definition error in the WAD. You can't just place an endless string in there and hope that it works. The string handling for WAD lookups has changed a bit between 2.2.0 and 2.3.0 so the incorrect definition which slipped through in 2.2.0 and just happened to work by coincidence is now caught and produces an error.

[TimeOfDeath]

My dooming computer is:
Pentium 4 CPU 2.26GHz, 512 MB of RAM
NVIDIA GeForce4 MX 420
640x480 in zdoom

Here's what I get while standing still at the start of each map for several seconds on ultra-violence:

doom2 map01
2.2.0 - 240 fps
2.3.0 - 224 fps

aahhnuts
2.2.0 map01 - 70 fps
2.3.0 map01 - 2 fps (no joke)
2.2.0 map02 - 109 fps
2.3.0 map02 - 85 fps

flanagan
2.2.0 - 67 fps
2.3.0 - 29 fps

smedley
2.2.0 - 121 fps
2.3.0 - 95 fps


I also have a laptop that's faster, but I hate playing on it because of the keyboard:
Pentium 4 CPU 3 .20GHz, 512 MB of RAM
ATI MOBILITY RADEON 9700
640x480 in zdoom

doom2 map01
2.2.0 - 271 fps
2.3.0 - 260 fps

aahhnuts
2.2.0 map01 - 125 fps
2.3.0 map01 - 95 fps
2.2.0 map02 - 139 fps
2.3.0 map02 - 130 fps

flanagan
2.2.0 - 109 fps
2.3.0 - 92 fps

smedley
2.2.0 - 159 fps
2.3.0 - 148 fps


About the music - the original filename of the midi is the same as what's in the mapinfo. I didn't realize until now that it got cut off at 8 characters when I added it to the wad with xwe. The music worked fine in 2.2.0 and older versions, and it worked in ZDaemon, so I didn't realize there was any error when the map was released . Did the old string handling cause problems in some wads?

The decreased framerate is a big deal for me, though, since some maps just barely run acceptably with 2.2.0 on my dooming computer. Not to sound rude though, because I really like this port, I'll just have to stick with 2.2.0 for intensive maps.

[randi]

As you had some interesting slowdowns, I decided to test on my machine. These runs were done with default, unaltered configs to minimize variables:

doom2
2.2.0: 820
2.3.0: 860

aahhnuts
map01 2.2.0: 420
map01 2.3.0: 320
map02 2.2.0: 450
map02 2.3.0: 450

flanagan
2.2.0: 370
2.3.0: 360

smedley
2.2.0: 510
2.3.0: 530

On mine, aahhnuts map01 looks to be the only one that might be statistically meaningful. However, in none of these cases was the garbage collector being triggered, which is what I was alluding to with the claim of improved performance on intensive maps (you can't really test it by standing still), so the cause for your frame loss must lie elsewhere.

Though I am quite curious about what happened with aahhnuts map01, I don't think there's anything particularly special about the rest of them.

[Graf Zahl]

My dooming computer is:
Pentium 4 CPU 2.26GHz, 512 MB of RAM
NVIDIA GeForce4 MX 420
640x480 in zdoom

...


I also have a laptop that's faster, but I hate playing on it because of the keyboard:
Pentium 4 CPU 3 .20GHz, 512 MB of RAM
ATI MOBILITY RADEON 9700

So both of your systems indeed are single core processors and don't have the most of RAM. I suspect it's a combination of these 2 issues. Can you try the same WADs on both versions with the command line parameter '-nosound' added so that we can at least verify if it is the sound?


Concerning the file name, the change was necessary because ZDoom supports Zips and long file names now. As a result the old assumption from the WAD lookup code that only the first 8 characters are valid no longer applies. This was causing problems with a few files where lump names were not properly matched due to this.

[randi]

I just made a change that makes the performance at the starts of these maps identical with 2.2.0's. Would you mind trying it once Enjay uploads zdoom-r1460.zip (or newer) and letting me know how it fares for you?

[Graf Zahl]

Didn't I say so?

http://forum.zdoom.org/viewtopic.php?f= ... 6&p=396674

[Enjay]

Would you mind trying it once Enjay uploads zdoom-r1460.zip (or newer) and letting me know how it fares for you?

I'll do it as soon as I get home. Currently 09.40. I'll get home around 18.00.

[Enjay]

Done

[randi]

Didn't I say so?

You did, but I figured I wasn't clocking things enough for it to matter.

[TimeOfDeath]

Sorry for the late reply. Thanks for looking into it and posting a new version. Here's what I got with r1465 on my 2.2.6 GHz computer:

doom2 map01
2.2.0: 242 (-nosound 252)
2.3.0: 224 (-nosound 249)

aahhnuts map01
2.2.0: 70 (-nosound 76)
2.3.0: 46 (-nosound 63)

flanagan
2.2.0: 67 (-nosound 72)
2.3.0: 54 (-nosound 61)

smedley
2.2.0: 121 (-nosound 126)
2.3.0: 111 (-nosound 119)

Btw, I assumed it wasn't a problem but all the tests I've done (including the ones from last week) were done with a copied zdoom.ini file from my 2.2.0 folder and pasted into the 2.3.0 folder.