SBARINFO

[Graf Zahl]

No. But I wasn't working on ZDoom last week (except fixing a few minor bugs that I caught while playing) and I simply forgot about it.

[Graf Zahl]

Could you please have a look at DSBarInfo::DrawGem? It generated a compiler error so I had to take a guess to fix it. Could you confirm that what I did is correct?

[Blzut3]

Looks correct to me, and apparently you also fixed a bug I never noticed.

[Graf Zahl]

Which one would that be?

[Blzut3]

Well from the looks of it you had to add the offsets and alpha to the calls to DrawGraphic() right? So therefor before drawgem could not be used in translucent (bar) or sliding pop-ups without it looking odd.

[HotWax]

I was just looking at the patch notes for this change and this line jumped out at me:

(Emphasis mine)

Added a Fade transition for popups. It takes two args fade in rate and fade out rate. Both are floats (1.0 = 1 tic to complete 0.5 = 2 tics to complete and so on).

This is precisely backwards from the way HudMessages work. For them, the higher the value the longer the fade takes to complete. Is there a reason these two behaviors shouldn't be more consistent?

[Blzut3]

Because it was easier for me to just add/subtract the value given every tic and I wasn't even thinking about hudmessage at the time.

[Gez]

Well, just add/substract the inverse of the value...

[Graf Zahl]

Because it was easier for me to just add/subtract the value given every tic and I wasn't even thinking about hudmessage at the time.

Very bad implementation practice. Please change.

[Blzut3]

Of course I am going to change it. I just don't have a way to run ZDoom at the moment.

Well, just add/substract the inverse of the value...

Its more like 1.0/(35*input).

[HotWax]

If it's going to be 100% consistent with HudMessage, it should be in seconds as well... The note makes it sound like it's in number of tics (which is silly anyway, because you can't wait half a tic... )

[Blzut3]

No it wasn't number of tics. Its the rate of fade. So for a rate of 0.25 it would do the following.
Tic1: Popup Activated: 0.0
Tic2: 0.25
Tic3: 0.50
Tic4: 0.75
Tic5: 1.0

Anyways here is the patch to change it to seconds.

[Blzut3]

The following questions are directed towards Randy or Graf:

1. Would it be OK to rip out the mugshot code in the doom status bar and replace it with the scriptable form from SBarInfo? As far as I can tell this will bring no changes to any existing mods.
2. Is there any chance of having the Hexen weapon pieces converted to custom weapon pieces? I think right now I would have to implement a whole way of checking for these 9 weapon pieces to do the Hexen status bar. (I believe this is the only thing that is holding me back from completing Hexen status bar support for SBarInfo.)

[Graf Zahl]

1. No. If you think it will help you, feel free to do it.
2. It's a bit of work but doable. If this really would help you I can do it but it's something I have to think about first.

[Graf Zahl]

Added the patch.