[2.1.5] Health bonuses don't take health past Max Health

[pritch]

I've noticed with some dehacked patches that health bonuses aren't taking health past Max Health, where they should take it up to Max Soulsphere. Picking up a Soulsphere or Megasphere still works, however.

[Graf Zahl]

Sigh...

This is all a result of an old Boom bug which used max health incorrectly.
And no, the health bonus is not supposed to go up do max soulsphere. Correctly implemented it should go up to max health and with Boom's incorrect implementation (which sadly has become the de-facto standard) it goes up to 2* max health.

So I changed it to the same value used by all other ports (i.e. 2*max health)

[sirjuddington]

What? Health potions have always gone up to 200% How long is it since you played doom2.exe? Or are we talking about dehacked patches that bring the default max health up above 100% here?

[pritch]

What? Health potions have always gone up to 200% How long is it since you played doom2.exe? Or are we talking about dehacked patches that bring the default max health up above 100% here?

Yes, but if no one is prepared to address the issue properly some older wads using patches won't play correctly.

[pritch]

If 2*max health is correct, OK, but it is not going up to 2*max health where max health has been altered in a patch. Rather you get to max health then bonuses are collected but not counted, unlike in doom2.exe where this happens at 2*max health.

So what would be good would be if bonuses can be counted to 2* whatever the deh states is max health.

[Graf Zahl]

That's how I changed it. At least it's consistent with all other ports out there - even though it's not how Dehacked handled it. But on the other hand, how many maps with several hundred health bonuses and a Dehacked patch are there? Not many, I presume.