[0.10.6] Gun Bonsai -- everything-compatible weapon upgrading

[ToxicFrog]

What the hell, how does the target stop existing halfway through this function, argh

I guess maybe if you hit something and sweep procs and kills something next to it and the thing that dies has some kind of death effect that kills the swept target?

Should be a straightforward fix, although I think I'm rapidly approaching the point where I need to split 0.11 into 0.10.3 (nonbreaking bugfixes) and 0.11.0 (breaking updates) branches, so it might be a bit before it actually gets released.

[Dan_The_Noob]

What the hell, how does the target stop existing halfway through this function, argh

I guess maybe if you hit something and sweep procs and kills something next to it and the thing that dies has some kind of death effect that kills the swept target?

Should be a straightforward fix, although I think I'm rapidly approaching the point where I need to split 0.11 into 0.10.3 (nonbreaking bugfixes) and 0.11.0 (breaking updates) branches, so it might be a bit before it actually gets released.

I had chain lightning, thunderbolt on chainsaw. so it's entirely possible it got instantly vaporised by one of the lightning/thunder before being sweeped.

it's not SUPER urgent, it crashed after about 10 consistent minutes of sawing through mobs.

[stainedofmind]

So, am I wrong that DOT attacks shouldn't trigger other effects at death, in this case specifically Submunitions? Unless I was way off the mark, the comments in the code (regarding upgrade priority) suggested this, however while testing my mod, I noticed that I was getting the good ole room clearing monster effect from back in the day due to Corrosive Shots setting off a chain reaction, specifically one level of it and my modified Submunitions upgrade. I ran a few quick tests, and I was able to duplicate the issue with just GB. This feels a touch over powered to me.

[Dan_The_Noob]

OH I forgot about another thing that happened, stainedofmind just reminded me.

Submunitions kill yourself when they expire now.
which can become pretty treacherous very quickly, because they can clip inside you so they do ripper-esque damage.

[ToxicFrog]

I think the Sweep issue is that you're using 0.10.2, and I was looking at 0.10.3 which I actually built a while ago to fix that issue but never properly announced in the thread. Oops.

OnKill always fires, no matter how you killed the enemy. This is a gross hack and a compromise to work around some different issues that arise if it obeys normal priority rules. I'm still not entirely happy with that part of the code. Or Submunitions, really. I was trying to replicate the delight of the pipebomb upgrades in WoA but don't really think I've nailed it. Maybe they should do no damage but instead spread debuffs around?

They also definitely shouldn't be killing you on expiration, oops. Not sure what's going on there, but I'll look into it.

Hoping to cut 0.10.4 sometime tomorrow, which won't be everything I've working on but should have a whole bunch of bugfixes in it.

[Dan_The_Noob]

OnKill always fires, no matter how you killed the enemy. This is a gross hack and a compromise to work around some different issues that arise if it obeys normal priority rules. I'm still not entirely happy with that part of the code. Or Submunitions, really. I was trying to replicate the delight of the pipebomb upgrades in WoA but don't really think I've nailed it. Maybe they should do no damage but instead spread debuffs around?

I always think about submunitions being weird, what if they fired out a little more aggressively but didn't bounce and just exploded a little more aggressively? like a cluster bomb (given that the self-killing part gets fixed up)

[ToxicFrog]

Finally released 0.10.4! It contains a lot of bugfixes, some balance changes, and some requested features: AutoAutoSave integration, disabling of player or weapon upgrades entirely, and colour customization for the screenflash. The menu UX has also been improved for situations where you have multiple level-ups queued, allowing you to choose all of them without constantly needing to re-open the menu.

The full changelog and pk3 can be found on the release page here.

The next major release is going to be 0.11, which splits Legendoom integration into its own mod (already done) and does a bunch of internal cleanup and adds some new toys; it will break save compatibility. I'm not ruling out the possibility of more bugfixes in the 0.10 branch, though.

[Ltmajordude]

AutoAutoSave integration???

Woooooooooo, you have no idea how much this makes me happy. Thank you thank you thank you!
Though one thing to point is that this seems to only work when I enabled the Autoautosave Toggle: Important Item is Found.

I don't mind enabling that option but maybe give a heads up about that option needed to be enabled in order for the autoautosave part to work?

[Dan_The_Noob]

I have 1 issue with 0.10.4 before even starting it...
say you have 5 upgrades queued for some reason, but while picking one you have enemies attacking you... if you close the menu, do you "reset" all 5 and have to get them again? (waste 5 levels worth of EXP)

[ToxicFrog]

Though one thing to point is that this seems to only work when I enabled the Autoautosave Toggle: Important Item is Found.

I don't mind enabling that option but maybe give a heads up about that option needed to be enabled in order for the autoautosave part to work?

I think that's also part of this autoautosave bug -- the mod integration API re-uses parts of the important item pickup handler, which I guess means it also requires that setting to be on. I'll update the tooltip.

I have 1 issue with 0.10.4 before even starting it...
say you have 5 upgrades queued for some reason, but while picking one you have enemies attacking you... if you close the menu, do you "reset" all 5 and have to get them again? (waste 5 levels worth of EXP)

Cancelling out of the menu will reject one of the queued level-ups, close the menu, and reroll the available choices. You won't lose all of them.

Of course, it should also pause when the menu opens, unless you're playing in multiplayer.

[Starman the Blaziken]

I sort of had a bit of a brainstorming idea recently after I was wanting to see if I could pitch in anything for Searing Inscription changes while that bit of discussion was there.

But in the process recently I have had a concept for something to parallel to Resurrection. Since the base Shocking Inscription perk used to brokenly stun lock enemies in place and the current just slows them down, I think there could be a branch to the mastery perk that at a chance could freeze enemies when they are dead (at least to check after a period with an added random bit of time nor can be shot at to prevent issues like lag from the ice chunks or enemies with phases between death if that is possible). And when they break apart it hurts nearby enemies maybe subsequently freezing them in a sort of slow chain reaction?
I do have a few different ideas to enemy freezing if it is challenging to work with, but something I want to toss if you might have had open thoughts for inscriptions or upgrade masteries perhaps even if all Inscriptions have 2 mastery upgrade branches at this time.

[DoomThing445]

So I found out that you'll stay in the menu for weapon upgrades when you have more than one point to invest, but this doesn't apply to player upgrades for some reason.

[Gourry]

What is the max cap for sweep on melee? It seems to go only to 79%.

Also a bug when playing with the crowbar in Ashes Afterglow: I somehow got 36 million points to it when leveling it up on chain lightning.

Edit: Also another bug (or mentioned already): If you full upgrade the jack hammer and get the base version in the stadium stage; it'll reset the levels once you pick up the upgraded one. Same with getting the golden crowbar.

[AliciaPendragon]

Played around with DRLA and Gun Bonsai, as a way to try and replicate the bug I reported earlier.

If a gun has levels on it in Gun Bonsai and I put a modpack and artifact on it and drop it afterwards, the modpacks and such attached to it dissapears. IDK what causes it exactly but seems to happen when I drop the gun.

[Dan_The_Noob]

Played around with DRLA and Gun Bonsai, as a way to try and replicate the bug I reported earlier.

If a gun has levels on it in Gun Bonsai and I put a modpack and artifact on it and drop it afterwards, the modpacks and such attached to it dissapears. IDK what causes it exactly but seems to happen when I drop the gun.

you need to enable the setting in DRLA that makes weapons inherit the same stuff from all identical guns, or it'll do that.