NoTrim TEXTURES Definition

[Major Cooke]

Pull Request

Adds NoTrim, which disables trimming of sprites with this specified.

Code: Select all

NoTrim <SpriteName>

- OR -

Code: Select all

Sprite <Name>, ...
{
    NoTrim // This alone will suffice.
}

[Graf Zahl]

This is a lot better because it's less invasive. One thing: To allow people doing it without editing TEXTURES, could you add an option to set this flag through ANIMDEFS? That'd allow it with plain sprites in the S_START/S_END namespace.

[Major Cooke]

Done!

[Logan MTM]

Excuse me, what is "Trim Sprite"

[Major Cooke]

Image cropping. Shrinks the image boundaries to the image itself and removes all excess empty space in a square.

[Logan MTM]

Is it the kind of, be able to make Sprite sheets like in Build Engine?

[SanyaWaffles]

No. It has to do with the fact GZDoom crops sprites that have excess transparency.

I wonder where you got the idea it was a build-like engine feature as that was never said.

[Enjay]

My understanding is that it means that the engine will treat sprites like this:



As if they were like this:



(Green colour only there to make it clear where the edges of the sprite graphic is. The sprite is inside the green box.)

[Logan MTM]

Oh, ok. Thank you!
The word "Trim" has no translation to portuguese. So, wondering, the only thing i could imagine was sprites sheets.

[Rachael]

The word "Trim" has no translation to portuguese. So, wondering, the only thing i could imagine was sprites sheets.

What about the word "optimize"? That would probably be really close to the meaning. It's a bit vague but it still hits the target pretty close.

[Major Cooke]

Or "Crop".

[Rachael]

Yeah, that too.

[Logan MTM]

Crop means the same of "cut". In portuguese at least. I think "Trim" is American unique word, like "render".

[Rachael]

Trim is most definitely not American, it comes from English predating America. https://www.etymonline.com/word/trim

Render is also old English. https://www.etymonline.com/word/render

Granted, in the context of computers, their meanings might change - but that doesn't make them American.

[phantombeta]

Trim does have a translation to portuguese. It's "aparar". In this case, the meaning is the same as the non-computer one: "To reduce slightly; to cut; especially, to remove excess." (Because what trimming a sprite does is removing the excess white space that isn't necessary)