[Fixed] [4.0.0] Where's the "Ouch" face?

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

[4.0.0] Where's the "Ouch" face?

Postby A_D_M_E_R_A_L » Sat Apr 13, 2019 8:55 am

The "Ouch" face doesn't work as it should in GZD. Mod used in this screenshot: Pandemonia
https://cdn.discordapp.com/attachments/468487058583715840/566634796009390100/gzdoom_4246.png
User avatar
A_D_M_E_R_A_L
 
Joined: 16 Apr 2017
Discord: A_D_M_E_R_A_L#7602

Re: [4.0.0] Where's the "Ouch" face?

Postby Enjay » Sat Apr 13, 2019 10:40 am

Seems to be. Without mods loaded and simply firing the rocket launcher at the floor in front of me, I was able to reliably get the ouch face in g3.3pre39-g2f45218 (which I happen to have installed for no really good reason) but in 4.0.0 and today's git build, I was not able to get the ouch face despite trying repeatedly. All I ever got was the pain grimace or straight to the dead face.
User avatar
Enjay
Everyone is a moon, and has a dark side which he never shows to anybody. Twain
 
 
 
Joined: 15 Jul 2003
Location: Scotland

Re: [4.0.0] Where's the "Ouch" face?

Postby Player701 » Sun Apr 14, 2019 12:57 am

Confirmed. Bisecting indicates it probably started to happen in this commit... yeah, that one again. Some adjacent commits could not be tested because they crash as soon as the game starts, but they don't seem to contain any changes that may have triggerred this bug. On the other hand, the commit I linked to has this.
User avatar
Player701
 
Joined: 13 May 2009
Location: Russian Federation
Discord: Player701#8214
Operating System: Windows 10/8.1/8 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: [4.0.0] Where's the "Ouch" face?

Postby Graf Zahl » Sun Apr 14, 2019 1:09 am

The ouch face and event handlers do not share any code, though, so it's more likely one of the adjacent commits.
Of course, the event handler code made quite a mess of all code it originally touched, so who knows...
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [4.0.0] Where's the "Ouch" face?

Postby Player701 » Sun Apr 14, 2019 1:25 am

The call to StatusBar->CallTick has been moved to another place within the P_Ticker function since that commit (see second link), and that could be the cause of the bug. I haven't looked deeper into the whole call chain there, though. What I can say for sure is that the value of the mugshot's FaceHealth field and the player's health appear to be always synchronized but the ouch face code expects them to be different at times.
User avatar
Player701
 
Joined: 13 May 2009
Location: Russian Federation
Discord: Player701#8214
Operating System: Windows 10/8.1/8 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: [4.0.0] Where's the "Ouch" face?

Postby _mental_ » Sun Apr 14, 2019 1:28 am

Indeed, the problem is the value of ouch is always false. This is the consequence of the mentioned change, i.e. the move of StatusBar->CallTick() line.
_mental_
 
 
 
Joined: 07 Aug 2011

Re: [4.0.0] Where's the "Ouch" face?

Postby Graf Zahl » Sun Apr 14, 2019 4:21 pm

That piece of code is a textbook example of depending on side effects from other places. The main problem being that the old order of things was wrong - the status bar never got the full state of the frame to be displayed. Unfortunately the mug shot code is an area where my knowledge is limited because I only use the alternative HUD myself which doesn't have it.

So what piece of code needs to be moved where? I'm not really sure.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [4.0.0] Where's the "Ouch" face?

Postby Graf Zahl » Thu Apr 18, 2019 11:34 pm

I changed the setup but I'm afraid this has to be tested by someone else, I'm not sure it's 100% correct.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [4.0.0] Where's the "Ouch" face?

Postby Player701 » Fri Apr 19, 2019 12:43 am

I'm not seeing any new commits, and for me the bug is still present...
User avatar
Player701
 
Joined: 13 May 2009
Location: Russian Federation
Discord: Player701#8214
Operating System: Windows 10/8.1/8 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: [4.0.0] Where's the "Ouch" face?

Postby Graf Zahl » Fri Apr 19, 2019 12:54 am

Damn, the change got lost in a branch switch, it seems.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [4.0.0] Where's the "Ouch" face?

Postby Player701 » Sun Apr 28, 2019 1:22 am

Just wanted to confirm that this bug is still present as of GZDoom 4.1.0.
User avatar
Player701
 
Joined: 13 May 2009
Location: Russian Federation
Discord: Player701#8214
Operating System: Windows 10/8.1/8 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: [4.0.0] Where's the "Ouch" face?

Postby A_D_M_E_R_A_L » Fri May 10, 2019 7:13 pm

Still present in 4.1.1
User avatar
A_D_M_E_R_A_L
 
Joined: 16 Apr 2017
Discord: A_D_M_E_R_A_L#7602

Re: [4.0.0] Where's the "Ouch" face?

Postby Graf Zahl » Sat May 11, 2019 2:22 am

Obviously, condidering nothing has been done about it yet.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [4.0.0] Where's the "Ouch" face?

Postby Player701 » Sat Jun 08, 2019 3:42 am

I'm terribly sorry for the bump, but is there any chance this could be fixed in the next release? I really miss the good old ouch face... :(
User avatar
Player701
 
Joined: 13 May 2009
Location: Russian Federation
Discord: Player701#8214
Operating System: Windows 10/8.1/8 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: [4.0.0] Where's the "Ouch" face?

Postby Rachael » Sat Jun 08, 2019 3:56 am

If you have any ideas how to fix it and you think you can submit a PR within the next few hours, sure. It can be included.
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Graphics Processor: nVidia with Vulkan support

Next

Return to Closed Bugs

Who is online

Users browsing this forum: DotBot and 1 guest