[3.7pre-906] POWERSPEED.NOTRAIL flag [maybe others] missing

Lord Misfit · Post by **Lord Misfit** » Wed Dec 19, 2018 2:55 pm

A friend was trying to test La Tailor Girl w/ newer SVNs of GZDoom [friend is saying it's 3.7pre-733 where it starts], but the POWERSPEED.NOTRAIL flags seems to have gone missing in general from the port. Someone over on the Discord thinks it has to do with the "ItemFlag Scriptifcation" and asked me to report it here.

- screenshot given by my friend of the error occuring on 3.7pre-906

Post by **_mental_** » Thu Dec 20, 2018 3:33 am

It's only NOTRAIL missing because its hard-coded processing were removed in 5e4b366. The question is how should 'that lone flag' be handled now?

Post by **Graf Zahl** » Thu Dec 20, 2018 5:39 am

I already added a flagdef for it, but haven't checked yet why this doesn't work here. All other flagdefs do.

Post by **_mental_** » Thu Dec 20, 2018 5:47 am

The flag cannot be not found because it is set in PowerupGiver instead of PowerSpeed class.

Post by **Graf Zahl** » Thu Dec 20, 2018 5:54 am

Like I said, I haven't looked into it yet. That explains it.

Post by **Graf Zahl** » Thu Dec 20, 2018 6:12 am

OK then. This looks like a modding error that just never got reported but was silently ignored instead. On the item where it is placed it had no effect and should have aborted even in older versions.
The main question now is: Is this an actively developed mod? If so it should be fixed there, because all I can do here is to add some crutches to make something pass the parser that is clearly not correct, biut that's not really beneficial for future robustness.

Like the name implies, this flag belongs to the PowerSpeed flag and won't do anything if set elsewhere, and most certainly won't be transferred to a given PowerSpeed item.

ZDoom