[g3.7pre-754-g888af3d68] Not crash on closing console

[m8f]

Steps to reproduce:
1. Launch GZDoom;
2. Open console by assigned toggleconsole key (grave accent - '`' - in my case).
Note 1: I'm using Dvorak Programming keyboard layout, and actually this key (without Shift) is '$'. For some reason, this key is recognized by GZDoom as grave accent. I wonder if this is related to the problem or not.
3. Close console by using the same key;
4. Crash.

Note 2: if the console is closed by Esc key, no crash happens.

---

Code: Select all

GZDoom g3.7pre-754-g888af3d68 - 2018-12-08 13:53:13 +0300 - SDL version
Compiled on Dec  8 2018

M_LoadDefaults: Load system defaults.
W_Init: Init WADfiles.
 adding /home/allkromm/Documents/src/gzdoom-build/gzdoom.pk3, 635 lumps
 adding /home/allkromm/Documents/src/gzdoom-build/zd_extra.pk3, 132 lumps
 adding /home/allkromm/Programs/Games/wads/doom/DOOM2.WAD, 2919 lumps
I_Init: Setting up machine state.
CPU Vendor ID: AuthenticAMD
  Name: AMD Ryzen 3 2200G with Radeon Vega Graphics 
  Family 23 (23), Model 17, Stepping 0
  Features: SSE2 SSE3 SSSE3 SSE4.1 SSE4.2 HyperThreading
I_InitSound: Initializing OpenAL
Cannot connect to server socket err = No such file or directory
Cannot connect to server request channel
jack server is not running or cannot be started
JackShmReadWritePtr::~JackShmReadWritePtr - Init not done for 4294967295, skipping unlock
JackShmReadWritePtr::~JackShmReadWritePtr - Init not done for 4294967295, skipping unlock
  Opened device HD-Audio Generic Analog Stereo
  EFX enabled
V_Init: allocate screen.
S_Init: Setting up sound.
ST_Init: Init startup screen.
Checking cmd-line parameters...
S_InitData: Load sound definitions.
G_ParseMapInfo: Load map definitions.
Texman.Init: Init texture manager.
ParseTeamInfo: Load team definitions.
LoadActors: Load actor definitions.
script parsing took 275.26 ms
R_Init: Init Doom refresh subsystem.
DecalLibrary: Load decals.
M_Init: Init menus.
P_Init: Init Playloop state.
ParseSBarInfo: Loading custom status bar definition.
D_CheckNetGame: Checking network game status.
player 1 of 1 (1 nodes)
Using video driver x11
GL_VENDOR: NVIDIA Corporation
GL_RENDERER: GeForce GT 710/PCIe/SSE2
GL_VERSION: 4.5.0 NVIDIA 410.73 (Core profile)
GL_SHADING_LANGUAGE_VERSION: 4.50 NVIDIA

Max. texture size: 16384
Max. texture units: 32
Max. varying: 124
Max. combined shader storage blocks: 96
Max. vertex shader storage blocks: 16
Resolution: 1920 x 1080
fluidsynth: warning: Failed to pin the sample data to RAM; swapping is possible.
gzdoom: /home/allkromm/Documents/src/gzdoom/src/v_text.cpp:222: void DFrameBuffer::DrawTextCommon(FFont*, int, double, double, const char*, DrawParms&): Assertion `string[0] != '$'' failed.
[1]    13174 abort      ~/Documents/src/gzdoom-build/gzdoom

No crash log is generated.

Gnome version 3.22.2, Debian GNU/Linux 9 (stretch) 64-bit.

[_mental_]

First of all, this is not a crash. Try to run Release configuration and "mysteriously" it will go away.
Actually, this is indicated clearly in the log: Assertion 'string[0] != '$'' failed.

As for assertion itself, I think it's wrong. It fails when '$' is entered in console as the first character of a command. Same for menus, chat line, etc.
Most likely, the idea was to catch untranslated text lines. It seems to be impossible to detect such thing correctly there.

About Dvorak keyboard, I have no idea. Could be an issue with SDL or our SDL backend.

[Graf Zahl]

Yes, that assert looks like a leftover from working on that code.

[_mental_]

OK, this assertion is removed in 40f77e5.

Unfortunately, I cannot check on Linux at the moment. macOS doesn't have Dvorak Programming keyboard input source.

[m8f]

The fix is confirmed. Thanks!