ZScript: Assertion failure in code generator

[Player701]

The following ZScript triggers an assertion failure in debug builds (at least g3.7pre-130-g94688a370):

Code: Select all

class Test
{
    void DoSomething()
    {
        int x = 0;
        if (x = 0) // typo, should be "=="
        {
            // ...
        }
    }
}

In release builds, execution seems to proceed normally, but who knows what could happen then. The error does not appear if "=" is replaced with "==" (as it should be).

[Graf Zahl]

That code should be legal. An assignment should have a well defined result.

[_mental_]

Generated code is correct, so I just made assertion less strict and added a warning about constant conditional expression in 8597c9e.

[Graf Zahl]

I think it only can get there if the expression has a constant value but isn't a constant itself. Real constants get optimized out in the resolving pass already.

[_mental_]

Yes, I meant code like this

Code: Select all

if (x = 0) console.printf("never");
if (y = 1) console.printf("always");

The idea is to notify modders about potential typos, if warnings are not ignored by them of course.

[Player701]

I never ignore warnings, but I only discovered this error because I decided to try out my scripts on a debug build for an unrelated reason (the event handlers-related pull request, actually). I probably would've found the typo later anyway, though. It will now be a little easier to debug scripts with these extra warnings