SpawnKoraxMissile() lacks a null check for target

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
User avatar
Blue Shadow
Posts: 4904
Joined: Sun Nov 14, 2010 12:59 am
Graphics Processor: ATI/AMD (Modern GZDoom)

SpawnKoraxMissile() lacks a null check for target

Post by Blue Shadow »

Tested with: 3.2.5 (64-bit)

Check this post. It might be very difficult to make it abort with the original Korax class, but if you had a modified one with a code like this for instance:
Spoiler:
It becomes easier, provided the target somehow ceases to exist during the attack sequence (think of a monster that disappears completely after death, like the Lost Soul).

Edit: Here's something to test: https://www.dropbox.com/s/x28gf610dm1ui ... g.pk3?dl=1

Load the file with Hexen and go to MAP40. Enter the first chamber where Korax* is. Summon TestDemon1. It's a friendly chaos serpent which disappears at the end of its death sequence. Let it and Korax fight each other, and if it dies and disappears while Korax is in its attack sequence, you'll get the abort.

* This is a modified Korax, made to make it easier to produce the problem.
_mental_
 
 
Posts: 3774
Joined: Sun Aug 07, 2011 4:32 am

Re: SpawnKoraxMissile() lacks a null check for target

Post by _mental_ »

Is there ready to use sample to reproduce this issue quickly?
User avatar
Blue Shadow
Posts: 4904
Joined: Sun Nov 14, 2010 12:59 am
Graphics Processor: ATI/AMD (Modern GZDoom)

Re: SpawnKoraxMissile() lacks a null check for target

Post by Blue Shadow »

Load the file with Hexen and go to MAP40. Enter the first chamber where Korax* is. Summon TestDemon1. It's a friendly chaos serpent which disappears at the end of its death sequence. Let it and Korax fight each other, and if it dies and disappears while Korax is in its attack sequence, you'll get the abort.
korax_bug.pk3
* This is a modified Korax, made to make it easier to produce the problem.[/s]

Edit: For convenience, I added this to the first post.
_mental_
 
 
Posts: 3774
Joined: Sun Aug 07, 2011 4:32 am

Re: SpawnKoraxMissile() lacks a null check for target

Post by _mental_ »

Fixed in 12eb760. By the way pre-ZScript versions just crashed in this case.

Return to “Closed Bugs”