[Not a bug] Pickup sounds get cut off

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Pickup sounds get cut off

Postby drfrag » Thu Oct 15, 2020 12:10 pm

Is it a bug? Any map, just summon a shotgun and a health bonus, when you pick up the bottle the cock sound gets cut off.
May be since sound refactor? It happens even with only one sound.
User avatar
drfrag
Os voy a romper a pedazos!
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain
Discord: drfrag#3555
Github ID: drfrag666

Re: Pickup sounds get cut off

Postby Graf Zahl » Thu Oct 15, 2020 12:46 pm

Yes, pickup sounds cut each other off. They all play on the same actor channel and this has always been the case.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Pickup sounds get cut off

Postby drfrag » Thu Oct 15, 2020 1:46 pm

It sounds bad IMO, is there a possible solution for weapon pickups? For other items it doesn't matter.
User avatar
drfrag
Os voy a romper a pedazos!
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain
Discord: drfrag#3555
Github ID: drfrag666

Re: Pickup sounds get cut off

Postby Graf Zahl » Thu Oct 15, 2020 2:15 pm

No, this is how it always was and changing it will only give food for the "ZDoom is not Doom" crowd. Special handling for the weapon is not really doable because the engine makes no distinction here.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Pickup sounds get cut off

Postby Marisa Kirisame » Thu Oct 15, 2020 3:45 pm

For mods at least it's pretty easy to change this since PlayPickupSound is a virtual. And if you need to mass-apply it to items you can just have it in a mixin. I'm going to have to side with Graf on this one, it's better not to touch the vanilla behaviour.
User avatar
Marisa Kirisame
ZScript Crimester
 
 
 
Joined: 08 Feb 2008
Location: Vigo, Galicia
Discord: 霧雨魔理沙#1666
Twitch ID: magusmarisa
Github ID: OrdinaryMagician
Operating System: Other Linux 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Pickup sounds get cut off

Postby SanyaWaffles » Thu Oct 15, 2020 5:32 pm

Siding with Graf and the Ordinary Magician Who Is Going To Singlehandedly Code an AI That Will Take Over The Universe in ZScript Marisa Kirisame on this one.
User avatar
SanyaWaffles
Wouldn't be an epic gamer if I didn't commit a few war crimes.
 
Joined: 25 Apr 2013
Location: Eastern Ohio
Discord: SanyaWaffles#5095
Twitch ID: sanyawaffles
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Pickup sounds get cut off

Postby Chris » Thu Oct 15, 2020 5:57 pm

Marisa Kirisame wrote:For mods at least it's pretty easy to change this since PlayPickupSound is a virtual. And if you need to mass-apply it to items you can just have it in a mixin.

Just be careful that there are mods that stack items on or near the same spot, which can cause the pickup sound to play at double, triple, etc, volume if they all play at the same time without cutting each other off.
User avatar
Chris
 
Joined: 17 Jul 2003

Re: Pickup sounds get cut off

Postby Player701 » Fri Oct 16, 2020 12:20 am

Marisa Kirisame wrote:For mods at least it's pretty easy to change this since PlayPickupSound is a virtual. And if you need to mass-apply it to items you can just have it in a mixin. I'm going to have to side with Graf on this one, it's better not to touch the vanilla behaviour.

Note that it's not trivial to implement this functionality in user code for some items - like keys, for example, since you'd also have to redefine LOCKDEFS, and it's not a robust solution if a PWAD provides a custom LOCKDEFS lump. I've suggested to add a virtual method to handle pickup sounds on the owner's side, but so far this hasn't gained any traction.
User avatar
Player701
 
Joined: 13 May 2009
Location: Russia
Discord: Player701#8214
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Pickup sounds get cut off

Postby Marisa Kirisame » Fri Oct 16, 2020 12:39 am

There's no need to use new LOCKDEFS definitions if you just make the changed keys have the same species as the originals.
User avatar
Marisa Kirisame
ZScript Crimester
 
 
 
Joined: 08 Feb 2008
Location: Vigo, Galicia
Discord: 霧雨魔理沙#1666
Twitch ID: magusmarisa
Github ID: OrdinaryMagician
Operating System: Other Linux 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Pickup sounds get cut off

Postby Player701 » Fri Oct 16, 2020 12:43 am

Thanks for pointing it out! Not sure why I overlooked it. However, what if a map adds a new type of key? (green keycard, for example)

The point of my suggestion was to avoid replacing tons of items just to add the new pickup sound code. At the very least, it's blatantly inefficient.
User avatar
Player701
 
Joined: 13 May 2009
Location: Russia
Discord: Player701#8214
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Pickup sounds get cut off

Postby drfrag » Fri Oct 16, 2020 2:38 am

So there are sides now? :P
Graf says it can't be done, what sounds shitty to me is when a weapon sound is cut off with a regular item pickup sound and only that case. I even thought it was a bug.
User avatar
drfrag
Os voy a romper a pedazos!
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain
Discord: drfrag#3555
Github ID: drfrag666

Re: Pickup sounds get cut off

Postby SanyaWaffles » Fri Oct 16, 2020 3:46 am

You can always just load a mod if it sounds shitty to you. That's what mods are for. Do note what Chris has said though, don't want to rupture your speakers.
User avatar
SanyaWaffles
Wouldn't be an epic gamer if I didn't commit a few war crimes.
 
Joined: 25 Apr 2013
Location: Eastern Ohio
Discord: SanyaWaffles#5095
Twitch ID: sanyawaffles
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Pickup sounds get cut off

Postby Graf Zahl » Fri Oct 16, 2020 5:24 am

drfrag wrote:So there are sides now? :P
Graf says it can't be done, what sounds shitty to me is when a weapon sound is cut off with a regular item pickup sound and only that case. I even thought it was a bug.



This is ultimately irrelevant. This is how the game was designed and what most mods expect. Change it and the negative community response will be inevitable.
If you do not like how the game behaves, load a mod.

Otherwise we just get repeats of the explosion code not being compatible with how it was initially designed and other such un-features that were active by default instead of opt-in.
Changing core behavior is only an option if the alternative would render the feature unusable - a good example here is that projectile velocity is now being scaled along the 3-dimensional movement vector, because doing it in 2D would make high pitches useless.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 0 guests