Menu.OptionColor has been removed

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
User avatar
Player701
 
 
Posts: 1647
Joined: Wed May 13, 2009 3:15 am
Graphics Processor: nVidia with Vulkan support

Menu.OptionColor has been removed

Post by Player701 »

The static method Menu.OptionColor was available in 4.0.0 but was removed in this commit. This method is used in RRWM 1.03 when drawing arrows beside scrollable text in help screens, so that their color is consistent with that of the arrows drawn by GZDoom itself. The logic has changed and so I've fixed it too in the current master, but I'd really like it if the current version didn't break in the next release. However, I'll probably make a new release as soon as possible, so this can be closed if there are no other mods using this feature - and since it only appeared in 4.0.0, there probably aren't.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49096
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Menu.OptionColor has been removed

Post by Graf Zahl »

This was only a placeholder until the time I could fix the underlying problem - which just happened this morning.
It is now completely redundant and would always return the value that got passed in.
User avatar
Player701
 
 
Posts: 1647
Joined: Wed May 13, 2009 3:15 am
Graphics Processor: nVidia with Vulkan support

Re: Menu.OptionColor has been removed

Post by Player701 »

You leave placeholders in release versions, but my mod breaks as a result. Well, not sure what to say here... I am well aware that features available in development builds are not to be relied upon, and I think there is even a warning about it somewhere on these forums. But there is no such warning about release versions... :?
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49096
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Menu.OptionColor has been removed

Post by Graf Zahl »

The biggest problem I have is that no feature can mature before people start using it. The entire localization thing and associated features aren't even finished yet, if I leave everything in to keep your mod working, the feature will remain broken.

I am far more concerned about not breaking old stuff that cannot be fixed anymore than some WIP mod. Sorry.
User avatar
Player701
 
 
Posts: 1647
Joined: Wed May 13, 2009 3:15 am
Graphics Processor: nVidia with Vulkan support

Re: Menu.OptionColor has been removed

Post by Player701 »

OK, I guess this is fair game, but I wish there were a way to know if a method could be removed entirely in the next release. In this case, there was a comment there, but it only made me think that the inner logic of the method would be changed, not that the entire method would be gone.

Return to “Closed Bugs [GZDoom]”