ZDoom master cannot be built on Linux

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
User avatar
Marisa the Magician
 
 
Posts: 3816
Joined: Fri Feb 08, 2008 9:15 am
Discord: Marisa the Magician#1666
Twitch ID: MarisaDOOM
Github ID: OrdinaryMagician
Preferred Pronouns: She/Her
Graphics Processor: nVidia with Vulkan support
Location: Vigo, Galicia

ZDoom master cannot be built on Linux

Post by Marisa the Magician »

Build error logged here:

Code: Select all

/home/marisa/.cache/pacaur/zdoom-git/src/zdoom/src/sound/oalsound.cpp: In member function ‘virtual SoundStream* OpenALSoundRenderer::CreateStream(SoundStreamCallback, int, int, int, void*)’:
/home/marisa/.cache/pacaur/zdoom-git/src/zdoom/src/sound/oalsound.cpp:1298:41: error: ‘mem_fn’ is not a member of ‘std’
         StreamThread = std::thread(std::mem_fn(&OpenALSoundRenderer::BackgroundProc), this);
                                         ^~~~~~
/home/marisa/.cache/pacaur/zdoom-git/src/zdoom/src/sound/oalsound.cpp:1298:41: note: suggested alternative: ‘mem_fun’
         StreamThread = std::thread(std::mem_fn(&OpenALSoundRenderer::BackgroundProc), this);
                                         ^~~~~~
                                         mem_fun
/home/marisa/.cache/pacaur/zdoom-git/src/zdoom/src/sound/oalsound.cpp:1297:5: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
     if(StreamThread.get_id() == std::thread::id())
     ^~
/home/marisa/.cache/pacaur/zdoom-git/src/zdoom/src/sound/oalsound.cpp:1299:2: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
  OpenALSoundStream *stream = new OpenALSoundStream(this);
  ^~~~~~~~~~~~~~~~~
/home/marisa/.cache/pacaur/zdoom-git/src/zdoom/src/sound/oalsound.cpp: In member function ‘virtual SoundStream* OpenALSoundRenderer::OpenStream(FileReader*, int)’:
/home/marisa/.cache/pacaur/zdoom-git/src/zdoom/src/sound/oalsound.cpp:1311:41: error: ‘mem_fn’ is not a member of ‘std’
         StreamThread = std::thread(std::mem_fn(&OpenALSoundRenderer::BackgroundProc), this);
                                         ^~~~~~
/home/marisa/.cache/pacaur/zdoom-git/src/zdoom/src/sound/oalsound.cpp:1311:41: note: suggested alternative: ‘mem_fun’
         StreamThread = std::thread(std::mem_fn(&OpenALSoundRenderer::BackgroundProc), this);
                                         ^~~~~~
                                         mem_fun
/home/marisa/.cache/pacaur/zdoom-git/src/zdoom/src/sound/oalsound.cpp:1310:5: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
     if(StreamThread.get_id() == std::thread::id())
     ^~
/home/marisa/.cache/pacaur/zdoom-git/src/zdoom/src/sound/oalsound.cpp:1312:2: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
  OpenALSoundStream *stream = new OpenALSoundStream(this);
  ^~~~~~~~~~~~~~~~~
Apparently mem_fn was renamed to mem_fun in C++14.
_mental_
 
 
Posts: 3774
Joined: Sun Aug 07, 2011 4:32 am

Re: ZDoom master cannot be built on Linux

Post by _mental_ »

What's compiler/version? But honestly, what's the point of bug report for discontinued project?
User avatar
drfrag
Vintage GZDoom Developer
Posts: 3110
Joined: Fri Apr 23, 2004 3:51 am
Discord: drfrag#3555
Github ID: drfrag666
Location: Spain

Re: ZDoom master cannot be built on Linux

Post by drfrag »

Besides i think it's right the opposite and mem_fun was discontinued in C++11. Missing include?
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 48040
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: ZDoom master cannot be built on Linux

Post by Graf Zahl »

_mental_ wrote:What's the point of bug report for discontinued project?
Precisely that. There's nobody left who is maintaining it (otherwise it would have seen new commits over the last year) so what do you expect to happen? Magic intervention?
_mental_
 
 
Posts: 3774
Joined: Sun Aug 07, 2011 4:32 am

Re: ZDoom master cannot be built on Linux

Post by _mental_ »

This was fixed later and can be cherry picked as is (just in case of desperate need to check something with the last ZDoom commit).
User avatar
drfrag
Vintage GZDoom Developer
Posts: 3110
Joined: Fri Apr 23, 2004 3:51 am
Discord: drfrag#3555
Github ID: drfrag666
Location: Spain

Re: ZDoom master cannot be built on Linux

Post by drfrag »

@_mental_: Not related but there's a missing <algorithm> header in p_acs.h for MinGW (GZDoom). Since "Uniform way to guard ACS stack and variables".
_mental_
 
 
Posts: 3774
Joined: Sun Aug 07, 2011 4:32 am

Re: ZDoom master cannot be built on Linux

Post by _mental_ »

<algorithm> is included in precompiled/prefix header.
User avatar
drfrag
Vintage GZDoom Developer
Posts: 3110
Joined: Fri Apr 23, 2004 3:51 am
Discord: drfrag#3555
Github ID: drfrag666
Location: Spain

Re: ZDoom master cannot be built on Linux

Post by drfrag »

I see, fine then.
Edit: i forgot about that one, i had to add the header in ZDoom32. But compiles with OpenAL support without that <functional> header under MinGW.

Return to “Closed Bugs”