ZDoom master cannot be built on Linux

[Marisa the Magician]

Build error logged here:

Code: Select all

/home/marisa/.cache/pacaur/zdoom-git/src/zdoom/src/sound/oalsound.cpp: In member function ‘virtual SoundStream* OpenALSoundRenderer::CreateStream(SoundStreamCallback, int, int, int, void*)’:
/home/marisa/.cache/pacaur/zdoom-git/src/zdoom/src/sound/oalsound.cpp:1298:41: error: ‘mem_fn’ is not a member of ‘std’
         StreamThread = std::thread(std::mem_fn(&OpenALSoundRenderer::BackgroundProc), this);
                                         ^~~~~~
/home/marisa/.cache/pacaur/zdoom-git/src/zdoom/src/sound/oalsound.cpp:1298:41: note: suggested alternative: ‘mem_fun’
         StreamThread = std::thread(std::mem_fn(&OpenALSoundRenderer::BackgroundProc), this);
                                         ^~~~~~
                                         mem_fun
/home/marisa/.cache/pacaur/zdoom-git/src/zdoom/src/sound/oalsound.cpp:1297:5: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
     if(StreamThread.get_id() == std::thread::id())
     ^~
/home/marisa/.cache/pacaur/zdoom-git/src/zdoom/src/sound/oalsound.cpp:1299:2: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
  OpenALSoundStream *stream = new OpenALSoundStream(this);
  ^~~~~~~~~~~~~~~~~
/home/marisa/.cache/pacaur/zdoom-git/src/zdoom/src/sound/oalsound.cpp: In member function ‘virtual SoundStream* OpenALSoundRenderer::OpenStream(FileReader*, int)’:
/home/marisa/.cache/pacaur/zdoom-git/src/zdoom/src/sound/oalsound.cpp:1311:41: error: ‘mem_fn’ is not a member of ‘std’
         StreamThread = std::thread(std::mem_fn(&OpenALSoundRenderer::BackgroundProc), this);
                                         ^~~~~~
/home/marisa/.cache/pacaur/zdoom-git/src/zdoom/src/sound/oalsound.cpp:1311:41: note: suggested alternative: ‘mem_fun’
         StreamThread = std::thread(std::mem_fn(&OpenALSoundRenderer::BackgroundProc), this);
                                         ^~~~~~
                                         mem_fun
/home/marisa/.cache/pacaur/zdoom-git/src/zdoom/src/sound/oalsound.cpp:1310:5: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
     if(StreamThread.get_id() == std::thread::id())
     ^~
/home/marisa/.cache/pacaur/zdoom-git/src/zdoom/src/sound/oalsound.cpp:1312:2: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
  OpenALSoundStream *stream = new OpenALSoundStream(this);
  ^~~~~~~~~~~~~~~~~

Apparently mem_fn was renamed to mem_fun in C++14.

[_mental_]

What's compiler/version? But honestly, what's the point of bug report for discontinued project?

[drfrag]

Besides i think it's right the opposite and mem_fun was discontinued in C++11. Missing include?

[Graf Zahl]

What's the point of bug report for discontinued project?

Precisely that. There's nobody left who is maintaining it (otherwise it would have seen new commits over the last year) so what do you expect to happen? Magic intervention?

[_mental_]

This was fixed later and can be cherry picked as is (just in case of desperate need to check something with the last ZDoom commit).

[drfrag]

@_mental_: Not related but there's a missing <algorithm> header in p_acs.h for MinGW (GZDoom). Since "Uniform way to guard ACS stack and variables".

[_mental_]

<algorithm> is included in precompiled/prefix header.

[drfrag]

I see, fine then.
Edit: i forgot about that one, i had to add the header in ZDoom32. But compiles with OpenAL support without that <functional> header under MinGW.