[Fixed] (g3.0.1+) Software renderer crashes with Hideous destructor

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

(g3.0.1+) Software renderer crashes with Hideous destructor

Postby RightInfinity » Sat May 20, 2017 9:03 pm

I'm not certain if this is a wad specific thing, but it's the only wad that seemed to do this reliably.

I've been playing few older maps with HD and wanted to swap to the older software render to preserve the visual trickery some employ that isn't present in the "Experimental poly render" or OpenGL modes, but every time I fire a weapon, for the first time in any given map, It causes gzdoom to crash.

If I enable the experimental poly render, Fire a few rounds, then turn it off, I'm able to play normally, though I have to redo this trick for each new map, and it isn't 100% reliable either
if true colour is enabled, GZdoom will crash gracefully to the crash reporter, if it's off, it'll hard lock and require taskmanager.
Changing the "Rendering canvas" has no apparent effect on the crash, and neither does anything I tested in the display options

I've tested this on the latest dev build (g3.0pre-211-gfc86392) and the standard g3.0.1 release under Win 7 SP1 x64.
Wad was downloaded from here https://github.com/MatthewTheGlutton/HideousDestructor/tree/9cf755595b1547e568a6ec1c94a95722a9161019

I've stuck on the crash report zip on here for what it's worth.
You do not have the required permissions to view the files attached to this post.
RightInfinity
 
Joined: 16 May 2017

Re: (g3.0.1+) Software renderer crashes with Hideous destruc

Postby Matt » Sun May 21, 2017 5:19 pm

Spoiler: trying to figure this out


It seems to be caused by wallsprite itself - if I comment out the random wallspriting in WallChunk and add "+wallsprite" to the default I get the crash too.

In fact I can replicate the crash with this and nothing else:
Code: Select allExpand view
class bluh:techlamp{
   default{
      +wallsprite
   }
}
User avatar
Matt
Putting the XD into *xdeath since 2007
 
Joined: 04 Jan 2004
Location: Gotham City SAR, Wyld-Lands of the Lotus People, Dominionist PetroConfederacy of Saudi Canadia

Re: (g3.0.1+) Software renderer crashes with Hideous destruc

Postby dpJudas » Mon May 22, 2017 11:54 am

Does ZDoom even officially support wallsprites? I've seen some (incomplete?) code dealing with them, but I also think the wiki said they are GL renderer only.
dpJudas
 
 
 
Joined: 28 May 2016

Re: (g3.0.1+) Software renderer crashes with Hideous destruc

Postby Rachael » Mon May 22, 2017 11:57 am

Officially it does not. The only "wallsprites" there currently are (as far as I know) are the decals that appear on the walls.
User avatar
Rachael
Admin
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Debian-like Linux (Debian, Ubuntu, Mint, etc) 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: (g3.0.1+) Software renderer crashes with Hideous destruc

Postby Matt » Mon May 22, 2017 12:04 pm

Are there any plans to make the software renderer support wallsprites in the future?

If not, is there any way to tell if any given player might be using software and set bWALLSPRITE accordingly?
User avatar
Matt
Putting the XD into *xdeath since 2007
 
Joined: 04 Jan 2004
Location: Gotham City SAR, Wyld-Lands of the Lotus People, Dominionist PetroConfederacy of Saudi Canadia

Re: (g3.0.1+) Software renderer crashes with Hideous destruc

Postby Rachael » Mon May 22, 2017 12:23 pm

Your mod should not be meddling with setting +WALLSPRITE based on renderer, if you are only doing so to fix a crash.

The crash must be fixed on the engine side.
User avatar
Rachael
Admin
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Debian-like Linux (Debian, Ubuntu, Mint, etc) 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: (g3.0.1+) Software renderer crashes with Hideous destruc

Postby dpJudas » Mon May 22, 2017 6:47 pm

If wallsprites aren't supported by the software renderer, then what should be done about the incomplete implementation (r_wallsprite.cpp)? Remove it? If it only supports a subset, what subset is that?

The code there has nothing to do with decals. They are implemented in a completely different way. What is the difference between a wallsprite and a decal anyway?
dpJudas
 
 
 
Joined: 28 May 2016

Re: (g3.0.1+) Software renderer crashes with Hideous destruc

Postby Graf Zahl » Tue May 23, 2017 1:38 am

Fixed.

There were two rather trivial errors in the code. Was this ever tested?
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: (g3.0.1+) Software renderer crashes with Hideous destruc

Postby dpJudas » Tue May 23, 2017 1:53 am

Probably not - hence why I was asking about the general status of that particular feature.
dpJudas
 
 
 
Joined: 28 May 2016

Re: (g3.0.1+) Software renderer crashes with Hideous destruc

Postby Rachael » Tue May 23, 2017 4:23 am

dpJudas wrote:What is the difference between a wallsprite and a decal anyway?

As I understand it - and someone can feel free to jump in and correct me if I am wrong - it's like BUILD when you were able to make sprites become an upwards plane in 3D space - it was used to great extent to add wall decor, signage, and put explodable cracks in the wall, in addition to being a tool that was used to create quick fake 3D floors (when combined with BUILD's own flat sprites).
User avatar
Rachael
Admin
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Debian-like Linux (Debian, Ubuntu, Mint, etc) 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: (g3.0.1+) Software renderer crashes with Hideous destruc

Postby dpJudas » Tue May 23, 2017 10:35 am

Okay - thanks. So it is just a sprite that doesn't rotate towards the camera (doesn't billboard).
dpJudas
 
 
 
Joined: 28 May 2016

Re: (g3.0.1+) Software renderer crashes with Hideous destruc

Postby Rachael » Tue May 23, 2017 11:18 am

Exactly.
User avatar
Rachael
Admin
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Debian-like Linux (Debian, Ubuntu, Mint, etc) 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 1 guest