NoTrim TEXTURES Definition

Moderator: GZDoom Developers

User avatar
Major Cooke
Posts: 8094
Joined: Sun Jan 28, 2007 3:55 pm

NoTrim TEXTURES Definition

Post by Major Cooke »

Pull Request

Adds NoTrim, which disables trimming of sprites with this specified.

Code: Select all

NoTrim <SpriteName>
- OR -

Code: Select all

Sprite <Name>, ...
{
    NoTrim // This alone will suffice.
}
You do not have the required permissions to view the files attached to this post.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 48370
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: NoTrim TEXTURES Definition

Post by Graf Zahl »

This is a lot better because it's less invasive. One thing: To allow people doing it without editing TEXTURES, could you add an option to set this flag through ANIMDEFS? That'd allow it with plain sprites in the S_START/S_END namespace.
User avatar
Major Cooke
Posts: 8094
Joined: Sun Jan 28, 2007 3:55 pm

Re: NoTrim TEXTURES Definition

Post by Major Cooke »

Done!
User avatar
Logan MTM
Posts: 677
Joined: Mon Jan 16, 2006 8:53 pm
Location: Rio de Janeiro - Brazil

Re: NoTrim TEXTURES Definition

Post by Logan MTM »

Excuse me, what is "Trim Sprite" :?:
User avatar
Major Cooke
Posts: 8094
Joined: Sun Jan 28, 2007 3:55 pm

Re: NoTrim TEXTURES Definition

Post by Major Cooke »

Image cropping. Shrinks the image boundaries to the image itself and removes all excess empty space in a square.
User avatar
Logan MTM
Posts: 677
Joined: Mon Jan 16, 2006 8:53 pm
Location: Rio de Janeiro - Brazil

Re: NoTrim TEXTURES Definition

Post by Logan MTM »

Is it the kind of, be able to make Sprite sheets like in Build Engine?
User avatar
SanyaWaffles
Posts: 764
Joined: Thu Apr 25, 2013 12:21 pm
Graphics Processor: nVidia with Vulkan support
Location: Disappointment Island

Re: NoTrim TEXTURES Definition

Post by SanyaWaffles »

No. It has to do with the fact GZDoom crops sprites that have excess transparency.

I wonder where you got the idea it was a build-like engine feature as that was never said.
User avatar
Enjay
 
 
Posts: 26430
Joined: Tue Jul 15, 2003 4:58 pm
Location: Scotland

Re: NoTrim TEXTURES Definition

Post by Enjay »

My understanding is that it means that the engine will treat sprites like this:

Image

As if they were like this:

Image

(Green colour only there to make it clear where the edges of the sprite graphic is. The sprite is inside the green box.)
User avatar
Logan MTM
Posts: 677
Joined: Mon Jan 16, 2006 8:53 pm
Location: Rio de Janeiro - Brazil

Re: NoTrim TEXTURES Definition

Post by Logan MTM »

Oh, ok. Thank you!
The word "Trim" has no translation to portuguese. So, wondering, the only thing i could imagine was sprites sheets.
User avatar
Rachael
Admin
Posts: 13107
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her

Re: NoTrim TEXTURES Definition

Post by Rachael »

Logan MTM wrote: The word "Trim" has no translation to portuguese. So, wondering, the only thing i could imagine was sprites sheets.
What about the word "optimize"? That would probably be really close to the meaning. It's a bit vague but it still hits the target pretty close.
User avatar
Major Cooke
Posts: 8094
Joined: Sun Jan 28, 2007 3:55 pm

Re: NoTrim TEXTURES Definition

Post by Major Cooke »

Or "Crop".
User avatar
Rachael
Admin
Posts: 13107
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her

Re: NoTrim TEXTURES Definition

Post by Rachael »

Yeah, that too.
User avatar
Logan MTM
Posts: 677
Joined: Mon Jan 16, 2006 8:53 pm
Location: Rio de Janeiro - Brazil

Re: NoTrim TEXTURES Definition

Post by Logan MTM »

Crop means the same of "cut". In portuguese at least. I think "Trim" is American unique word, like "render".
User avatar
Rachael
Admin
Posts: 13107
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her

Re: NoTrim TEXTURES Definition

Post by Rachael »

Trim is most definitely not American, it comes from English predating America. https://www.etymonline.com/word/trim

Render is also old English. https://www.etymonline.com/word/render

Granted, in the context of computers, their meanings might change - but that doesn't make them American.
User avatar
phantombeta
Posts: 2011
Joined: Thu May 02, 2013 1:27 am
Graphics Processor: nVidia with Vulkan support

Re: NoTrim TEXTURES Definition

Post by phantombeta »

Trim does have a translation to portuguese. It's "aparar". In this case, the meaning is the same as the non-computer one: "To reduce slightly; to cut; especially, to remove excess." (Because what trimming a sprite does is removing the excess white space that isn't necessary)

Return to “Closed Feature Suggestions [GZDoom]”