[Added] NoTrim TEXTURES Definition

Moderator: GZDoom Developers

NoTrim TEXTURES Definition

Postby Major Cooke » Tue Dec 14, 2021 2:41 am

Pull Request

Adds NoTrim, which disables trimming of sprites with this specified.

Code: Select allExpand view
NoTrim <SpriteName>

- OR -
Code: Select allExpand view
Sprite <Name>, ...
{
    NoTrim // This alone will suffice.
}
You do not have the required permissions to view the files attached to this post.
User avatar
Major Cooke
QZDoom Maintenance Team
 
Joined: 28 Jan 2007

Re: NoTrim TEXTURES Definition

Postby Graf Zahl » Tue Dec 14, 2021 4:22 am

This is a lot better because it's less invasive. One thing: To allow people doing it without editing TEXTURES, could you add an option to set this flag through ANIMDEFS? That'd allow it with plain sprites in the S_START/S_END namespace.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: NoTrim TEXTURES Definition

Postby Major Cooke » Tue Dec 14, 2021 7:42 am

Done!
User avatar
Major Cooke
QZDoom Maintenance Team
 
Joined: 28 Jan 2007

Re: NoTrim TEXTURES Definition

Postby Logan MTM » Tue Dec 14, 2021 8:02 am

Excuse me, what is "Trim Sprite" :?:
User avatar
Logan MTM
I can see you...
 
Joined: 16 Jan 2006
Location: Rio de Janeiro - Brazil

Re: NoTrim TEXTURES Definition

Postby Major Cooke » Tue Dec 14, 2021 8:21 am

Image cropping. Shrinks the image boundaries to the image itself and removes all excess empty space in a square.
User avatar
Major Cooke
QZDoom Maintenance Team
 
Joined: 28 Jan 2007

Re: NoTrim TEXTURES Definition

Postby Logan MTM » Tue Dec 14, 2021 9:46 am

Is it the kind of, be able to make Sprite sheets like in Build Engine?
User avatar
Logan MTM
I can see you...
 
Joined: 16 Jan 2006
Location: Rio de Janeiro - Brazil

Re: NoTrim TEXTURES Definition

Postby SanyaWaffles » Tue Dec 14, 2021 9:56 am

No. It has to do with the fact GZDoom crops sprites that have excess transparency.

I wonder where you got the idea it was a build-like engine feature as that was never said.
User avatar
SanyaWaffles
Certified Heretic and Grill Champion
 
Joined: 25 Apr 2013
Location: Disappointment Island
Discord: SanyaWaffles#0950
Twitch ID: sanyawaffles
Operating System: Windows 11
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: NoTrim TEXTURES Definition

Postby Enjay » Tue Dec 14, 2021 11:34 am

My understanding is that it means that the engine will treat sprites like this:

Image

As if they were like this:

Image

(Green colour only there to make it clear where the edges of the sprite graphic is. The sprite is inside the green box.)
User avatar
Enjay
Everyone is a moon, and has a dark side which he never shows to anybody. Twain
 
 
 
Joined: 15 Jul 2003
Location: Scotland

Re: NoTrim TEXTURES Definition

Postby Logan MTM » Tue Dec 14, 2021 3:23 pm

Oh, ok. Thank you!
The word "Trim" has no translation to portuguese. So, wondering, the only thing i could imagine was sprites sheets.
User avatar
Logan MTM
I can see you...
 
Joined: 16 Jan 2006
Location: Rio de Janeiro - Brazil

Re: NoTrim TEXTURES Definition

Postby Rachael » Tue Dec 14, 2021 8:27 pm

Logan MTM wrote:The word "Trim" has no translation to portuguese. So, wondering, the only thing i could imagine was sprites sheets.

What about the word "optimize"? That would probably be really close to the meaning. It's a bit vague but it still hits the target pretty close.
User avatar
Rachael
^ walking stack of unfinished projects ^
Admin
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle

Re: NoTrim TEXTURES Definition

Postby Major Cooke » Wed Dec 15, 2021 1:23 am

Or "Crop".
User avatar
Major Cooke
QZDoom Maintenance Team
 
Joined: 28 Jan 2007

Re: NoTrim TEXTURES Definition

Postby Rachael » Wed Dec 15, 2021 7:20 am

Yeah, that too.
User avatar
Rachael
^ walking stack of unfinished projects ^
Admin
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle

Re: NoTrim TEXTURES Definition

Postby Logan MTM » Wed Dec 15, 2021 8:20 am

Crop means the same of "cut". In portuguese at least. I think "Trim" is American unique word, like "render".
User avatar
Logan MTM
I can see you...
 
Joined: 16 Jan 2006
Location: Rio de Janeiro - Brazil

Re: NoTrim TEXTURES Definition

Postby Rachael » Wed Dec 15, 2021 8:58 am

Trim is most definitely not American, it comes from English predating America. https://www.etymonline.com/word/trim

Render is also old English. https://www.etymonline.com/word/render

Granted, in the context of computers, their meanings might change - but that doesn't make them American.
User avatar
Rachael
^ walking stack of unfinished projects ^
Admin
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle

Re: NoTrim TEXTURES Definition

Postby phantombeta » Wed Dec 15, 2021 2:23 pm

Trim does have a translation to portuguese. It's "aparar". In this case, the meaning is the same as the non-computer one: "To reduce slightly; to cut; especially, to remove excess." (Because what trimming a sprite does is removing the excess white space that isn't necessary)
User avatar
phantombeta
Tired of being treated like trash by control freaks
 
Joined: 02 May 2013

Next

Return to Closed Feature Suggestions

Who is online

Users browsing this forum: No registered users and 2 guests