ZDoom

A question about what the code makes the player float bob himself (not weapon bob or camera bob) forcibly while flying.
Even adding the flag "-FLOATBOB" doesn't work. It seems doesn't affect during noclip2 mode, he's not bobbing.

AFAIA it's hard coded. So I wondered which file handles it, but nothing came up even when I searched the source code.
Does anyone know about it?

[edit] According to this thread, there is no meaning to add "-FLOADBOB" to stop it: viewtopic.php?f=3&t=32719

Okay, I found it out by myself.

This causes the player float bobbing while flying.
https://github.com/coelckers/gzdoom/blo ... .cpp#L2502

Spoiler:

---

Code: Select all • Expand view

//
// adjust height
//
   if ((mo->flags & MF_FLOAT) && !(mo->flags2 & MF2_DORMANT) && mo->target)
   {   // float down towards target if too close
      if (!(mo->flags & (MF_SKULLFLY | MF_INFLOAT)))
      {
         dist = mo->Distance2D (mo->target);
         delta = (mo->target->Center()) - mo->Z();
         if (delta < 0 && dist < -(delta*3))
            mo->AddZ(-mo->FloatSpeed);
         else if (delta > 0 && dist < (delta*3))
            mo->AddZ(mo->FloatSpeed);
      }
   }
   if (mo->player && (mo->flags & MF_NOGRAVITY) && (mo->Z() > mo->floorz)) // <--------------THIS LINE
   {
      if (!mo->IsNoClip2())
      {
         mo->AddZ(DAngle(360 / 80.f * mo->Level->maptime).Sin() / 8);
      }

      if (!(mo->flags8 & MF8_NOFRICTION))
      {
         mo->Vel.Z *= FRICTION_FLY;
      }
   }

I've deleted (mo->flags & MF_NOGRAVITY) from line 2502 and the player doesn't bob anymore. But the camera was still trembling so I changed player.bob = 0.5 to player.bob = 0 in Player.zs.
(Actually you should make a new PlayerPawn class inherited from the original PlayerPawn and then override it.)

Spoiler:

---

Code: Select all • Expand view

   virtual void CalcHeight()
   {
      let player = self.player;
      double angle;
      double bob;
      bool still = false;

      // Regular movement bobbing
      // (needs to be calculated for gun swing even if not on ground)

      // killough 10/98: Make bobbing depend only on player-applied motion.
      //
      // Note: don't reduce bobbing here if on ice: if you reduce bobbing here,
      // it causes bobbing jerkiness when the player moves from ice to non-ice,
      // and vice-versa.

      if (player.cheats & CF_NOCLIP2)
      {
         player.bob = 0;
      }
      else if (bNoGravity && !player.onground)
      {
         player.bob = 0.5; //<-------- THIS
      }


Finally, the bobbing is stopped!

Nobody has talked about stopping this even modifying the source code so far, so I hope this will help someone who wants to do.

Sounds useful. And reasonable. It shall be great when we will be makin' the asteroid levels Thank you for your efforts!

You bet