Weapons don't darken enough in dark places

Discuss anything ZDoom-related that doesn't fall into one of the other categories.

Weapons don't darken enough in dark places

Postby Carrascado » Sat Oct 29, 2016 10:23 am

Hello, me (and user Dynamo, thx) have realised that, depending on the sector light mode you choose, weapons don't seem to darken up in pitch black sectors (brightness 0 or at least very low). More precisely, the only sector light mode that darkens enough is software sector light mode. The others don't (they darken but very little). This seems to happen in modern versions of gzdoom (like 2.2.0).

This happens in doom2.wad (standard mode):
Image

This happens in the same place (dark mode):
Spoiler:


You can't see almost any difference (or any difference at all), which is weird.

Dynamo made these pics:

This is a sector with brightness 0 in an OLD version of gzdoom ->
Spoiler:

This is a sector with brightness 0 in a modern version ->
Spoiler:


The weapon got darker but very little, which is weird because that is a place with brightness 0.

The only way to darken enough the weapon in gzdoom 2.2.0 is using sector light mode in "software".

Brightness 0 in gzdoom 2.2.0 64 bits (dark mode, but the same happens with any other mode that is not software):
Spoiler:


Brightness 0 in gzdoom 2.2.0 64 bits (software mode):
Spoiler:


So, why does this happen? Is this intended or is it a bug? The prettier situation for brightness 0 would be the last one, but you need to choose always software mode for that. Thanks and sorry for the storm of pics.
Carrascado
 
Joined: 01 Mar 2016

Re: Weapons don't darken enough in dark places

Postby Graf Zahl » Sat Oct 29, 2016 4:41 pm

The weapon lighting in GZDoom was changed because it deviated too much from how Doom is supposed to light weapons.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Weapons don't darken enough in dark places

Postby Nevander » Sat Oct 29, 2016 8:36 pm

It makes no sense for a sector with 0 brightness to display a weapon sprite or thing within it as if it had a brightness of 150. Intended or not, it just looks wrong.
Nevander
Self-Banned User
 
Joined: 06 Jan 2014

Re: Weapons don't darken enough in dark places

Postby Carrascado » Sun Oct 30, 2016 1:24 am

Nevander wrote:It makes no sense for a sector with 0 brightness to display a weapon sprite or thing within it as if it had a brightness of 150. Intended or not, it just looks wrong.


I totally agree. It's just wrong and even ugly for me. Right now the only way to get rid of this problem is using software sector light mode, but this mode brightens up the stuff near the player, and I don't like that either :( .

Graf Zahl wrote:The weapon lighting in GZDoom was changed because it deviated too much fro how Doom is supposed to light weapons.

Graf Zahl, I kindly ask you to please reconsider this. I understand the reason, but it looks pretty weird in very dark maps and it breaks the experience a bit. I don't want to stick to software mode since I don't like the other features it gives (such as giving light around the player).

Couldn't you "fix" this using the new gzdoom lightning you mentioned?

Or at least making a new mode that darkens stuff properly. I'm sure a lot more people would appreciate it.

Thanks for reading.
Carrascado
 
Joined: 01 Mar 2016

Re: Weapons don't darken enough in dark places

Postby Graf Zahl » Sun Oct 30, 2016 2:11 am

If I change it back it will negatively affect the mods for which it got reported as a bug. The best you can get is a MAPINFO option so that you can explicitly set it for your mod.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Weapons don't darken enough in dark places

Postby Nash » Sun Oct 30, 2016 4:31 am

I'd settle with a mod option. Or a user setting maybe.
User avatar
Nash
Twitter/Facebook/Youtube: nashmuhandes
 
 
 
Joined: 27 Oct 2003
Location: Kuala Lumpur, Malaysia
Twitch ID: nashmuhandes
Github ID: nashmuhandes

Re: Weapons don't darken enough in dark places

Postby Carrascado » Sun Oct 30, 2016 12:57 pm

Graf Zahl wrote:If I change it back it will negatively affect the mods for which it got reported as a bug. The best you can get is a MAPINFO option so that you can explicitly set it for your mod.


Ok, I would be satisfied with the MAPINFO option, although, as Nash said, adding also an user setting to the options would be pretty nice.

Thanks!
Carrascado
 
Joined: 01 Mar 2016

Re: Weapons don't darken enough in dark places

Postby Carrascado » Sat Jan 07, 2017 8:00 am

Sorry for the bump, but I'm pretty noob on github and changelogs and stuff so... what did finally happen with this topic? Did it get some additional option or something?

The only thing I realised is now even the software renderer puts this additional fake light on weapons, so... any way that when I enter a light 0 sector the weapons go pitch black? That is the only thing I want.

Thanks in advance.
Carrascado
 
Joined: 01 Mar 2016

Re: Weapons don't darken enough in dark places

Postby Vdude » Sat Feb 04, 2017 10:37 pm

Welp, just found this, searching about the same issue. I guess there still isn't correct lighting in weapon sprites then.
User avatar
Vdude
 
Joined: 16 Aug 2013


Return to General

Who is online

Users browsing this forum: No registered users and 1 guest