[0.6.0-16-g270461b174] SW: Expansions ask shareware or full

[mjr4077au]

This is from Wanton Destruction and was good for the 6.0.0 release. Came about with some of the initial backend uplift efforts.

[Graf Zahl]

Yeah, it seems you undid my changes to the logic somehow.

[mjr4077au]

How might I have done that?

[Graf Zahl]

Originally SW never had the option to disable the shareware episode, it was a feature I added myself, so you must have gotten a merge conflict and overrode my code with VoidSW's.

[mjr4077au]

I plead innocence! It can be found back as far as the 12th of April in 156a225ff4c5392261aae8e8ea661ab92de4b842, which is the 'initial backend uplift' I speak of.

[mjr4077au]

The issue occured in either ac32194 or 5584c72. I couldn't build at the former commit without having the latter commit included.

I can only hypothesise, perhaps something to do with the way the hiding of the episodes list for the expansions was done isn't compatible with some of the newer backend code? Hopefully the issue is something obvious but I can't see where this might have gone wrong.

[Graf Zahl]

Hard to say, both commits look harmless regarding the episode menu.

[mjr4077au]

My thoughts exactly. Not sure why but building at the commit before ac32194 has the menu in SW working as expected. I'm sorry that I'm not able to determine further as to what happened.

[Graf Zahl]

Good that I looked at this before the GZDoom release, the bug was in both engines.
What happened was that the full file filter was never applied if it contained a '.' separator - in this case it completely missed the add-on's level definition file as a result. In Raze these files for the SW add-ons were the only potential victims but for GZDoom mods it would have been a lot worse.

[mjr4077au]

Good that I looked at this before the GZDoom release, the bug was in both engines.

And here you were blaming poor ol' me! . Nice that it's been found

[Graf Zahl]

Yeah, sorry, it looks this was an old bug that just got copied over from GZDoom.

[mjr4077au]

All good, I'm a big boy . Tested on this end and confirmed working.