Attempt to save pointer to unhandled type NativeStruct<Font>

[Marisa the Magician]

Reproduction: Load this mod, start a game, and use changemap to change to any other map. The game will fail to save with the message in the thread title.

I was told that font pointers were serializable, but apparently they aren't. I've been lied to, I want an explanation for this.

[Gutawer]

Appears to just be a typo in InitImports.

Code: Select all

	auto fontstruct = NewStruct("FFont", nullptr, true);
	fontstruct->Size = sizeof(FFont);
	fontstruct->Align = alignof(FFont);
	NewPointer(fontstruct, false)->InstallHandlers(
		[](FSerializer &ar, const char *key, const void *addr)
		{
			ar(key, *(FFont **)addr);
		},
			[](FSerializer &ar, const char *key, void *addr)
		{
			Serialize<FFont>(ar, key, *(FFont **)addr, nullptr);
			return true;
		}
	);

The ZScript type is called Font so the first line should contain "Font" rather than "FFont".

[Marisa the Magician]

Good lord, what just one tiny single-character typo can do...

[Graf Zahl]

I'm a bit puzzled why this didn't trigger earlier...

[Marisa the Magician]

I think I can take most of the blame for that, in assuming this was intentional for so many years.