[4.7.0] GZDoom doesn't recognize INDEXFON

[cubebert]

On GZDoom 4.6.1 and earlier versions, the engine will load wads that have INDEXFON used for their SBARINFO lump. However, loading the same wads on 4.7.0 will cause the engine to fail loading, giving out the message "Unknown font 'INDEXFON'". So far, this has affected Samsara, but it's likely that many older wads are affected as well. To reproduce this bug, simply load Samsara with GZDoom 4.7.0.

[imgur]https://i.imgur.com/FWptUZ3[/imgur]

[Blue Shadow]

The font is called "indexfont", with a "t" in the end.

[cubebert]

I've manually replaced each instance of INDEXFON with INDEXFONT and that seemed to fix the issue. Samsara works on GZDoom 4.7.0, Zandronum, and earlier versions of GZDoom, so I guess it's not really a GZDoom error so much as it is a user-end bug. Thanks for clarifying!

By the way, since earlier GZDoom versions could load INDEXFON without throwing out an error, is there any reason why that was changed in 4.7.0? I know that if people really wanted to, they could use those versions to play mods that might have that error pop up, but it seems to me like INDEXFON and INDEXFONT were interchangable, unless I'm mistaken.

[Graf Zahl]

It was undefined behavior. The sort name of indexfont.txr is INDEXFON. There has been some restructuring on the font code recently. Apparently some mods can't play by the rules if sloppy desgin is accepted by the engine,

[drfrag]

I was thinking about the 8 character limit for filenames in DOS and wad editing DOS tools.
This could be a problem (considering that Blzut3 created SBARINFO AFAIR). viewtopic.php?f=3&t=15903#p317233

[3saster]

Supposing that compatibility is restored (which it should, since it effects major mods no longer worked on like Samsara and High Noon Drifter), it would be easy enough to do it, no? Either duplicate INDEXFONT into a font called INDEXFON, or (probably better), just make INDEXFON an alias for INDEXFONT in the relevant font code.

[Blzut3]

Yeah, I have to say even I assumed the short name would always be a valid alias.

[Graf Zahl]

Normally, yes.
But I recently changed this font from a .fon file to a directory-based font when I had to edit it. For directory based fonts the short name does not exist in the file system.

We had exactly the same issue with CONFONT/CONSOLEFONT when that one got extended.