[Fixed] Typo in lights.pk3

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Typo in lights.pk3

Postby Marisa Kirisame » Mon Oct 21, 2019 6:03 am

While playing Heretic some days back I noticed something odd in the D'Sparil fight. The Serpent's fireballs had a really broken light with a massive flicker radius. I traced it down to this.
Code: Select allExpand view
// D'Sparil serpent fireball
flickerlight SERPENTBALL
{
    color 1.0 0.95 0.5
    size 588
    secondarySize 96
    chance 0.5
   attenuate 1
}

Pretty sure that size should be 88. Seems like this has been a thing for over two years and no one has noticed? The commit where it happened is this.
User avatar
Marisa Kirisame
ZScript Magician
 
 
 
Joined: 08 Feb 2008
Location: Vigo, Galicia
Discord: Marisa Kirisame#1666
Twitch ID: magusmarisa
Github ID: OrdinaryMagician
Operating System: Other Linux 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Typo in lights.pk3

Postby Rachael » Mon Oct 21, 2019 6:19 am

User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Graphics Processor: nVidia with Vulkan support

Re: Typo in lights.pk3

Postby Graf Zahl » Mon Oct 21, 2019 6:44 am

Amazing what kind of stuff goes unnoticed for so long...
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Typo in lights.pk3

Postby Enjay » Mon Oct 21, 2019 7:03 am

In this case, it probably shows how few people play Heretic, or at least Heretic maps with D'Sparil in them.

I just checked out my own lights definition that I updated from the previous non-attenuated values and I'd set it to 84 myself. Not saying that's better (the difference would be barely noticeable - much less than a difference of 500 anyway) more that my own calculation got it pretty close to the intended official 88.
User avatar
Enjay
Everyone is a moon, and has a dark side which he never shows to anybody. Twain
 
 
 
Joined: 15 Jul 2003
Location: Scotland

Re: Typo in lights.pk3

Postby Gez » Mon Oct 21, 2019 8:55 am

D'Sparil is typically fought in wide open-sky areas that are brightly lit, so the effect of dynlights is less pronounced that when they happen in small, dark corners.
Gez
 
 
 
Joined: 06 Jul 2007


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 0 guests