[Fixed] 'null' in SBARINFO stops loading

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

'null' in SBARINFO stops loading

Postby Ed the Bat » Sun Jan 01, 2017 3:35 pm

Lizard Squad v5.2, released in December 2013, no longer works in GZDoom (still true as of Jan 1 dev builds). I made brief mention of the issue here: viewtopic.php?f=3&t=54550#p961644

SBARINFO uses 'null' when 'untranslated' would have been the correct term. I will not deny this is a modding error/oversight, but up until (I presume) the introduction of ZScript, this did not prevent the mod from launching. Now:
Code: Select allExpand view
Execution could not continue.

Script error, "lizardsquad-v52a.zip:lizardsquad.wad:SBARINFO" line 66:
Expected identifier but got 'null' instead.

...which I suppose would qualify as a ZDoom regression.

If this isn't something that can be fixed engine-side, I can certainly release a hotfix. I just wanted to check first if that's something I would need to do.
User avatar
Ed the Bat
I'm tired. I want to go home.
 
Joined: 03 May 2012
Location: Maryland, US

Re: 'null' in SBARINFO stops loading

Postby Graf Zahl » Sun Jan 01, 2017 4:11 pm

This was caused by 'null' becoming a keyword. The SBARINFO parser is rather lax and treated any unknown color name as 'untranslated' instead of throwing an error. That's why 'null' got through. But now that it is a separate token type it needs special handling.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: 'null' in SBARINFO stops loading

Postby Ed the Bat » Sun Jan 01, 2017 4:13 pm

I had a feeling it was something like that. I guess all I really need to know is, will I need to put out a hotfix for the mod to cover this? It's no trouble, but I won't do it if it's not necessary.
User avatar
Ed the Bat
I'm tired. I want to go home.
 
Joined: 03 May 2012
Location: Maryland, US

Re: 'null' in SBARINFO stops loading

Postby Graf Zahl » Sun Jan 01, 2017 5:06 pm

Hotfix, no, but if you plan a new release it would be better.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: 'null' in SBARINFO stops loading

Postby Ed the Bat » Sun Jan 01, 2017 5:09 pm

It'll be up to LizardCommando, but I'll bring the idea to him. There could be some other improvements in the mod I'd like to pitch to him, and I'd be sure to update the SBARINFO to do things correctly (and silence the truncation warnings while I'm at it).
User avatar
Ed the Bat
I'm tired. I want to go home.
 
Joined: 03 May 2012
Location: Maryland, US

Re: 'null' in SBARINFO stops loading

Postby Gez » Mon Jan 09, 2017 12:52 pm

This also affects the PSX Doom TC.
Gez
 
 
 
Joined: 06 Jul 2007


Return to Closed Bugs

Who is online

Users browsing this forum: Awario [RSS] and 1 guest