[Since ZScript] Bouncing bugginess

[Major Cooke]

Code: Select all

Class D : Actor
{
	Actor rr;
	Default
	{
		Monster;
		-COUNTKILL
		+NODAMAGE
		+NOPAIN
		+DONTTHRUST
		Radius 32;
		Height 56;
	}
	States
	{
	Spawn:
		PLAY A 1 NoDelay
		{
			if (A_CheckFloor("Null"))
			{
				Vector3 rocketpos = Vec3Angle(0, angle, height + 12);
				rr = Spawn("BouncyRocket",rocketpos);
				if (rr)
				{
					let br = BouncyRocket(rr);
					if (br)
					{
						br.angle = angle;
						br.A_ChangeVelocity(1,0,-4,CVF_REPLACE);
						return ResolveState(1);
					}
				}
				Destroy();
			}
			return ResolveState(null);
		}
		Wait;
		PLAY A 1
		{
			if (!rr)	Destroy();
		}
		Wait;
	}
}

BouncyRocket code is different for each scenario to demonstrate relative bugs. Note, for this experiment, just summon D, not BouncyRocket.

---

Code: Select all

Class BouncyRocket : Actor
{
	Default
	{
		Projectile;
		+ALLOWBOUNCEONACTORS
		+BOUNCEONACTORS
		+BRIGHT
		Radius 4;
		Height 4;
		BounceFactor 1.0;
		Speed 4;
	}
	States
	{
	Spawn:
		MISL A 1;
		Loop;
	Death:
		MISL B 8 A_Stop();
		MISL C 6;
		MISL D 4;
		Stop;
	}
}

• Expected behavior:
  Bounces off the top.
• Result:
  Goes right through though turns around.

---

Code: Select all

Class BouncyRocket : Actor
{
	Default
	{
		Projectile;
		BounceType "Doom";
		+BRIGHT
		Radius 4;
		Height 4;
		BounceFactor 1.0;
		Speed 4;
	}
	States
	{
	Spawn:
		MISL A 1;
		Loop;
	Death:
		MISL B 8 A_Stop();
		MISL C 6;
		MISL D 4;
		Stop;
	}
}

• Expected Behavior: Explode on top of D.
• Result: Lands on top, glides across until no longer on top and then continues going down.

---

Code: Select all

Class BouncyRocket : Actor
{
	Default
	{
		Projectile;
		BounceType "Doom";
		-ALLOWBOUNCEONACTORS
		-BOUNCEONACTORS
		+BRIGHT
		Radius 4;
		Height 4;
		BounceFactor 1.0;
		Speed 4;
	}
	States
	{
	Spawn:
		MISL A 1;
		Loop;
	Death:
		MISL B 8 A_Stop();
		MISL C 6;
		MISL D 4;
		Stop;
	}
}

• Expected Result: Explode on actor D.
• Result: Similar to Scenario 2, except it doesn't resume going down. It just goes straight across with no vertical velocity.

[Major Cooke]

Ugh. Wish I could find the commit where this changed but I will say it was during one of the refactors. I saw something about the onmobj flag, I think. Still searching for it...

[Graf Zahl]

Sadly these tests are perfectly useless because I cannot go back far enough in commit history to test them on pre-ZScript versions. All I can see is that they do not work, but it's impossible to find out when this broke.

[Major Cooke]

Ugh, damn it all to hell. Welp! Looks like I'm going to be pulling in the bounce states for use after all... This is gonna suck.

[Graf Zahl]

This cost me quite a bit of time to figure out:

You forgot to set a bounce type. Bouncing missiles require the CANPASS flag, but nothing in your definition sets it, it either needs to be done explicitly or by specifying a bounce type.

[Major Cooke]

Scenario 2 and 3 has a bounce type. But, shouldn't Projectile; do that CANPASS business?

[Graf Zahl]

No. The problem is in the bouncing code, it needs that flag or it won't work.

The rest of this problem is the same issue as the other one I closed a few hours ago. This is not something that's easily fixed because the logic is so screwed up.