[gzdoom-g2.3pre-918-g48d17f8]Bizarre bug with A_FireBullets

[FireSeraphim]

I am aware that the devs may not feel inclined to fix or maintain decorate anymore but this is one bizarre bug that would be somewhat inexcusable for Randi or any of the senior devs to not fix.

I ran into a freakish bug involving the missile portion of A_FireBullets while I was working on a mod today, Basically for some odd reason when I aim upwards and fire my custom shotgun the "tracers" I made for my shotgun went downward at an angle exactly opposite of the angle the actual hitscans landed. I will provided the pk3. file for my current mod if the devs absolutely need it to figure out what the hell is going on.

[Rachael]

I am aware that the devs may not feel inclined to fix or maintain decorate anymore but this is one bizarre bug that would be somewhat inexcusable for Randi or any of the senior devs to not fix.

And why is that? How exactly is work you're getting for free "excusable"?

That being said, it may occur in DECORATE but that does not mean the problem is actually DECORATE-related. If it's a problem with an action function, those are defined in parent by ZScript.

Posting your pk3 would almost certainly be helpful.

(This may be somewhat related to the pitch issues)

[FireSeraphim]

https://dl.dropboxusercontent.com/u/762 ... _Alpha.pk3 Here's my PK3, the quickest way to test it out is to go to MAP32 and fire the Pistol, Shotguns and Chaingun replacements (plus the rifle in my mod)

[Rachael]

I was able to confirm the bug, however I've tried two fixes to the source and have not been able to fix this, so I am going to have to let someone who is more familiar with the affected function do this.

EDIT: https://github.com/rheit/zdoom/pull/944

I am not 100% positive about this fix, but the minus sign did seem a bit unusual there. I think it should be safe to remove it as per submission and leave it out completely.

[Major Cooke]

That was what I tried to fix but Graf closed my pull request. (Albeit I had multiple things changed in it...)

Also, it was negative because, originally, the whole pitch situation was inversed.

[Rachael]

(Albeit I had multiple things changed in it...)

That's one of the things you've gotta stop doing. Do pull requests for one thing and one thing only. If you need to do other things, like code cleanups, talk to him first.

[Major Cooke]

To be fair it was all lumped into one category. If you do one of them, you have to do all of them that you can find. Otherwise, you run the risk of rampant inconsistency and that can be a true nightmare to deal with.

[Graf Zahl]

fixed

[FireSeraphim]

Um, not quite. The bug has once again reared it's ugly head in the december 24th build

[Graf Zahl]

Argh!

What is it now? I change it and it's still wrong? The Dec 24th change was the only one I made.

[Rachael]

I think you made the change *after* the build. Does it still happen in QZDoom? That one usually uses cutting edge code, if I had bothered to build it recently, and in this case I did.