[Fixed] Integer Overflow and incompatibility with Boom's scrolls

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.

Integer Overflow and incompatibility with Boom's scrolls

Postby entryway » Sat Dec 07, 2013 3:37 am

1. Even with «boom (strict)» compatibility position of the blue armor after teleporting is not the same as in Boom (on the center). Shouldn't it?
2. After opening the door on the test level from the attach ZDoom crashes within ~2 minutes with Integer Overflow message. GZDoom does not.
You do not have the required permissions to view the files attached to this post.
entryway
 
Joined: 30 Aug 2005

Re: Integer Overflow and incompatibility with Boom's scrolls

Postby Graf Zahl » Tue Mar 24, 2015 3:05 am

I couldn't reproduce the crash - integer overflow notrmally can't happen unless there's a problem with the CPU - but the position issue is interesting:

It does get placed correctly, there's just a small issue with the order in which things get done:

- The move is too fast so it gets split in two.
- The first half of the move performs the teleport
- The second half of the move never realizes that the situation has changed and still does its thing.

Of course the direction it tries to move the armor in is wrong now. Since cause and effect are quite separated in the code this is going to be tricky...
The entire movement splitting in P_XYMovement seems to run bad if a move is blocked the first time around but in most cases the results are barely noticable.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Integer Overflow and incompatibility with Boom's scrolls

Postby Graf Zahl » Wed Mar 09, 2016 5:50 am

fixed, since this also affected angle-changing portals it just became far more important to be addressed.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 0 guests