Console memory lag issue

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.

Post a reply

Smilies
:D :) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :wink: :geek: :ugeek: :!: :?: :idea: :arrow: :| :mrgreen: :3: :wub: >:( :blergh:
View more smilies
BBCode is OFF
Smilies are ON
Topic review
   

Expand view Topic review: Console memory lag issue

Re: Console memory lag issue

by unknownna » Thu Oct 06, 2016 6:04 pm

Graf, would it be possible to at least have a text displayed somewhere in the error window that says "Generating crash report, please wait." or something like that? I think the average, casual user would find it very confusing to just see a bunch of text streaming down the window fast without any further explanation on what's going on. Presumably the user would just close the window before ZDoom/Zandronum got a chance to generate the report.
Attachments
error_window.png
error_window.png (6.98 KiB) Viewed 715 times

Re: Console memory lag issue

by Graf Zahl » Sun Aug 09, 2015 3:02 pm

To be honest, I have no good idea what to do here. The only way to get rid of the delay is not to add the messages to the log window and that's not a good option.

Re: Console memory lag issue

by unknownna » Sun Aug 09, 2015 2:07 pm

Graf, several of the Zandronum developers are wondering whether you're going to improve the fix? Apparently it's not good enough for backporting in its current state.
unknownna wrote:It took around 36 seconds for it to generate the report when crashing after having copy-pasted the command in the OP.
They're not too happy with this part.

Re: Console memory lag issue

by unknownna » Thu Jul 16, 2015 7:50 am

It took around 36 seconds for it to generate the report when crashing after having copy-pasted the command in the OP. That's the equivalence of having played for around 1.5-2 hours on a high-intensity Zandronum CTF server I think.

Re: Console memory lag issue

by Graf Zahl » Thu Jul 16, 2015 7:39 am

Out of curiosity, how long does it take? Several seconds, a minute or even more?

Re: Console memory lag issue

by unknownna » Thu Jul 16, 2015 5:05 am

Ok, using zdoom-2.8pre-1669-gadd52d4.7z I was able to confirm that the issue has been resolved. However, it takes ages for it to generate an error report now if the console was full of stuff before the crash occurred. But I suppose it's fine for most cases though. It'll only take a while if it crashes after hours of play.

Thank you very much for fixing this issue, Graf. I really appreciate it. Thanks!

Re: Console memory lag issue

by unknownna » Wed Jul 15, 2015 7:52 am

Graf Zahl wrote:I'm waiting for confirmation now.
I'll need someone to supply me with a test build again. Or I could wait for the next build at DRD (which could take days).

Re: Console memory lag issue

by Graf Zahl » Wed Jul 15, 2015 4:55 am

I addressed this by locally buffering the RichEdit control's content while that control is invisible. The content now gets added only if some later error forces display of that control again.
I'm waiting for confirmation now.

Re: Console memory lag issue

by unknownna » Wed Jul 15, 2015 2:01 am

Thank you very much for that build, edward850!
Graf Zahl wrote:As a quick test: Comment out the I_PrintStr call in c_console.cpp:PrintString to see if this helps resolve the lag.
Indeed, that took care of the issue. It's now as smooth as 1.22/1.23b33 (ZDaemon).

Re: Console memory lag issue

by edward850 » Wed Jul 15, 2015 1:48 am

Here you go: https://www.dropbox.com/s/n53w7wnvboyck ... fo.7z?dl=0

Re: Console memory lag issue

by unknownna » Wed Jul 15, 2015 1:24 am

I don't know how to compile builds since I'm not a coder/programmer, so unfortunately I can't test it.

Re: Console memory lag issue

by Graf Zahl » Wed Jul 15, 2015 1:06 am

As a quick test: Comment out the I_PrintStr call in c_console.cpp:PrintString to see if this helps resolve the lag.

Re: Console memory lag issue

by Graf Zahl » Wed Jul 15, 2015 12:50 am

Thanks for mentioning 2.0.95. In that version the edit control was added to display the error window. And THAT definitely can cause problems. (And guess what: This actually never gets cleared at all...) And in 2.2.0 it was replaced with a RichEdit control, therefore the increase in lag.

I think the best course of action here will be to omit pure in-game messages from being added there, that'll require quite a bit of work, though (and special handling for Zandronum's own messages.)

Re: Console memory lag issue

by unknownna » Tue Jul 14, 2015 9:25 pm

This didn't happen in earlier versions of ZDoom (2.1.1). I'll investigate this further.

1.22 - Very fast and very stable.
1.23b33 (ZDaemon) - Same as above.
2.0.40 - Same as above.
2.0.63a - Very fast, but crashes if the command is pasted too often in the console during gameplay.
2.0.90 - Same as above.
2.0.94 - Same as above.
2.0.95 - Starts to lag slightly when pasting the command. Also crashes if the command is pasted too often in the console during gameplay.
2.1.0 - Same as above, but it doesn't crash anymore.
2.1.1 - Same as above.
2.1.2 - Starts to lag more when pasting the command.
2.1.3 - Same as above.
2.1.4 - Same as above.
2.1.5 - Same as above.
2.1.6 - Same as above.
2.1.7 - Same as above.
2.2.0 - Problem starts to appear. Starts to lag considerably more when pasting the command. Gameplay starts to lag.

Re: Console memory lag issue

by unknownna » Tue Jul 14, 2015 7:18 pm

Unfortunately nothing happens. It clears out the text, but it still lags/stutters just as much. The only way to work around this currently is to quit and restart (g)zdoom/zandronum.exe.

Top