ZDoom

This should be caught during development - and any new addition here will inevitably trigger the assert - and immediately be removed.

but in a release build, the 'assert' is simplified ... what about a 'I_(Fatal?)Error' call?

You are correct. These are never used by any DrawText call. I just replaced the offending code with an 'assert(false)'. Using these should be forbidden as they don't work anyway.

[quote="Graf Zahl"]That code is still needed so just silencing the error and ignoring the problem is not going to help matters.[/quote]
Mind to give me a line #? I don't see any calls to DrawText that use these tags, which makes sense since they appear to be no-ops.

That code is still needed so just silencing the error and ignoring the problem is not going to help matters.

[quote="Graf Zahl"][quote="Csonicgo"]Solution: Change these offending lines to:

[code]assert(false && "unsupported");[/code][/quote]


What does that solve? It only breaks the code.[/quote]

Is there a better solution to this? This is the only showstopper in the code that prevents ARM compilation as far as I can tell.

The offending lines are disabling invalid input before passing the tags off to character drawing. Unless I'm missing something (my test case for the change suggested was ECWolf's Android port, I imagine Beloko did the same for GZDoom's Android port), using asserts here is harmless since you should never input those values when drawing text.

[quote="Csonicgo"]Solution: Change these offending lines to:

[code]assert(false && "unsupported");[/code][/quote]


What does that solve? It only breaks the code.

		// We don't handle these. :(
		case DTA_DestWidth:
		case DTA_DestHeight:
			*(DWORD *)tags = TAG_IGNORE;   <--
			data = va_arg (tags, DWORD);
			break;

		// Translation is specified explicitly by the text.
		case DTA_Translation:
			*(DWORD *)tags = TAG_IGNORE;  <--
			ptrval = va_arg (tags, void*);
			break;

assert(false && "unsupported");

https://github.com/rheit/zdoom/blob/6d4eb7f62d73cd9ea7ea7630b5af3d588a45b5d6/src/v_text.cpp#L159
https://github.com/rheit/zdoom/blob/6d4eb7f62d73cd9ea7ea7630b5af3d588a45b5d6/src/v_text.cpp#L153

These two lines in this block of code:

[code]
// We don't handle these. :(
case DTA_DestWidth:
case DTA_DestHeight:
*(DWORD *)tags = TAG_IGNORE; <--
data = va_arg (tags, DWORD);
break;

// Translation is specified explicitly by the text.
case DTA_Translation:
*(DWORD *)tags = TAG_IGNORE; <--
ptrval = va_arg (tags, void*);
break;[/code]

may cause an error on compilation on non x86-64 platforms, because type va_list cannot be cast to DWORD* (aka an unsigned int*) .

Solution: Change these offending lines to:

[code]assert(false && "unsupported");[/code]