[4.14.2] Crash on load when trying to load a PWAD

[Muleke_Trairao]

So, there is a WAD that I'm trying to load on GZDoom 4.14.2 called Judgement: Retrial. It gives the following error when trying to load it:



"Thing 95: DEHACKED actors that set 'Projectile pass height' must also set 'Physical height'"

The WAD loads up fine in GZDoom 4.14.1, so something is not quite right with 4.14.2.

No mods were being loaded alongside the WAD.

Thank you for your attention and hard work!

[Graf Zahl]

The mod is wrong here. These options were only added in 4.14.2 and it was clearly conveyed that both must be set to avoid problems. Apparently some modder did not test this properly or only with a pre-release version.
It works in 4.14.1 because it ignores these unknown properties.

[Muleke_Trairao]

I see. Thanks for the reply!

[Scuba Steve]

Here's a temporary fix.

Just replace the Dehacked file in the wad with this and it should run.

[Rachael]

It looks like the flags in question were sanity checks and Xaser offered his reasoning even within the commit itself for doing it the way he did.

It seems like the reason why it "worked" before is because the properties were not actually present in older versions of GZDoom so older versions of GZDoom simply ignored them.

Since there's a temporary fix offered by Scuba Steve, I'm going to go ahead and move this off. If more mods get affected by this we can consider putting something in that emits a warning and falls back to the Height-only property.

Code in question:
https://github.com/ZDoom/gzdoom/blob/5e ... 1783-L1792
https://github.com/ZDoom/gzdoom/commit/ ... d3576b2d41