DECORATE to ZScript Conversion questions

[Enjay]

Most of the time, the ZScript version matches the GZDoom version number. Right now it's 4.14.0.

...and that also makes sense. Thanks again. The reason I thought it was 4.8.2 was because the newest mod I could find had that version. As for me being confused and thinking that somehow the 4.12 in GZDoom.pk3 was lower than that, put it down to a late-night brain fart!
(Although, perhaps it should be 4.14?)


Anyway, I versioned my files at 4.14 and it flagged up a whole bunch of... well, flags actually, that were deprecated in 4.13. No problems there. I have fixed that. The wiki was nice and clear what the better/up to date alternatives are.

However, versioning to 4.14 has also thrown up some warnings that are beyond me to fix: comparison of signed and unsigned values.

I understand the problem, comparing a value that can only be +ve to one that could be +ve or -ve, and I've read about the potential resulting screwy big numbers, but I am unsure how to fix the code. None of it was my code originally.

All of the relevant lines look very similar (probably not surprisingly). Each line has a "uint", which I understand is an unsigned integer. I can "fix" the warnings (i.e. make them go away) by simply changing "uint" to "int" in each case. However, I want to check that it is safe to do that. The various scripts in question still seem to work, and their effects in game seem to be identical. So, fingers crossed that this is an acceptable fix, but can anyone confirm?

Here are the warnings followed by the relevant lines for each case.

---

1)

Code: Select all

Script warning, "00BaseControlText.pk3:zscript/actors/ladder.zs" line 55:
Comparison between signed and unsigned value

Code: Select all

for (uint i = 0; i < ignored.Size(); ++i)

2)

Code: Select all

Script warning, "00BaseControlText.pk3:zscript/actors/ladder.zs" line 61:
Comparison between signed and unsigned value

Code: Select all

for (uint i = 0; i < potentialClimbers.Size(); ++i)

3)

Code: Select all

Script warning, "00BaseControlText.pk3:zscript/actors/ladder.zs" line 84:
Comparison between signed and unsigned value

Code: Select all

for (uint i = 0; i < climbers.Size(); ++i)

4)

Code: Select all

Script warning, "00BaseControlText.pk3:zscript/actors/ladder.zs" line 173:
Comparison between signed and unsigned value

Code: Select all

for (uint i = 0; i < climbers.Size(); ++i)

5)

Code: Select all

Script warning, "00BaseControlText.pk3:zscript/spacedamage/spacedamage.zc" line 18:
Comparison between signed and unsigned value

Code: Select all

for(uint i = 0; i < level.sectors.size(); i++)

6)

Code: Select all

Script warning, "00BaseControlText.pk3:zscript/spacedamage/spacedamage.zc" line 50:
Comparison between signed and unsigned value

Code: Select all

for(uint i = 0; i < sectors_id.size(); i++)

[phantombeta]

For these lines you posted, it should be safe to simply change uint to int, yes.

[Enjay]

Perfect, thank you once again.