Professor Hastig wrote: ↑Fri Sep 20, 2024 3:24 am It is hard to tell what they did - there's too many random changes throughout the code which makes comparing it very hard, much less finding the commit where they branched off.
Highlighting these two statements because they simply cannot be overstated.dpJudas wrote: ↑Fri Sep 20, 2024 1:45 am I'm sorry Muusi, but any changes you see in Selaco was done in such a way to only serve their own game. It is their right to do that per the license, but it ultimately also means their stuff will most likely never end up in GZDoom proper until someone else implements the same thing in a proper way that meets the quality standards required to survive as a PR.
If they really wanted to benefit the GZDoom community as a whole - they'd stop sequestering themselves away from it and actually do the PR's and code reviews to get their additions working. Just saying "it's there, we're so kind and generous" isn't enough. As dpJudas said, that's enough to satisfy the license - not helping with crucial and critical things like code deltas.
Let's not even start on the shim they used for the Steam achievements - I can't find a source for that anywhere, and GPL requires that if you distribute other items with a GPL project they too must be open source. That isn't following the license.