ZScript - Making one option menu execute another.

[Dewzanity]

Hello, I am here to find someone who knows even a little bit of ZScript, because I know practically nothing.

The code I have is borrowed from itsmedoggo's CH custom difficulty addon. I am trying to figure out how I can execute the OptionMenuItemCHPOptionsUpdate menu item from within OptionMenuItemCHPOptionsReset. I have executeCHPOptionsUpdate(); right above the set of 30 CVars, as well as some ChatGPT generated code right below it that is causing problems that is meant to execute OptionMenuItemCHPOptionsUpdate. Once again I will say that I have zero knowledge of Zscript myself, so I wouldn't be surprised if the solution is obvious.

---

Code: Select all

class OptionMenuItemCHPOptionsReset : OptionMenuItem {
   int mType;
   
   OptionMenuItemCHPOptionsReset init(int type = 0, string label = "Reset to default values") {
      super.init(label, 'None', true);
      mType = type;
      return self;
   }
   
   override int draw(OptionMenuDescriptor desc, int y, int indent, bool selected) {
      int x = drawLabel(indent, y, selected? OptionMenuSettings.mFontColorSelection : OptionMenuSettings.mFontColorMore);
		if (mCentered) {
			return x - 16*CleanXfac_1;
		}
		return indent;
   }
   
   override bool activate() {
      if (mType == 0) {
         for (int i = 1; i <= 18; i++) {
            setToDefaults(i);
         }
      }
      else {
         setToDefaults(mType);
      }
	executeCHPOptionsUpdate();
	
      return true;
   }
   
   void setToDefaults(int type) {
      switch (type) {
         case 1:
			Menu.menuSound("menu/choose");
            CVar.findCVar("CHP_A1C_Chance").ResetToDefault();
            CVar.findCVar("CHP_A1G_Chance").ResetToDefault();
            CVar.findCVar("CHP_A1B_Chance").ResetToDefault();
            CVar.findCVar("CHP_A1P_Chance").ResetToDefault();
            CVar.findCVar("CHP_A1Y_Chance").ResetToDefault();
            CVar.findCVar("CHP_A1R_Chance").ResetToDefault();
            CVar.findCVar("CHP_A1K_Chance").ResetToDefault();
            CVar.findCVar("CHP_A1W_Chance").ResetToDefault();
            CVar.findCVar("CHP_A1KX_Chance").ResetToDefault();
            CVar.findCVar("CHP_A1WX_Chance").ResetToDefault();
            CVar.findCVar("CHP_A1A_Chance").ResetToDefault();
            CVar.findCVar("CHP_A1BR_Chance").ResetToDefault();
            CVar.findCVar("CHP_A1CY_Chance").ResetToDefault();
            CVar.findCVar("CHP_A1F_Chance").ResetToDefault();
            CVar.findCVar("CHP_A1GY_Chance").ResetToDefault();
            CVar.findCVar("CHP_A2C_Chance").ResetToDefault();
            CVar.findCVar("CHP_A1G_Chance").ResetToDefault();
            CVar.findCVar("CHP_A2B_Chance").ResetToDefault();
            CVar.findCVar("CHP_A2P_Chance").ResetToDefault();
            CVar.findCVar("CHP_A2Y_Chance").ResetToDefault();
            CVar.findCVar("CHP_A2R_Chance").ResetToDefault();
            CVar.findCVar("CHP_A2K_Chance").ResetToDefault();
            CVar.findCVar("CHP_A2W_Chance").ResetToDefault();
            CVar.findCVar("CHP_A2KX_Chance").ResetToDefault();
            CVar.findCVar("CHP_A2WX_Chance").ResetToDefault();
            CVar.findCVar("CHP_A2A_Chance").ResetToDefault();
            CVar.findCVar("CHP_A2BR_Chance").ResetToDefault();
            CVar.findCVar("CHP_A2CY_Chance").ResetToDefault();
            CVar.findCVar("CHP_A2F_Chance").ResetToDefault();
            CVar.findCVar("CHP_A2GY_Chance").ResetToDefault();
			break;
		default:
			break;
		}
	}

	void executeCHPOptionsUpdate() {
		OptionMenuItemCHPOptionsUpdate updateItem = OptionMenuItemCHPOptionsUpdate();
		updateItem.activate();
	}
}

class OptionMenuItemCHPOptionsResetWithMessageBox : OptionMenuItemCHPOptionsReset {
   override bool menuEvent(int mKey, bool fromController) {
      if (mKey == Menu.MKEY_MBYes) {
         super.activate();
         return true;
      }
      return super.menuEvent(mKey, fromController);
   }
}

class OptionMenuItemCHPOptionsUpdate : OptionMenuItem { //not necessary to display past this point

[Player701]

Am I correct to assume this is the ChatGPT code you're talking about?

Code: Select all

void executeCHPOptionsUpdate() {
    OptionMenuItemCHPOptionsUpdate updateItem = OptionMenuItemCHPOptionsUpdate();
    updateItem.activate();
}

If so, the correct version would me:

Code: Select all

void executeCHPOptionsUpdate() {
    let updateItem = new('OptionMenuItemCHPOptionsUpdate');
    updateItem.activate();
}

But do note that without seeing the implementation of OptionMenuItemCHPOptionsUpdate, it's hard to say whether this is actually going to work, as you're not calling the Init method (but doing that might have its own unwanted side effects).

Instead, provided that both items are in the same option menu, you can use this code:

Code: Select all

void executeCHPOptionsUpdate()
{
    let menu = OptionMenu(Menu.GetCurrentMenu());

    if (menu != null)
    {
        foreach (item : menu.mDesc.mItems)
        {
            if (item is 'OptionMenuItemCHPOptionsUpdate')
            {
                item.Activate();
                return;
            }
        }
    }
}