Welcome to the ZDoom Forums!

Hello, I was wondering if someone would be able to edit this existing code to make it when you altfire it goes into an animation where the player attaches a suppressor to it and the weapon is suppressed and is reversed when you altfire again back to its unsuppressed state. I'd prefer it being one weapon if possible, I already made the sprites for it and looks really good. (I am pretty much looking for my pistol code to be altered so it can be suppressed and unsuppressed when the player presses the right mouse button or the 'altfire' key) I have tried to do it myself but I can't for the life of me figure it out on my own.

/////Code Here/////

Spoiler:

---

ACTOR M1911 : Weapon 17001 { //$Category DOV - WEAPONS Weapon.SlotNumber 2 Weapon.SelectionOrder 1 Weapon.Kickback 50 Weapon.BobRangeX 0.3 Weapon.BobRangeY 0.5 Weapon.BobStyle InverseSmooth Weapon.BobSpeed 2.4 Obituary "%o was executed by %k's customized 1911." Scale 0.4 Radius 15 Height 15 Decal "MagnumHole" AttackSound "1911FIR2" Inventory.Pickupmessage "Obtained customized 1911!" Inventory.PickupSound "1911UP" Weapon.Ammotype1 "1911Loaded" Weapon.Ammotype2 "1911Ammo" Weapon.Ammouse 1 Weapon.Ammouse2 0 Weapon.Ammogive1 0 Weapon.Ammogive2 5 +Weapon.Ammo_Optional +NOAUTOFIRE +NOEXTREMEDEATH +COUNTITEM +CASTSPRITESHADOW States { Spawn: 1911 A -1 loop Pickup: 1911 A 0 A_GiveInventory("QuickKick", 1) Stop Ready: 1911 B 1 A_WeaponReady(WRF_ALLOWRELOAD) loop Select: 1911 B 0 A_PlaySound("DRAW",CHAN_AUTO) 1911 B 1 Offset (90,69) 1911 B 1 Offset (70,60) 1911 B 1 Offset (55,52) 1911 B 1 Offset (35,45) 1911 B 1 Offset (15,39) 1911 B 1 Offset (1,35) SelectRaise: 1911 B 1 A_RAISE Loop Deselect: 1911 B 0 A_PlaySound("AWAY", CHAN_WEAPON) 1911 B 1 Offset (1,35) 1911 B 1 Offset (15,39) 1911 B 1 Offset (35,45) 1911 B 1 Offset (55,52) 1911 B 1 Offset (70,60) 1911 B 1 Offset (90,69) 1911 B 1 Offset (105,89) 1911 B 1 Offset (125,102) 1911 B 1 Offset (155,108) 1911 B 1 Offset (155,150) DeselectRaise: 1911 B 0 Offset (-1,0) 1911 B 1 A_Lower Loop Fire: 1911 C 0 A_JumpIfNoAmmo("Reload") 1911 C 0 A_StartSound("1911FIR2",CHAN_AUTO) 1911 C 2 Bright A_FireProjectile("PistolTracer", FRandom(-0.6, 0.6), true, 0, 0, 0, FRandom(-2.0, 2.0)) 1911 C 0 A_spawnitemex ("Casing", 34, 1, 27, random(1,6), random(1,8), random(1,9), 0) 1911 C 0 A_FireCustomMissile("GunSmokeSpawner",0,0,0,5) 1911 D 2 Bright A_SetPitch(pitch-0.3) 1911 E 1 A_SetPitch(pitch-0.3) 1911 F 1 A_SetPitch(pitch-0.8) 1911 G 1 A_SetPitch(pitch+0.8) 1911 B 0 A_SetPitch(pitch+0.3) 1911 B 0 A_SetPitch(pitch+0.3) Goto Ready Reload: 1911 B 0 A_JumpIfInventory("1911Loaded", 7, 2) // If the gun's full, jump 2 states. 1911 B 0 A_JumpIfInventory("1911Ammo", 1, "ReloadWork") // If there's extra ammo, reload. 1911 B 1 // Here's where that first line ends up - the gun does nothing and returns to Ready. Goto Ready ReloadWork: 1911 B 1 Offset(0,35) 1911 B 1 Offset(-2,38) 1911 B 0 A_PlaySound("1911MAG1",CHAN_AUTO) 1911 B 1 Offset(-4,44) 1911 B 1 Offset(-6,52) 1911 B 1 Offset(-1,54) 1911 B 6 Offset(-2,56) 1911 B 0 A_FireCustomMissile("PistolMagDrop",-5,0,8,-4) 1911 B 1 Offset(-1,54) 1911 B 1 Offset(-6,52) 1911 B 1 Offset(-4,44) 1911 B 0 A_PlaySound("1911MAG2",CHAN_AUTO) 1911 B 1 Offset(-2,38) 1911 B 1 Offset(0,35) 1911 B 1 Offset(0,35) 1911 B 1 Offset(-3,56) 1911 B 1 Offset(-3,56) 1911 B 1 Offset(-3,51) 1911 B 1 Offset(-3,53) 1911 B 1 Offset(0,35) 1911 B 1 Offset(0,35) ReloadLoop: 1911 B 0 A_TakeInventory("1911Ammo", 1) 1911 B 0 A_GiveInventory("1911Loaded", 1) 1911 B 0 A_JumpIfInventory("1911Loaded", 7, "ReloadFinish") 1911 B 0 A_JumpIfInventory("1911Ammo", 1, "ReloadLoop") Goto ReloadFinish ReloadFinish: 1911 B 1 Offset(-3,57) 1911 B 1 Offset(-3,59) 1911 B 1 Offset(-3,63) 1911 B 1 Offset(-3,67) 1911 B 1 Offset(-3,65) 1911 B 0 A_PlaySound("1911UP",CHAN_AUTO) 1911 B 1 Offset(-3,62) 1911 B 1 Offset(-3,58) 1911 B 1 Offset(-3,55) 1911 B 1 Offset(-2,53) 1911 B 1 Offset(-2,49) 1911 B 1 Offset(-2,46) 1911 B 1 Offset(-2,45) 1911 B 1 Offset(-1,44) 1911 B 1 Offset(-1,46) 1911 B 1 Offset(-1,47) 1911 B 1 Offset(0,49) A_WeaponReady(WRF_NOBOB) 1911 B 1 Offset(0,44) A_WeaponReady(WRF_NOBOB) 1911 B 1 Offset(0,38) A_WeaponReady(WRF_NOBOB) 1911 B 1 Offset(0,35) A_WeaponReady(WRF_NOBOB) 1911 B 1 Offset(0,32) A_WeaponReady(WRF_NOBOB) Goto Ready Goto ready } } ACTOR 1911Loaded : Ammo { Inventory.MaxAmount 7 +IGNORESKILL }

First of all, please use the code tag, it makes copying your code easier.

Try this:

Spoiler: code

---

Code: Select all

ACTOR M1911 : Weapon 17001
{
//$Category DOV - WEAPONS
Weapon.SlotNumber 2
Weapon.SelectionOrder 1
Weapon.Kickback 50
Weapon.BobRangeX 0.3
Weapon.BobRangeY 0.5
Weapon.BobStyle InverseSmooth
Weapon.BobSpeed 2.4
Obituary "%o was executed by %k's customized 1911."
Scale 0.4
Radius 15
Height 15
Decal "MagnumHole"
AttackSound "1911FIR2"
Inventory.Pickupmessage "Obtained customized 1911!"
Inventory.PickupSound "1911UP" 
Weapon.Ammotype1 "1911Loaded"
Weapon.Ammotype2 "1911Ammo"
Weapon.Ammouse 1
Weapon.Ammouse2 0
Weapon.Ammogive1 0
Weapon.Ammogive2 5
+Weapon.Ammo_Optional
+NOAUTOFIRE
+NOEXTREMEDEATH
+COUNTITEM
+CASTSPRITESHADOW
+WEAPON.NOALERT
States
{
Spawn:
1911 A -1
loop
Pickup:
1911 A 0 A_GiveInventory("QuickKick", 1)
Stop   
Ready:
1911 B 1 A_WeaponReady(WRF_ALLOWRELOAD)
loop     
Select:
1911 B 0 A_PlaySound("DRAW",CHAN_AUTO)
1911 B 1 Offset (90,69)
1911 B 1 Offset (70,60)
1911 B 1 Offset (55,52)
1911 B 1 Offset (35,45)
1911 B 1 Offset (15,39)
1911 B 1 Offset (1,35)
SelectRaise:
1911 B 1 A_RAISE
Loop
Deselect:
1911 B 0 A_PlaySound("AWAY", CHAN_WEAPON)
1911 B 1 Offset (1,35)
1911 B 1 Offset (15,39)
1911 B 1 Offset (35,45)
1911 B 1 Offset (55,52)
1911 B 1 Offset (70,60)
1911 B 1 Offset (90,69)
1911 B 1 Offset (105,89)
1911 B 1 Offset (125,102)
1911 B 1 Offset (155,108)
1911 B 1 Offset (155,150)
DeselectRaise:
1911 B 0 Offset (-1,0)
1911 B 1 A_Lower
Loop 
   
Fire:
TNT1 A 0 A_JumpIfInventory("PistolSupressor", 1 "FireSupressed") // go to special supressed fire state if needed
TNT1 A 0 A_AlertMonsters // this is where we'll end up if not supressed, this will wake up all monsters
1911 C 0 A_JumpIfNoAmmo("Reload")
1911 C 0 A_StartSound("1911FIR2",CHAN_AUTO)
1911 C 2 Bright A_FireProjectile("PistolTracer", FRandom(-0.6, 0.6), true, 0, 0, 0, FRandom(-2.0, 2.0))
1911 C 0 A_spawnitemex ("Casing", 34, 1, 27, random(1,6), random(1,8), random(1,9), 0)
1911 C 0 A_FireCustomMissile("GunSmokeSpawner",0,0,0,5)
1911 D 2 Bright A_SetPitch(pitch-0.3)
1911 E 1 A_SetPitch(pitch-0.3)
1911 F 1 A_SetPitch(pitch-0.8)
1911 G 1 A_SetPitch(pitch+0.8)
1911 B 0 A_SetPitch(pitch+0.3)
1911 B 0 A_SetPitch(pitch+0.3)
Goto Ready

FireSupressed: // you can change the first line to say 1 instead of "FireSupressed", if you don't care for a unique sequence. That'll just skip alerting monsters.
TNT1 A 0 A_JumpIfNoAmmo("Reload")
TNT1 A 0 A_StartSound("SUPPFIRE",CHAN_AUTO)
Goto Fire+4 // skips the suppresion check so we don't come back forever, skips alerting monsters, skips checking for reload (we do it here) and plays a different sound. If you want a unique firing sequence just remove this line and program it however you like.
 
Reload:
1911 B 0 A_JumpIfInventory("1911Loaded", 7, 2) // If the gun's full, jump 2 states.
1911 B 0 A_JumpIfInventory("1911Ammo", 1, "ReloadWork") // If there's extra ammo, reload.
1911 B 1 // Here's where that first line ends up - the gun does nothing and returns to Ready.
Goto Ready
ReloadWork:
1911 B 1 Offset(0,35)
1911 B 1 Offset(-2,38)
1911 B 0 A_PlaySound("1911MAG1",CHAN_AUTO)
1911 B 1 Offset(-4,44)
1911 B 1 Offset(-6,52)
1911 B 1 Offset(-1,54)
1911 B 6 Offset(-2,56)
1911 B 0 A_FireCustomMissile("PistolMagDrop",-5,0,8,-4)
1911 B 1 Offset(-1,54)
1911 B 1 Offset(-6,52)
1911 B 1 Offset(-4,44)
1911 B 0 A_PlaySound("1911MAG2",CHAN_AUTO)
1911 B 1 Offset(-2,38)
1911 B 1 Offset(0,35)
1911 B 1 Offset(0,35)
1911 B 1 Offset(-3,56)
1911 B 1 Offset(-3,56)
1911 B 1 Offset(-3,51)
1911 B 1 Offset(-3,53)
1911 B 1 Offset(0,35)
1911 B 1 Offset(0,35)
ReloadLoop:
1911 B 0 A_TakeInventory("1911Ammo", 1)
1911 B 0 A_GiveInventory("1911Loaded", 1)
1911 B 0 A_JumpIfInventory("1911Loaded", 7, "ReloadFinish")
1911 B 0 A_JumpIfInventory("1911Ammo", 1, "ReloadLoop")
Goto ReloadFinish
ReloadFinish:
1911 B 1 Offset(-3,57)
1911 B 1 Offset(-3,59)
1911 B 1 Offset(-3,63)
1911 B 1 Offset(-3,67)
1911 B 1 Offset(-3,65)
1911 B 0 A_PlaySound("1911UP",CHAN_AUTO)
1911 B 1 Offset(-3,62)
1911 B 1 Offset(-3,58)
1911 B 1 Offset(-3,55)
1911 B 1 Offset(-2,53)
1911 B 1 Offset(-2,49)
1911 B 1 Offset(-2,46)
1911 B 1 Offset(-2,45)
1911 B 1 Offset(-1,44)
1911 B 1 Offset(-1,46)
1911 B 1 Offset(-1,47)
1911 B 1 Offset(0,49) A_WeaponReady(WRF_NOBOB)
1911 B 1 Offset(0,44) A_WeaponReady(WRF_NOBOB)
1911 B 1 Offset(0,38) A_WeaponReady(WRF_NOBOB)
1911 B 1 Offset(0,35) A_WeaponReady(WRF_NOBOB)
1911 B 1 Offset(0,32) A_WeaponReady(WRF_NOBOB)
Goto Ready
Goto ready

AltFire:
TNT1 A 0 A_JumpIfInventory("PistolSupressor", 1 "UnSupress")
1911 B 1 A_GiveInventory("PistolSupressor")
TNT1 A 0 A_Print("Hey, add some cool animation here")
Goto Ready

UnSupress:
1911 B 1 A_TakeInventory("PistolSupressor")
TNT1 A 0 A_Print("Hey, add some cool animation here")
Goto Ready

}
}

ACTOR PistolSuppressor : Inventory { Inventory.MaxAmount 1 }

ACTOR 1911Loaded : Ammo
{
Inventory.MaxAmount 7
+IGNORESKILL
}

So in DECORATE we cannot use variables, we have to use dummy inventory items like PistolSupressor, which we give and take conditionally and perform actions based on them (A_JumpIfInventory).

So what I did here is when the user presses altfire, first check if they have PistolSupressor, this might not make sense, but remember you CANNOT check for a LACK of an item in DECORATE. If they DO NOT have the PistolSupressor item, we give it to them, then make the gun ready.
Then, when they press altfire again, our check for the PistolSupressor item succeeds, so we jump to the UnSupress state sequence, which takes the item, and readies the gun.

Then, when the player shoots, we check for the PistolSupressor. If the check succeeds (they suppressed the pistol), we go to FireSupressed and right now, we check for reloading, and then make a SUPPFIRE sound, then go back to the regular firing sequence, but we SKIP 4 FRAMES, otherwise, we'd shoot forever. If you want to make a unique firing sequence remove the Goto Fire+4 line and program it as if it were Fire:.

But if the check fails, we DO NOT jump and call A_AlertMonsters which will alert monsters. I added +WEAPON.NOALERT so that the suppressed fire doesn't alert automatically.

Also, I just realized I spelled suppressed wrong in the code, sorry! I hope this helps though!

yum13241 wrote: ↑Sun Sep 01, 2024 8:16 am So in DECORATE we cannot use variables...

How... far back are you in DECORATE knowledge, buddy?

Not too far back. Nobody uses DECORATE "variables" because you can only modify them with A_SetUserVar. In weapons, it must be defined in the player. In CustomInventory, it must be defined by the holder.

I can guarantee you that almost all DECORATE mods are made in DECORATE for Zandronum usage, which does not have this feature. Also, if other ports get DECORATE (some cut down version of it lol), they are unlikely to port this feature, as otherwise, all ports would basically become ZDoom, and not a lot of port authors would like that.

I was just providing a solution that works in most ports, as a GZDoom-only DECORATE mod is pointless, as you may as well use what ZScript has to offer. DECORATE in its entirety will become almost-pointless once GZDoom: C/S Edition finally becomes a thing (there's a branch for it on the official Git repo), except for maybe PlayerPawns, as you can force compatibility with other player-modifiying mods with some hacks.

How far back are you in ZScript knowledge, buddy?

I don't use ZScript, buddy. User Variables for Actors existed since 2009. Zandronum supports it. DECORATE authors use it, because I use it for my personal project. I can tell you that Zandronum isn't crashing at the User Variables, but rather frandompick... so much for having a DECORATE only mod that works on Zandronum. And, I believe I brought up your very comment about ZScript on another thread:

DECORATE right now is a deprecated feature set and anyone who looks to use it is ushered to the "How to ZScript" pages.

Why do people code in DECORATE even though ZScript exists? Because we're comfortable with it. I am not a C-style programmer. I brute-forced my way to understanding DECORATE because I wanted to make mods and I had a good teacher to help me on the way. I'm only bringing up the fact that User Variables exist. Yes, they need to be defined on the PlayerPawn. This is fine and is a perfectly acceptable alternative to using CustomInventory actors. Weapons can modify the PlayerPawn's variable. If it's something as simple as checking to see if a weapon is suppressed, I'd be fine with using User Variables - and we should encourage others to broaden their horizons beyond making even more CustomInventory actors where as a User Var can fill in to simply ask "Hey, do I jump to this state if my weapon is suppressed?" The rest of your code, I see no problems with.

Could this be simplier with ZScript? Sure. But he's using DECORATE. Let him have fun with it.

Now, some tips for the 1911 suppressing feature: Things get a little hairy when it comes to selecting and deselecting. You will have to account that the weapon will be suppressed or not suppressed. So there will be a lot of jumping around (Select.Suppressed/Select.UnSuppressed) states for an example. But it seems that you, Graaicko, have the basic concepts down so far. Don't hesitate to experiment. Broken code and headscratching is part of the fun.

Hellser wrote: Now, some tips for the 1911 suppressing feature: Things get a little hairy when it comes to selecting and deselecting. You will have to account that the weapon will be suppressed or not suppressed. So there will be a lot of jumping around (Select.Suppressed/Select.UnSuppressed) states for an example. But it seems that you, Graaicko, have the basic concepts down so far. Don't hesitate to experiment. Broken code and headscratching is part of the fun.

Only if it's going to actually have a silencer attached in its sprites.

Hellser wrote: Could this be simplier with ZScript? Sure. But he's using DECORATE. Let him have fun with it.

Playing online is part of the fun, lol.

Hellser wrote: I am not a C-style programmer

Neither am I. And btw, DECORATE is also C-styled, because otherwise we'd have semantic whitespace instead of curly braces. It borrows a lot more from C than what you realize, buddy.

Hellser wrote: using CustomInventory actors

Actually, we're using regular Inventory here. CustomInventory is not needed and should only be used in DECORATE. In ZScript, the idiosyncrasies make it not worth it over just overriding TryPickup().

Hellser wrote: DECORATE right now is a deprecated feature set and anyone who looks to use it is ushered to the "How to ZScript" pages.

You said that, not me, lol. (Rachael quoted you, not me, lol) search.php?keywords=++++DECORATE+right+ ... sf=msgonly

And you can only GetUserVariable through ACS, if you don't need to A_JumpIf Other than that, it's great to learn that variables kinda exist. You can ONLY set them though, not add/subtract/divide/multiply/square root/whatever AFAIK.