Relighting v4.0165b - blurry shadows w/ rlassets

[Hey Doomer_]

Progress v4.0164b

Something is broken in the shadow code, which was faster and smoother in earlier versions. Investigating and will post a hotfix as soon as I find it.

Edit

Found it and posted a hotfix with the code commented out. It's a lifespan counter for the hd_light actor. I'm not quite sure why that should affect shadows; I suspect it is because Tick() is linked to State, but I'm guessing. This hotfix makes shadow animation, noticeable for example when imps are firing impballs in the nukage pit room of E1M1, much smoother.

Possibly this addresses this concern.

[cortes2k]

Hi there.
Doeas anybody uses Brutal Doom Platinum?
Crashes from relighting 4.0160b to 401631b moustly when barrel explodes. No problems with 40159b and previous.

https://imgur.com/a/wafgPlS

Dude...
When moving, shadows moving so smoth... sweet, looks great!

https://imgur.com/a/9kNqRJu

[Hey Doomer_]

Hi there.
Doeas anybody uses Brutal Doom Platinum?
Crashes from relighting 4.0160b to 401631b moustly when barrel explodes. No problems with 40159b and previous.

https://imgur.com/a/wafgPlS

Dude...
When moving, shadows moving so smoth... sweet, looks great!

https://imgur.com/a/9kNqRJu

Your crash may not be related to the mod. See this thread. Are you using a dev build of GZDoom?

Thanks for the comments!! Those shadows look pretty cool.

[Xanirus]

I don't know if this is a bug or something I can just toggle off in the settings. (I'm running at the performance preset.) I found a slight issue with version 4.01631b and the current master version of Project Brutality 3.0 from the github. (Not the pb_staging version, I have no idea/forgot how I came across that version. I swear I clicked on stable and it gave me pb_staging instead of pb_master where the HUD looks completely different, but glad I found the supposedly stable version as the other keeps crashing semi randomly whenever an enemy gets hit.)

I found that using the railgun combined with this mod makes the game briefly pause for just a fraction of a second whenever you fire it. I had a lot of mods, but I narrowed it down to this one and just PB and nothing else. I think it kind of makes sense? (The fact that it's this mod doing it, but not why it happens.) When you fire the railgun there is a lot of lights coming out of the gun that fill up the screen, so I would expect Relighting to do something when there's a bunch of bright lights in your face at point blank range. (I never tried this in the pb_staging version for what it's worth, I was playing normally and never got far enough to get a railgun to notice due to the crashes.)

However, the freeze is visual only, the game actually still runs for that brief fraction of a second: If I strafe and fire, but continue to hold the strafe button down during the freeze, I will be where I'd expect to be after the freeze ends. It's basically acting like a lagspike, only I'm offline and and I can trigger it deliberately. This happens even in the most basic of maps that load quickly such as right at the beginning of Map 01 in Doom2.

I first noticed this when I was downloading and testing the weapon addons for PB, mainly the gauss cannon. When I was testing it out, this is when I noticed the freeze, but then I noticed the standard PB railgun was doing it too. That's when I started narrowing down the mods. If I use any other mods or just PB by itself, it doesn't do the freeze.

UPDATE: Okay, this is happening to a lot of weapons it seems.

[cortes2k]

Hey Doomer_ wrote:
> [quote=cortes2k post_id=1241539 time=1685945291 user_id=37989]
> Hi there.
> Doeas anybody uses Brutal Doom Platinum?
> Crashes from relighting 4.0160b to 401631b moustly when barrel
> explodes. No problems with 40159b and previous.
>
> https://imgur.com/a/wafgPlS
>
> Dude...
> When moving, shadows moving so smoth... sweet, looks great!
>
> https://imgur.com/a/9kNqRJu
> [/quote]
>
> Your crash may not be related to the mod. See
> [url=viewtopic.php?p=1235783#p1235783]this[/url]
> thread. Are you using a dev build of GZDoom?
>
> Thanks for the comments!! Those shadows look pretty cool.

I use regular version 4.10.0
I noticed more people have the same problem. viewtopic.php?t=77427
And I have something more weird. I have disabled every option of each menu and stil crashes https://imgur.com/a/iMJc9Ai
I leaved only relighting and brutal doom platinum activated and crashes. I have tested with, Brutal Doom Black Edition, Project Brutality, Hellrider and ver. 4 works great, only crashes with Platinum, I think there is some conflict issue (wanna cry).
If I use relighting 3.31 platinum goes smooth.

Cheers

[Hey Doomer_]

However, the freeze is visual only, the game actually still runs for that brief fraction of a second: If I strafe and fire, but continue to hold the strafe button down during the freeze, I will be where I'd expect to be after the freeze ends. It's basically acting like a lagspike, only I'm offline and and I can trigger it deliberately. This happens even in the most basic of maps that load quickly such as right at the beginning of Map 01 in Doom2.

I first noticed this when I was downloading and testing the weapon addons for PB, mainly the gauss cannon. When I was testing it out, this is when I noticed the freeze, but then I noticed the standard PB railgun was doing it too. That's when I started narrowing down the mods. If I use any other mods or just PB by itself, it doesn't do the freeze.

UPDATE: Okay, this is happening to a lot of weapons it seems.

Relighting doesn't do anything with weapons or the HUD, so this is interesting. It does recognize missile actors that are spawned, but I don't remember that being the case in BD variants. I'll check it out!

[Hey Doomer_]

I use regular version 4.10.0
I noticed more people have the same problem. viewtopic.php?t=77427
And I have something more weird. I have disabled every option of each menu and stil crashes https://imgur.com/a/iMJc9Ai
I leaved only relighting and brutal doom platinum activated and crashes. I have tested with, Brutal Doom Black Edition, Project Brutality, Hellrider and ver. 4 works great, only crashes with Platinum, I think there is some conflict issue (wanna cry).
If I use relighting 3.31 platinum goes smooth.

Cheers

It seems that C0000005 errors are engine related, but I'll check it out. I haven't seen problems with BD and variants in my limited testing.

[cortes2k]

Hey Doomer_ wrote:
> [quote=cortes2k post_id=1241625 time=1686216375 user_id=37989]
>
>
> I use regular version 4.10.0
> I noticed more people have the same problem.
> viewtopic.php?t=77427
> And I have something more weird. I have disabled every option of each menu
> and stil crashes https://imgur.com/a/iMJc9Ai
> I leaved only relighting and brutal doom platinum activated and crashes. I
> have tested with, Brutal Doom Black Edition, Project Brutality, Hellrider
> and ver. 4 works great, only crashes with Platinum, I think there is some
> conflict issue (wanna cry).
> If I use relighting 3.31 platinum goes smooth.
>
> Cheers
> [/quote]
>
> It seems that C0000005 errors are engine related, but I'll check it out. I
> haven't seen problems with BD and variants in my limited testing.

The weirdest thing is that only crash with platinum edition.
I decided to check the gzdoom engine, so, I ran the gzdoom in windows 8 compatibility mode and has no charashes, unfortunately there is an issue with performance, fps goes down but in general, works fine, no crashes.
Thank you for your effort in this project.

Dude I have a question.
Do you remember my comparison images with relighting 3 and 4?
https://imgur.com/a/qq5FVg0
I noticed there is no light in this kind of texture, this image is from doom E1M3. Why doesn't this type of texture have light in relighting 4? There is more textures like this in E1M1 and no lights too. It looks weird, like the bulbs are out.

Cheers

[SaucepanSF]

I use regular version 4.10.0
I noticed more people have the same problem. viewtopic.php?t=77427
And I have something more weird. I have disabled every option of each menu and stil crashes https://imgur.com/a/iMJc9Ai
I leaved only relighting and brutal doom platinum activated and crashes. I have tested with, Brutal Doom Black Edition, Project Brutality, Hellrider and ver. 4 works great, only crashes with Platinum, I think there is some conflict issue (wanna cry).
If I use relighting 3.31 platinum goes smooth.

Cheers

It seems that C0000005 errors are engine related, but I'll check it out. I haven't seen problems with BD and variants in my limited testing.

Can confirm I get a similar random crash with this error.

Some notes:
- I primarily use Brutal Doom Tomtefar's Extension, but have seen the crash with limited use of Led's Generic as well.
- I use a plethora of addons, but can confirm the crashes will happen with ONLY BD/Led's enabled.
- I don't recall it crashing on vanilla Doom, without any mods. I should test this.
- crash happened on my old system (RTX 3070/i7 i forget speed), as well as the new one (RTX 4070-ti/i7 10700) using the same GZDOOM ini file. I transferred it over when I upgraded. Could be a clue.
- Relighting v3 does NOT crash ever. It's ONLY v4, and I've tried several different releases including the latest one.
- Crashes don't always happen. It's random. Sometimes I can make it through an entire level.
- Crashes happen on og DOOM.wad/DOOM2.wad as well as community maps.

Hope you find a fix because this mod is legit one of the most amazing addons for any game I've ever seen. My game is transformed using this mod. You are a true wizard/legend.

[Hey Doomer_]

Can confirm I get a similar random crash with this error, with or without mods.

Hope you find a fix because this mod is legit one of the most amazing addons for any game I've ever seen. You are a true wizard.

Thanks!

This cpp (not ZScript) error is caused by a memory access violation; either a pointer no longer exists, memory has been deallocated or reallocated, an illegal subscript is being used, etc. That's why it doesn't have anything to do with mod coding per se. I don't know enough about GZDoom to troubleshoot this (not one of the devs), but I have some ideas regarding ZScript that may affect game pointers. I'll check this out.

[Hey Doomer_]

Can confirm I get a similar random crash with this error, with or without mods.

Hope you find a fix because this mod is legit one of the most amazing addons for any game I've ever seen. You are a true wizard.

Thanks!

This cpp (not ZScript) error is caused by a memory access violation; either a pointer no longer exists, memory has been deallocated or reallocated, an illegal subscript is being used, etc. That's why it doesn't have anything to do with mod coding per se. I don't know enough about GZDoom to troubleshoot this (not one of the devs), but I have some ideas regarding ZScript that may affect game pointers. I'll check this out.

Edit

Seems unrelated to Relighting's thinkers, and I don't see any patterns with OpenGL or Vulkan. Without knowing more, it's hard to say what causes these errors. I'll ponder this some more, but I suspect it's in the engine code.

[cortes2k]

Hey Doomer_ wrote:
> [quote=SaucepanSF post_id=1241710 time=1686512107 user_id=35354]
> Can confirm I get a similar random crash with this error, with or without
> mods.
>
> Hope you find a fix because this mod is legit one of the most amazing
> addons for any game I've ever seen. You are a true wizard.
> [/quote]
>
> Thanks!
>
> This cpp (not ZScript) error is caused by a memory access violation; either
> a pointer no longer exists, memory has been deallocated or reallocated, an
> illegal subscript is being used, etc. That's why it doesn't have anything
> to do with mod coding per se. I don't know enough about GZDoom to
> troubleshoot this (not one of the devs), but I have some ideas regarding
> ZScript that may affect game pointers. I'll check this out.


Thank you for your feedback. I think is not a relighting error per se as you said, but combination of bd platinum and newer relighting causes the error. Previous version of 4.0160b has no problems. May be this give you a clue.

Cheers

[cortes2k]

Dude... I have to tell you.
I tested again but not using release 4.10.0, I used 4.11 beta and have no crashes using Platinum Edition and Last Relighting version. Access violation was because the version of gzdoom.
Keep up the good work.

[Hey Doomer_]

Hey Doomer_ wrote:
>

> Can confirm I get a similar random crash with this error, with or without
> mods.
>
> Hope you find a fix because this mod is legit one of the most amazing
> addons for any game I've ever seen. You are a true wizard.
>

>
> Thanks!
>
> This cpp (not ZScript) error is caused by a memory access violation; either
> a pointer no longer exists, memory has been deallocated or reallocated, an
> illegal subscript is being used, etc. That's why it doesn't have anything
> to do with mod coding per se. I don't know enough about GZDoom to
> troubleshoot this (not one of the devs), but I have some ideas regarding
> ZScript that may affect game pointers. I'll check this out.


Thank you for your feedback. I think is not a relighting error per se as you said, but combination of bd platinum and newer relighting causes the error. Previous version of 4.0160b has no problems. May be this give you a clue.

Cheers

Nothing I can do in Relighting, unfortunately. However I don't get the error with the latest GZDoom dev build. You can try that. Other than that I don't have any ideas. Almost everything Relighting does is in WorldLoaded. Other than that there are shadow thinkers that should not cause problems.

My impression of ZScript is that it runs inside a virtual environment that generates its own exceptions. There are few and insignificant changes between 160 and 1631, and in any case nothing that generates a ZScript error. I've no explanation for why these versions interact differently with BD platinum. This is almost certainly a GZDoom build issue that has possibly been resolved in one of the dev builds. Relighting does use the PitchTo function and has to be run on at least 4.10. Hope that helps!

[Hey Doomer_]

Dude... I have to tell you.
I tested again but not using release 4.10.0, I used 4.11 beta and have no crashes using Platinum Edition and Last Relighting version. Access violation was because the version of gzdoom.
Keep up the good work.

Yep I agree