[0.10.6] Gun Bonsai -- everything-compatible weapon upgrading

Projects that alter game functions but do not include new maps belong here.
Forum rules
The Projects forums are only for projects. If you are asking questions about a project, either find that project's thread, or start a thread in the General section instead.

Got a cool project idea but nothing else? Put it in the project ideas thread instead!

Projects for any Doom-based engine (especially 3DGE) are perfectly acceptable here too.

Please read the full rules for more details.
Gourry
Posts: 117
Joined: Tue Dec 05, 2017 4:25 pm
Graphics Processor: nVidia (Modern GZDoom)

Re: [0.10.6] Gun Bonsai -- everything-compatible weapon upgrading

Post by Gourry »

No error code but still having issues with aggressive defense. Game still freezes on gzdoom 4.11.3 and older when there are too many bullets or graphics on level.

Edit: Sometimes just randomly freeze as well when shooting with weapon that has aggressive defense.
Last edited by Gourry on Fri Jan 12, 2024 12:58 am, edited 1 time in total.
User avatar
TheVanessii
Posts: 18
Joined: Mon Feb 22, 2021 5:44 pm
Preferred Pronouns: She/Her
Graphics Processor: nVidia (Modern GZDoom)

Re: [0.10.6] Gun Bonsai -- everything-compatible weapon upgrading

Post by TheVanessii »

Dan_The_Noob wrote: Sun Jan 07, 2024 4:55 am
TheVanessii wrote: Sat Jan 06, 2024 10:46 pm Hahaha, this mod is pure chaos. Anyone playing I recommend having 10.5x on your game & bump up the enemy count every so often. Reaches absurd levels
sounds like you need corruption cards and a good horde deck, for a nice progressive curve of chaos
I use corruption cards on different setups but not the one I got currently, as it's a tad bit too silly. Though a billion bouncing grenades all over the stage does have bits of silliness, it doesn't breach into spawning chickens & moonwalking enemies territory XD
User avatar
Dan_The_Noob
Posts: 872
Joined: Tue May 07, 2019 12:24 pm
Graphics Processor: nVidia with Vulkan support

Re: [0.10.6] Gun Bonsai -- everything-compatible weapon upgrading

Post by Dan_The_Noob »

TheVanessii wrote: Mon Jan 08, 2024 2:20 am
Dan_The_Noob wrote: Sun Jan 07, 2024 4:55 am
TheVanessii wrote: Sat Jan 06, 2024 10:46 pm Hahaha, this mod is pure chaos. Anyone playing I recommend having 10.5x on your game & bump up the enemy count every so often. Reaches absurd levels
sounds like you need corruption cards and a good horde deck, for a nice progressive curve of chaos
I use corruption cards on different setups but not the one I got currently, as it's a tad bit too silly. Though a billion bouncing grenades all over the stage does have bits of silliness, it doesn't breach into spawning chickens & moonwalking enemies territory XD
try this one (load after corrution cards in load order)
Corruption-HordeFunPack1.pk3
You do not have the required permissions to view the files attached to this post.
User avatar
TheVanessii
Posts: 18
Joined: Mon Feb 22, 2021 5:44 pm
Preferred Pronouns: She/Her
Graphics Processor: nVidia (Modern GZDoom)

Re: [0.10.6] Gun Bonsai -- everything-compatible weapon upgrading

Post by TheVanessii »

Dan_The_Noob wrote: Mon Jan 08, 2024 3:10 am
TheVanessii wrote: Mon Jan 08, 2024 2:20 am
Dan_The_Noob wrote: Sun Jan 07, 2024 4:55 am

sounds like you need corruption cards and a good horde deck, for a nice progressive curve of chaos
I use corruption cards on different setups but not the one I got currently, as it's a tad bit too silly. Though a billion bouncing grenades all over the stage does have bits of silliness, it doesn't breach into spawning chickens & moonwalking enemies territory XD
try this one (load after corrution cards in load order)
Corruption-HordeFunPack1.pk3
No thanks! I already have what I need, I like having full control over my enemy count
User avatar
stainedofmind
Posts: 117
Joined: Sun Sep 01, 2019 10:59 am

Re: [0.10.5] Gun Bonsai -- everything-compatible weapon upgrading

Post by stainedofmind »

ToxicFrog wrote: Wed Jan 03, 2024 2:37 pm
stainedofmind wrote: Fri Dec 29, 2023 2:57 pm So, update on ammo reserves instead of Bandoliers, I managed to get it working a little better, at least so it doesn't completely break when clips/reloading is involved (only tested with Brutal Doom in this case). I borrowed code from Ammo Leech to determine what qualifies as a legitimate ammo type, but it's still definitely not perfect. Best example I've run into so far is with Hell Crusher and the secondary fire for the Plasma Rifle, which builds up heat as you fire. This might benefit from a special section to the BONSAIRC lump, or a similar one, that the user/author can specify which ammo types are/aren't valid. It definitely feels like it works good overall though. I might clean it up a bit and post it here if anyone wants to mess around with it
Please do (and let me know if you're ok with it being incorporated into GB).
Here it is! You can definitely add it to the main GunBonsai files if you wish, though I'm sure you'll want to clean up the mess I left of it... Mostly the HUD display, which is a gross hack because I was tired of messing with data scoping.

Things to note about the addon, one, the HUD is very basic, and due to how its coded, is NOT multiplayer friendly (which the entire thing might not be... I'm not great with MP compatibility). Second, there's almost no sanity checks for the main three settings, specifically, ammo reserve size per level, and the siphon/restoking percentages not making any sense. The only thing in place is a simple check, which triggers if the siphon threshold is equal to or less then the restocking threshold. This was done to prevent any runaway siphon/restock loops for ammo capacities that are extremely low. All it does is simply ignore that ammo type for checking quantities. I didn't implement any lump reading for customizing what qualifies as a "valid" ammo type for reserves, so there may still be some wonkiness for certain mods. There's no way to see ammo reserves for weapons you don't have, or don't currently have ready, and any ammo in a reserve pool cannot be recovered except through draining your primary ammo amount below the restocking threshold. Can't think of any other issues off the top of my head. Have at it!

Edit: Forgot to mention, this does NOT disable Bandoliers by default, just in case you wanna mess around with both of them activated, cause it SHOULD support that, didn't test it though.
You do not have the required permissions to view the files attached to this post.
User avatar
Major Cooke
Posts: 8174
Joined: Sun Jan 28, 2007 3:55 pm
Preferred Pronouns: He/Him
Location: QZDoom Maintenance Team

Re: [0.10.6] Gun Bonsai -- everything-compatible weapon upgrading

Post by Major Cooke »

Okay, so looking over your code, it would appear all I'd have to do is get your service and call the two GetDouble functions with those parameters, correct?

Also I completely forgot ZJSON is a thing, which could make things even easier on you and modders going forward so people don't have to learn ZScript in order to implement it.

Had I recalled that sooner I would've recommended it to you, BUT... Having the service class is still a boon because it allows for dynamic assigning of exp during run time. Just my suggestion is all.

I don't blame you if you decide not to add it until a later date.
User avatar
MsrSgtShooterPerson
Posts: 50
Joined: Thu Jan 02, 2020 1:59 am
Location: Lost in the procedural infinite hells and I'm fine with that.

Re: [0.10.6] Gun Bonsai -- everything-compatible weapon upgrading

Post by MsrSgtShooterPerson »

Hey, Toxic! Just wanted to report I seem be having an issue on 1.0.6 - this error seems to show up whenever I:
* Recieve a player upgrade when upgrade count is set to 1
* Reach the player upgrade threshold even if player upgraded are disabled
* Open the menu for upgrades if I have leveled enough guns for a player upgrade:

Here's a screenshot of the log:
https://imgur.com/a/2wNTgwE

I'm playing with a bunch mods starting with Pandemonium 2.4.1 and Corruption Cards 5.5 - this error didn't occur while I was still previously on GunBonsai 0.10.4 :D

For now my solution is to just ignore the upgrade menu since I mostly play on 1 upgrade choice per gun level recently
User avatar
DoomThing445
Posts: 31
Joined: Wed Jun 01, 2022 3:25 am
Preferred Pronouns: He/Him
Operating System Version (Optional): Windows 10
Graphics Processor: ATI/AMD (Modern GZDoom)

Re: [0.10.6] Gun Bonsai -- everything-compatible weapon upgrading

Post by DoomThing445 »

It crashes on startup when trying to load Brutal Doom Platinum 3.1.1.
"VM execution aborted: string format failed. Expected a string for format %s."
I've tried BDP without Gun Bonsai in my normal game setup.
User avatar
DoomThing445
Posts: 31
Joined: Wed Jun 01, 2022 3:25 am
Preferred Pronouns: He/Him
Operating System Version (Optional): Windows 10
Graphics Processor: ATI/AMD (Modern GZDoom)

Re: [0.10.6] Gun Bonsai -- everything-compatible weapon upgrading

Post by DoomThing445 »

I'd also like to state through experimentation that you can vm abort the game just by having tons of upgrades. I have no idea what causes this, nor do I know if you intend to fix it.

https://streamable.com/w3gf7g
User avatar
devlman127
Posts: 49
Joined: Sun Nov 03, 2019 9:56 am

Re: [0.10.6] Gun Bonsai -- everything-compatible weapon upgrading

Post by devlman127 »

I think the upgrades should be clearer on what explosives cause self-damage. While the exploding enemies upgrade says it's explosions deal -50% self damage, that's not the case with the bouncing bombs and explosive rounds upgrades, which deal no and full self damage respectively.
Also, While playing with Arachnophobia, I noticed that when upgrading weapons with it's upgrade system they lose all their experience. This happens even with the least restrictive "weapon class" option. Is it possible to have an option to apply the upgrades to the weapon slot (i.e. super shotgun slot, plasma rifle slot) so upgraded weapons don't lose their levels?
User avatar
AliciaPendragon
Posts: 155
Joined: Wed Jun 07, 2023 8:46 am
Preferred Pronouns: She/Her
Operating System Version (Optional): Windows 10
Location: Gensokyo

Re: [0.10.6] Gun Bonsai -- everything-compatible weapon upgrading

Post by AliciaPendragon »

Enjoying the latest update, two things though

1. Is there a way to have the gun bonsai effects get blacklisted or whitelisted from War Trophies so if monsters are killed by the acid or poison, they dont show up in the list

2. For Angelic Aviary, it has its own drops from opponents that can be enabled known as angelic shards. Is there a way to have scavange steel and scavange blood also drop the angelic shards whenever I use Angelic Aviary and Gun Bonsai together? That way they're both synced up?
User avatar
stainedofmind
Posts: 117
Joined: Sun Sep 01, 2019 10:59 am

Re: [0.10.6] Gun Bonsai -- everything-compatible weapon upgrading

Post by stainedofmind »

AliciaPendragon wrote: Sat Mar 02, 2024 10:58 pm Enjoying the latest update, two things though

1. Is there a way to have the gun bonsai effects get blacklisted or whitelisted from War Trophies so if monsters are killed by the acid or poison, they dont show up in the list

2. For Angelic Aviary, it has its own drops from opponents that can be enabled known as angelic shards. Is there a way to have scavange steel and scavange blood also drop the angelic shards whenever I use Angelic Aviary and Gun Bonsai together? That way they're both synced up?
Can't help you with #1, but #2 can be achieved with a small addon. I've never used Angelic Aviary myself, but after a quick test run, I slapped together a quick patch for you. For it to work with the angelic shards, you need to have GB set to use Built-In actors. It does also mess with the order of the player upgrades list due to how the BONSAIRC lump works, but its purely cosmetic. Did a quick test run and it seems to be working as intended, if not, let me know! Load after GunBonsai.
You do not have the required permissions to view the files attached to this post.
User avatar
AliciaPendragon
Posts: 155
Joined: Wed Jun 07, 2023 8:46 am
Preferred Pronouns: She/Her
Operating System Version (Optional): Windows 10
Location: Gensokyo

Re: [0.10.6] Gun Bonsai -- everything-compatible weapon upgrading

Post by AliciaPendragon »

stainedofmind wrote: Wed Mar 06, 2024 10:50 pm
AliciaPendragon wrote: Sat Mar 02, 2024 10:58 pm Enjoying the latest update, two things though

1. Is there a way to have the gun bonsai effects get blacklisted or whitelisted from War Trophies so if monsters are killed by the acid or poison, they dont show up in the list

2. For Angelic Aviary, it has its own drops from opponents that can be enabled known as angelic shards. Is there a way to have scavange steel and scavange blood also drop the angelic shards whenever I use Angelic Aviary and Gun Bonsai together? That way they're both synced up?
Can't help you with #1, but #2 can be achieved with a small addon. I've never used Angelic Aviary myself, but after a quick test run, I slapped together a quick patch for you. For it to work with the angelic shards, you need to have GB set to use Built-In actors. It does also mess with the order of the player upgrades list due to how the BONSAIRC lump works, but its purely cosmetic. Did a quick test run and it seems to be working as intended, if not, let me know! Load after GunBonsai.
Thank you so much!
User avatar
stainedofmind
Posts: 117
Joined: Sun Sep 01, 2019 10:59 am

Re: [0.10.6] Gun Bonsai -- everything-compatible weapon upgrading

Post by stainedofmind »

AliciaPendragon wrote: Sat Mar 02, 2024 10:58 pm Enjoying the latest update, two things though

1. Is there a way to have the gun bonsai effects get blacklisted or whitelisted from War Trophies so if monsters are killed by the acid or poison, they dont show up in the list

2. For Angelic Aviary, it has its own drops from opponents that can be enabled known as angelic shards. Is there a way to have scavange steel and scavange blood also drop the angelic shards whenever I use Angelic Aviary and Gun Bonsai together? That way they're both synced up?
I lied, I fixed #1 as well. I'm assuming you were specifically referring to the "damage-over-time" effects of both elements, so I slapped a patch together for that. If there were other effects that need blacklisted, it would be pretty easy to add more. Also note that as stated in the War Trophies manual, this will not erase any existing stats, but will prevent further ones.
AliciaPendragon wrote: Thu Mar 07, 2024 12:38 pm Thank you so much!
You're welcome!
You do not have the required permissions to view the files attached to this post.
User avatar
AliciaPendragon
Posts: 155
Joined: Wed Jun 07, 2023 8:46 am
Preferred Pronouns: She/Her
Operating System Version (Optional): Windows 10
Location: Gensokyo

Re: [0.10.6] Gun Bonsai -- everything-compatible weapon upgrading

Post by AliciaPendragon »

stainedofmind wrote: Fri Mar 08, 2024 5:49 pm
AliciaPendragon wrote: Sat Mar 02, 2024 10:58 pm Enjoying the latest update, two things though

1. Is there a way to have the gun bonsai effects get blacklisted or whitelisted from War Trophies so if monsters are killed by the acid or poison, they dont show up in the list

2. For Angelic Aviary, it has its own drops from opponents that can be enabled known as angelic shards. Is there a way to have scavange steel and scavange blood also drop the angelic shards whenever I use Angelic Aviary and Gun Bonsai together? That way they're both synced up?
I lied, I fixed #1 as well. I'm assuming you were specifically referring to the "damage-over-time" effects of both elements, so I slapped a patch together for that. If there were other effects that need blacklisted, it would be pretty easy to add more. Also note that as stated in the War Trophies manual, this will not erase any existing stats, but will prevent further ones.
AliciaPendragon wrote: Thu Mar 07, 2024 12:38 pm Thank you so much!
You're welcome!
Thank you for this as well! You're the best!

Return to “Gameplay Mods”