NoTrim option isn't recognized

[Jekyll Grim Payne]

NoTrim is a TEXTURES flag and an ANIMDEFS keyword that was added following my suggestion.

It doesn't seem to work at all. I tried it yesterday on g4.8pre-321-gecc0afd2f.

If specified in TEXTURES it produces no visible effect, and if I try to add it via ANIMDEFS (which should be possible according to this https://zdoom.org/wiki/ANIMDEFS#Other), it actually produces a "bad syntax" error, so it doesn't seem to be recognized at all.

I don't feel an example is particularly necessary but I made one anyway.

TEXTURES issue: I made a pistol version with PISGF0 sprite that has empty canvas twice as tall as the sprite itself. It's continuously rotated at the center, which should be the iron sight given the empty canvas, but it's rotated around the graphic's center instead.

ANIMDEFS issue: uncomment the "Notrim PISGF0" line in ANIMDEFS, and GZDoom won't start.

[Blue Shadow]

This commit seems to have reverted a change related to this feature.

As for the ANIMDEFS error, either the wiki is wrong, or the feature was implemented in the wrong place. As it stands, it requires that a texture animation definition is created:

Code: Select all

texture PISGF0 NoTrim

[Graf Zahl]

This commit seems to have reverted a change related to this feature.

What part?`

[Blue Shadow]

The bit in gametexture.cpp.

[Jekyll Grim Payne]

This commit seems to have reverted a change related to this feature.

As for the ANIMDEFS error, either the wiki is wrong, or the feature was implemented in the wrong place. As it stands, it requires that a texture animation definition is created:

Code: Select all

texture PISGF0 NoTrim

I amended the wiki entry, and the new syntax seems at least recognized (I'm rather confused that it seems to require the word "texture" regardless of the actual namespace of the graphic, though).

So, I assume this was reverted by accident?

[Graf Zahl]

Yes. It happened when I made a backend sync between Raze and GZDoom and copied in the wrong direction.
Regarding the keyword, this was a PR, so apparently this was overlooked.

[Blue Shadow]

(I'm rather confused that it seems to require the word "texture" regardless of the actual namespace of the graphic, though).

To clarify, as it's currently implemented, NoTrim is a command of a [wiki=ANIMDEFS#Animated_graphics]texture animation definition[/wiki], such as ALLOWDECALS.