[4.8-d05ea19] Pink hued textures with material textures

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
grahf78
Posts: 24
Joined: Sun Jun 21, 2020 10:11 pm
Graphics Processor: nVidia (Modern GZDoom)

[4.8-d05ea19] Pink hued textures with material textures

Post by grahf78 »

Textures have a strong pinkish hue when they have PBR materials and brightmaps associated to them. See screenshots below.

The issue does not happen in gzdoom 4.7.1, nor with the other renderers. Attached a reproducible sample.

4.8.0-pre:



4.7.1:

You do not have the required permissions to view the files attached to this post.
Last edited by grahf78 on Tue Apr 05, 2022 8:35 pm, edited 1 time in total.
User avatar
Enjay
 
 
Posts: 26441
Joined: Tue Jul 15, 2003 4:58 pm
Location: Scotland

Re: [4.8-d05ea19] Pink hued textures with material textures

Post by Enjay »

I can't run your example. I get:

Code: Select all

**** DIED WITH FATAL ERROR:
Shader 'test' could not be linked:
ERROR: Linking fragment stage: No function definition (body) found: 
    Process(vf4;
grahf78
Posts: 24
Joined: Sun Jun 21, 2020 10:11 pm
Graphics Processor: nVidia (Modern GZDoom)

Re: [4.8-d05ea19] Pink hued textures with material textures

Post by grahf78 »

My previous sample only worked with the GLES renderer. I've updated it to also work with Vulkan/OpenGL.
User avatar
Enjay
 
 
Posts: 26441
Joined: Tue Jul 15, 2003 4:58 pm
Location: Scotland

Re: [4.8-d05ea19] Pink hued textures with material textures

Post by Enjay »

Ah right. I assumed from when you mentioned "other renderers" it should start in them all. With the new sample, I can confirm that on my RTX 2060, the sample is pink in GLES and white in Vulkan with g4.8pre-273-gd05ea1965 and also white in GLES in 4.7.1.
emile_b
Posts: 106
Joined: Sun Sep 22, 2019 7:06 am
Graphics Processor: nVidia (Modern GZDoom)

Re: [4.8-d05ea19] Pink hued textures with material textures

Post by emile_b »

OK I found the issue, the problem is gl_customshader can be true in GLES now due to this commit:
https://github.com/coelckers/gzdoom/com ... b62a9deea4

So the mShaderIndex gets set to a custom shader which the GLES backend does not know what to do with.

I suppose the question is should gl_customshader be CVAR_ARCHIVE? Does it need to be saved and is it expected to ever be used by the user?
User avatar
Rachael
Admin
Posts: 13211
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her

Re: [4.8-d05ea19] Pink hued textures with material textures

Post by Rachael »

The intent was to allow the user to turn off shaders when they get too heavy for a system even on Vulkan/OpenGL. It's possible to overload shader clocks on older GL 4.x systems very easily.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 48543
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [4.8-d05ea19] Pink hued textures with material textures

Post by Graf Zahl »

Yeah, but you can't do it like this. There's code depending on that CVAR that may not run in GLES mode.
User avatar
Rachael
Admin
Posts: 13211
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her

Re: [4.8-d05ea19] Pink hued textures with material textures

Post by Rachael »

Return to “Closed Bugs [GZDoom]”