First off, I think that in concept the request is sound and generally a good idea. Personally my own needs are covered by existing features, but I do thing allowing people to express themselves in a comfortable way is almost never a bad thing, especially when the implementation is open-ended and customizable.
In the interest of constructive inquiry, this
is a fairly niche feature, one which a silent majority will probably never touch. I can imagine not many mods will end up leveraging pronouns productively (or may even maliciously abuse the feature???). As a niche feature, how much dev time will be needed for maintainance? I imagine that adding it as-is only takes the push of a [Merge] button, so that's easy. One in, Is the implementation sufficiently future-proof and flexible for the majority of expected use cases? If necessary, are there any changes which would make it more maintainable for future changes to surrounding systems? Are there any additional features or work required to make it functionally useful and not just window dressing?
Again, I want to clarify I'm
not against adding custom pronoun support. I think it's great for those that will use it. I just think these are things that should be discussed since if every niche feature was added without question then the codebase would become an unmaintainable mess, and I think everyone wants to avoid that. Honestly just browsing the code it looks fairly non-invasive to me, but then again I'm not an engine programmer.
