Remove Inventory On Weapon Drop?

[CaptainNurbles]

I'm wondering if it is possible to have items removed from your inventory when a weapon is dropped. As an example, I drop a weapon and in doing so the ammo I've got for that gun is removed from my inventory. Is there a way to code this in? I've looked around the ZDoom wiki and forums and haven't found much help.

[Mikk-]

If you fancy using ZScript it seems like you can override the virtual function: [wiki]OnDrop[/wiki]

here's a little zscript code using Doom's shotgun as an example:

Code: Select all

class customShotgun : shotgun
    {
    default
        {
        weapon.SlotNumber 3;
        }
    override void OnDrop(actor dropper)
        {
        if(dropper)
            dropper.TakeInventory("shell",999);
        }
    }

[Jarewill]

It's possible either with ACS or with ZScript.
With ACS you can set up a script like this:

Code: Select all

Script "WeaponAmmo" ENTER
{
    While(true)
    {
        If(!CheckInventory("Weapon")){TakeInventory("Ammo",10);}
        Delay(1);
    }
} 

Or you can add this override to your weapon if it's done in ZScript:

Code: Select all

Override void DetachFromOwner()
{
    owner.A_TakeInventory("Ammo",10);
    Super.DetachFromOwner();
} 

Though it's probably better to do weapon magazines this way if using ZScript.

[Matt]

DetachFromOwner will also happen if the weapon is destroyed or taken away. I don't know about OnDrop but I assume from the name of the function that it will only kick in on an actual drop.

[CaptainNurbles]

[quote="Jarewill"]It's possible either with ACS or with ZScript.
With ACS you can set up a script like this:

Code: Select all

Script "WeaponAmmo" ENTER
{
    While(true)
    {
        If(!CheckInventory("Weapon")){TakeInventory("Ammo",10);}
        Delay(1);
    }
}

Your ACS script works perfectly for what I've in mind, thank ya!

[Matt]

How does that not continuously take away ammo until you're completely out?

[Player701]

Indeed, the state needs to be saved somewhere, or the script will keep taking ammo continuously when the weapon is not present.

The fixed script can be found further below. However, unless you are limited to Zandronum compatibility, please do not use ACS to implement or modify game logic. It was once widespread only because there were no better tools, but now we have them. The solution should be implemented in ZScript, by overriding either OnDrop or DetachFromOwner, depending on your exact use case(s), as shown by Mikk- and Jarewill in the posts above.

Code: Select all

#include "zcommon.acs"

bool weaponCheck[8];

script "WeaponAmmo" ENTER
{
    bool hasWeapon = CheckInventory("Weapon");
    int pnum = PlayerNumber();
    
    if (!hasWeapon && weaponCheck[pnum])
    {
        TakeInventory("Ammo", 10);
    }
    
    weaponCheck[pnum] = hasWeapon;
    delay(1);
    restart;
}