RRWM reloading system [1.5.0] [ZS/DEC/SBARINFO]

[yum13241]

Thanks for your answer, but I have another problem:

My weapon visually disappears if it goes into the DryFire: state sequence if the user was holding fire.

BDL_Weapon:

---

Class BDL_Weapon : ReloadableWeapon { Default { Weapon.BobRangeX 0.2; Weapon.BobRangeY 0.4; Weapon.BobSpeed 2.9; Weapon.BobStyle "Smooth"; } States(Weapon) { InstaLoad: #### # 0 A_ReloadFullClip(); #### # 0 ResolveState("Ready"); Stop; // OCD DryAltFire: DryFire: #### A 4 A_StartSound("weapons/click", CHAN_WEAPON); #### A 1 A_DryRefire(); } }

BDL_Pistol:

---

Class BDL_Pistol : BDL_Weapon { Default { Weapon.SelectionOrder 1900; Weapon.AmmoGive 20; Weapon.AmmoType "BDL_PistolAmmo"; Weapon.AmmoUse 1; ReloadableWeapon.ClipCapacity 20; Inventory.PickupMessage "$GOTPISTOL"; Tag "$TAG_PISTOL"; Obituary "$OB_PISTOL"; AttackSound "weapons/bdlpistol"; } States(Actor) { Spawn: PIST A -1; Stop; } States(Weapon) { Select: PISO A 1 A_Raise(); #### # 0 A_Raise(); Loop; Deselect: #### # 1 A_Lower(); #### # 0 A_Lower(); Loop; Ready: PISO AA 1 A_ReloadableWeaponReady(); Loop; Fire: PISO B 2 A_FireBullets(3, 0, 1, random(10,25), "BulletPuff"); #### C 2; #### E 2; #### F 2; TNT1 A 0 A_Refire(); Goto Ready; Reload: PISR A 0 A_JumpIf(!bdl_sv_reloading, "InstaLoad"); #### C 2; #### E 2; #### D 2; #### G 3; #### H 3; #### I 3; #### J 3 A_ReloadFullClip(); #### A 0 A_StartSound("weapons/clipin", CHAN_WEAPON); #### M 2; #### N 2; #### O 2; #### P 2; #### Q 2; #### R 2; Goto Ready; } }

Is this related to the use of ####?

[Player701]

Is this related to the use of ####?

No, it isn't: the problem is that you don't have a control flow statement/function call (e.g. A_Jump, Goto etc.) at the end of your DryFire state sequence, so when control reaches the last state it presumably gets treated as if there were a Stop. Although I'm not sure if the latter is indeed the case, it doesn't really matter because you do need to jump somewhere regardless, preferably to the ready state.

[yum13241]

I did that and it doesn't work. In both scenarios, when you release fire and then fire again, it works properly.

[Player701]

Please post the updated code then.

[yum13241]

BDL_Pistol:

---

Class BDL_Pistol : BDL_Weapon { Default { Weapon.SelectionOrder 1900; Weapon.AmmoGive 20; Weapon.AmmoType "BDL_PistolAmmo"; Weapon.AmmoUse 1; ReloadableWeapon.ClipCapacity 20; Inventory.PickupMessage "$GOTPISTOL"; Tag "$TAG_PISTOL"; Obituary "$OB_PISTOL"; AttackSound "weapons/bdlpistol"; } States(Actor) { Spawn: PIST A -1; Stop; } States(Weapon) { Select: PISO A 1 A_Raise(); #### # 0 A_Raise(); Loop; Deselect: #### # 1 A_Lower(); #### # 0 A_Lower(); Loop; Ready: PISO AA 1 A_ReloadableWeaponReady(); Loop; Fire: PISO B 2 A_FireBullets(3, 0, 1, random(10,25), "BulletPuff"); #### C 2; #### E 2; #### F 2; TNT1 A 0 A_Refire(); Goto Ready; Reload: PISR A 0 A_JumpIf(!bdl_sv_reloading, "InstaLoad"); #### C 2; #### E 2; #### D 2; #### G 3; #### H 3; #### I 3; #### J 3 A_ReloadFullClip(); #### A 0 A_StartSound("weapons/clipin", CHAN_WEAPON); #### M 2; #### N 2; #### O 2; #### P 2; #### Q 2; #### R 2; Goto Ready; } }

BDL_Weapon:

---

Class BDL_Weapon : ReloadableWeapon { Default { Weapon.BobRangeX 0.2; Weapon.BobRangeY 0.4; Weapon.BobSpeed 2.9; Weapon.BobStyle "Smooth"; } States(Weapon) { InstaLoad: #### # 0 A_ReloadFullClip(); #### # 0 ResolveState("Ready"); Stop; // OCD DryAltFire: DryFire: #### A 4 A_StartSound("weapons/click", CHAN_WEAPON); #### A 1 A_DryRefire(); #### A 1 A_Jump(256, "Ready"); Stop; // OCD Note: I don't actually have OCD, its that I just can't stand seeing this without it. } }

[Player701]

With the code you've provided, I'm unable to make the weapon disappear entirely for me. But I've just noticed something else: namely, the state where you call A_ReFire has TNT1 as the sprite name. Since your DryFire starts with "####", this might be a problem. I'd recommend against combining TNT1 and ####.

[yum13241]

Sorry for a very late reply, but your solution works.

[yum13241]

Sorry to bother you (again) but I have a weird error.
Script error, "BD_LITE_1.0.pk3:bdl/actors/weapons/bdlweapon.zs" line 40: Call to member function CheckClick with incompatible self pointer.

I don't see self. anywhere!


BDL_Weapon:

---

Class BDL_Weapon : ReloadableWeapon abstract { Default { Weapon.BobRangeX 0.2; Weapon.BobRangeY 0.4; Weapon.BobSpeed 2.9; Weapon.BobStyle "Smooth"; +WEAPON.NOAUTOAIM } void CheckClick() { CVar reloading = bdl_sv_reloading; if(reloading) { bdl_weapon.A_StartSound("weapons/click", CHAN_WEAPON); bdl_weapon.A_DryRefire(); bdl_weapon.ResolveState("Ready"); return 0; } else { bdl_weapon.ResolveState("Ready"); return 0; } } States(Weapon) { InstaLoad: #### # 0 A_ReloadFullClip(); #### # 0 ResolveState("Ready"); Stop; // OCD DryAltFire: DryFire: #### # 0 CheckClick(); Stop; // OCD } }

[Player701]

Should either be action(Weapon) void CheckClick (self is PlayerPawn), or replace CheckClick(); with invoker.CheckClick(); (self is the weapon instance).

[yum13241]

Sorry to bother, but how would I make https://github.com/3saster/fullscrn_huds compatible with your reloading system?


BTW, the standalone HUD package doesn't work with your own reloading system.

[Player701]

Sorry to bother, but how would I make https://github.com/3saster/fullscrn_huds compatible with your reloading system?

There is an example ZScript-based HUD provided with the library, which you can learn from, but I'm afraid I can't help much with integrating the code into third-party mods - especially this particular one, as I've never seen its code before. But it should be simple: first, you have to check if the current weapon is reloadable, and if it is, call GetClipAmount to retreive the amount of ammo left in the magazine, then draw it somewhere on the screen (See the last paragraph of p.5 in the manual).

Keep in mind that the very nature of the system's implementation makes it poorly suitable for integration with standalone HUD mods. Generic HUDs usually support only what the engine itself supports by default - that is: primary and secondary ammo. Beyond that, as far as I know, it's all mod-dependent - so the HUD code has to be written specifically to allow for any extra icons/counters to be displayed when needed, and that would automatically make it incompatible with anything else.

BTW, the standalone HUD package doesn't work with your own reloading system.

You're right, but that's by design - see what I've said just above your quote. The standalone RRWM HUD package does not have any code to handle reloadable weapons because it's intended for generic use. It is a non-trivial task to make it work the way you want it to, and it mostly boils down to the same issues we've already discussed before.

[yum13241]

Generic HUDs usually support only what the engine itself supports by default - that is: primary and secondary ammo. Beyond that, as far as I know, it's all mod-dependent - so the HUD code has to be written specifically to allow for any extra icons/counters to be displayed when needed, and that would automatically make it incompatible with anything else.

I can do what you did and just override the Ammo counter on the left.

[Player701]

I can do what you did and just override the Ammo counter on the left.

You could, but I only did it for the status bar because there is not enough space to display both counters at the same time. Ideally, the magazine counter should complement the ammo counter, not replace it.

[yum13241]

You have the right side for your ammo. You in theory could've replaced Doomguy's head but that would be blasphemy.

I'll consider what you wrote.

Why does making/modifiying a HUD have to be so hard?

[Player701]

You in theory could've replaced Doomguy's head but that would be blasphemy.

Agreed.

Why does making/modifiying a HUD have to be so hard?

You can still use SBARINFO if you find ZScript too difficult for you to handle.