RRWM reloading system [1.5.0] [ZS/DEC/SBARINFO]

[Player701]

No, you will get a VM abort if you do that, and removing the code that triggers it will almost surely result in all kinds of unexpected behavior and/or errors (e.g. division by zero).

[Ultimate Freedoomer]

Are you referring to setting the capacity to a null value or making the secondary fire use a normal ammo actor?

[Player701]

Are you referring to setting the capacity to a null value or making the secondary fire use a normal ammo actor?

The former, although not null but rather zero or negative.

[yum13241]

Quick question: If I want a weapon to use the same type of ammo as all other bullet weapons (pistol, chaingun), is it OK if I do this?

Class RClip : ReloadableAmmo replaces Clip { Default { Inventory.MaxAmount 200 } }

Or will this break other weapons?

[Player701]

There is no limitation that a single ammo type can only be used by one weapon. You can share ammo types between weapons without any issues.

[yum13241]

What I mean is that will the vanilla pistol for example break with the code snippet above?

[Player701]

No, it won't, but it will still use the original Clip ammo type.

[yum13241]

What if I replaced the pistol and made it use my new clip?

[Player701]

As I've said before, sharing ammo types between weapons is a perfectly valid scenario. It doesn't matter whether any of these weapons are reloadable. ReloadableAmmo does not contain any magic to support reloading by itself, and can be used with normal weapons too. It's largely a hack of sorts to prevent the player from automatically switching to a reloadable weapon when there's really no need to - there is one particular case the engine does not handle properly.

[yum13241]

Thanks!

[Ultimate Freedoomer]

Are you referring to setting the capacity to a null value or making the secondary fire use a normal ammo actor?

The former, although not null but rather zero or negative.

so I’ll use the normal ammo actors to handle altfire not using the clip. What about my answers to the other 3 questions?

[Player701]

What about my answers to the other 3 questions?

Those questions were examples of what you should ask yourself before starting to edit the code, so that you have a clear picture of how your modifications are supposed to work. I don't know what else to say because you didn't ask me to clarify anything.

[Player701]

RRWM reloading system has been updated to version 1.3.0.1. Download the new release HERE. The link in the first post has been updated too.

This version adds the following convenience features:

• ZScript only: IsFullClip method for ReloadableWeapon to easily check if the clip is full. Previously, you had to compare GetClipAmount() with GetClipCapacity() for that.
• ZScript and DECORATE: Jump functions A_JumpIfClipAmount and A_JumpIfFullClip. Although they are available in both ZScript in DECORATE, usage of the former makes them redundant, and A_JumpIf should be used instead. Please refer to the manual (or the first post in this thread) for more info, search for "DECORATE jump functions". Thanks to Ultimate Freedoomer for the idea.

NB: Please do NOT PM me if you have a question, post it here instead. Thank you very much.

[yum13241]

I have a problem:


When I use this code, it's possible for the weapon to "fire" visually, when there's no ammo.


BDL_Weapon

---

Class BDL_Weapon : ReloadableWeapon { Default { Weapon.BobRangeX 0.2; Weapon.BobRangeY 0.4; Weapon.BobSpeed 2.9; Weapon.BobStyle "Smooth"; } States(Weapon) { InstaLoad: #### # 0 A_ReloadFullClip(); #### # 0 ResolveState("Ready"); Stop; // OCD DryReload: DryAltFire: DryFire: #### A 4 A_StartSound("weapons/click", CHAN_WEAPON); #### A 1 A_DryRefire(); } }

BDL_Pistol:

---

Class BDL_Pistol : BDL_Weapon { Default { Weapon.SelectionOrder 1900; Weapon.AmmoGive 20; Weapon.AmmoType "BDL_PistolAmmo"; Weapon.AmmoUse 1; ReloadableWeapon.ClipCapacity 20; Inventory.PickupMessage "$GOTPISTOL"; Tag "$TAG_PISTOL"; Obituary "$OB_PISTOL"; AttackSound "weapons/bdlpistol"; } States(Actor) { Spawn: PIST A -1; Stop; } States(Weapon) { Select: PISO A 1 A_Raise(); #### # 0 A_Raise(); Loop; Deselect: PISO A 1 A_Lower(); #### # 0 A_Lower(); Loop; Ready: PISO AA 1 A_ReloadableWeaponReady(); Loop; Fire: PISO B 2 A_FireBullets(3, 0, 1, random(10,25), "BulletPuff"); PISO C 2; PISO E 2; PISO F 2; TNT1 A 0 A_Refire("Fire"); Goto Ready; Reload: TNT1 A 0 A_JumpIf(!bdl_sv_reloading, "InstaLoad"); // some don't like reloading PISR C 2; PISR E 2; PISR D 2; PISR G 3; PISR H 3; PISR I 3; PISR J 3 A_ReloadFullClip(); TNT1 A 0 A_StartSound("weapons/clipin", CHAN_WEAPON); PISR M 2; PISR N 2; PISR O 2; PISR P 2; PISR Q 2; PISR R 2; Goto Ready; } }

[Player701]

Sorry for a somewhat late reply.

First of all, there is no DryReload state, this state label does not actually do anything.

And to fix your issue, you need to change A_ReFire("Fire") to just A_ReFire. This is necessary because if you pass a state label to A_ReFire, there is no way to override it from weapon code. I suppose I haven't mentioned that in the manual, so I'll fix it when I have the time.