[SOLVED] Custom weapon causing freezes?

Alexagon · Post by **Alexagon** » Sun Jun 09, 2019 3:41 pm

So I just finished my custom weapon, but it seems like it is causing some freezes. I'm playing Plutonia 2 on map 14 and I pick up the weapon, then the game crashes a few seconds later randomly. The weird thing is I tried it with map 2 on doom 2 since i can get the pistol there but I have no issues on that map so idk what's going on.

EDIT: Disregard that map 2 part. It's doing in in all cases I've tested it with.

I'll post the code for the weapon. But if anyone can help me I'd be very grateful.

Spoiler:

Code: Select all

Actor FusionPistol : ModWeapon replaces SuperShotgun
{
  Weapon.SelectionOrder 3000
  Weapon.SlotNumber 3
  Weapon.AmmoType "FusionMag"
  Weapon.AmmoUse 1
  Weapon.AmmoGive 0
  Weapon.AmmoType2 "clip2"
  Weapon.AmmoGive2 10
  Weapon.AmmoUse2 0
  +WEAPON.AMMO_OPTIONAL
  +WEAPON.NOAUTOFIRE
  Inventory.PickupMessage "You got a Fusion Pistol!"
  obituary "%o was melted by %k's Fusion Pistol"
  states
  {
  Ready:
    TNT1 A 0 A_jumpifinventory ("givefire", 1, "FireReady")
    PLPG A 1 A_WeaponReady (WRF_ALLOWRELOAD)
    loop
  FireReady:
    PLPR A 1 A_WeaponReady (WRF_ALLOWRELOAD)
    loop
  Select:
    TNT1 A 0 A_PlaySound("weapons/prifle/equp")
	PLPG A 1 A_Raise 
	PLPG A 1 Offset(67, 100)
	TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
	PLPG A 1 Offset(54, 81)
	TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
	PLPG A 1 Offset(32, 69)
	TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
	PLPG A 1 Offset(22, 58)
	TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
	PLPG A 1 Offset(10, 47)
	TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
	PLPG A 1 Offset(7, 39)
	TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
	PLPG A 1 Offset(2, 34)
	TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
    GOTO READY
  Deselect:
	TNT1 A 0 A_JumpIf(ACS_NamedExecuteWithResult("AnimToggle")==1, "DeadSelect")
	TNT1 A 0 A_PlaySound("weapons/deselect")
	TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
	PLPG A 1 Offset(2, 34)
	TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
	PLPG A 1 Offset(7, 39)
	TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
	PLPG A 1 Offset(10, 47)
	TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
	PLPG A 1 Offset(22, 58)
	TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
	PLPG A 1 Offset(32, 69)
	TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
	PLPG A 1 Offset(54, 81)
	TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
	PLPG A 1 Offset(67, 100)
	PLZR A 1 A_Lower
	TNT1 A 0 A_TaKeInventory ("givefire", 999)
	Wait
  Fire:
    TNT1 A 0 A_JumpIfNoAmmo ("dryfire")
    TNT1 A 0 A_jumpifinventory ("givefire", 1, "FireFire")
	TNT1 A 0 A_playsound ("weapons/bfg/fire")
    PLPG B 3 BRIGHT
    PLPG C 3 BRIGHT A_FireCustomMissile("FusionBulletPoison")
    PLPG A 8
    goto Ready
  NoReloadFire:
    TNT1 A 0 A_JumpIfInventory("Clip2", 1, 1)
    goto fire+1
    TNT1 A 0 A_TakeInventory("Cell", 1, TIF_NOTAKEINFINITE)
    TNT1 A 0 A_jumpifinventory ("givefire", 1, "FireFire")
    PLPG A 0
	TNT1 A 0 A_playsound ("weapons/bfg/fire")
    PLPG B 3 BRIGHT
    PLPG C 3 BRIGHT A_FireCustomMissile("FusionBulletPoison")
    PLPG A 8
    goto Ready
  AltFire:
    TNT1 A 0 A_playsound ("weapons/bfg/pickup", 1, 0.6)
    TNT1 A 0 A_jumpifinventory ("givefire", 1, "disablealt")
    TNT1 A 0 A_GiveInventory ("givefire")
	PLPG A 1 Offset(0, 35)
	TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
	PLPR A 2 Offset(0, 34)
	TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
	PLPG A 1 Offset(0, 33)
	TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
	PLPR A 2 Offset(0, 33)
	TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
	goto fireready
  DisableAlt:
    TNT1 A 0 A_playsound ("weapons/bfg/pickup", 1, 0.6)
 	TNT1 A 0 A_TaKeInventory ("givefire", 999)
	PLPR A 1 Offset(0, 35)
	TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
	PLPG A 2 Offset(0, 34)
	TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
	PLPR A 1 Offset(0, 33)
	TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
	PLPG A 2 Offset(0, 33)
	TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
	goto ready
  Firefire:
    TNT1 A 0 A_JumpIfNoAmmo ("Dryfire")
    PLPR A 0
	TNT1 A 0 A_playsound ("weapons/bfg/fire")
    PLPR B 3 BRIGHT
    PLPR C 3 BRIGHT A_FireCustomMissile("FusionBulletFire")
    PLPR A 8
	PLPR A 10 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
    goto Ready
  Dryfire:
	TNT1 A 0 A_PlaySound("weapons/pistol/dryf", 6)
	TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
	PLPG A 1 Offset(0, 35)
	TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
	PLPR A 2 Offset(0, 34)
	TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
	PLPG A 1 Offset(0, 33)
	TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
	PLPR A 2 Offset(0, 33)
	TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
  Reload:
		TNT1 A 0 A_JumpIfInventory("FusionMag", 10, 2)
		TNT1 A 0 A_JumpIfInventory("Clip2", 1, "ReloadWork")
		PLPG A 1 A_WeaponReady
		Goto Ready
	ReloadWork:
		TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
		PLPG A 2 Offset(4, 38)
		TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
		PLPG A 2 Offset(8, 46)
		TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
		PLPG A 2 Offset(10, 54)
		TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
		PLPG A 2 Offset(12, 62)
		TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
		PLPG A 2 Offset(13, 70)
		TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
		PLPG A 10 Offset(14, 78)
		TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
	ReloadLoop:
		TNT1 A 0 A_TakeInventory("Clip2", 1)
		TNT1 A 0 A_GiveInventory("FusionMag", 1)
		TNT1 A 0 A_JumpIfInventory("FusionMag", 3, "ReloadFinish")
		TNT1 A 0 A_JumpIfInventory("Clip2", 1, "ReloadLoop")
		Goto ReloadFinish
	ReloadFinish:
		TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
		PLPG A 10 Offset(14, 78)
		TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
		PLPR A 1 Offset(13, 70)
		TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
		TNT1 A 0 A_PlaySound("weapons/prifle/beep")
		TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
		PLPG A 1 Offset(12, 62)
		TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
		PLPR A 1 Offset(10, 54)
		TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
		PLPG A 1 Offset(8, 46)
		TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
		PLPR A 1 Offset(4, 38)
		TNT1 A 0 A_WeaponReady(WRF_NoFire|WRF_NoSwitch)
		Goto Ready
  Spawn:
	 PLSP A -1
		Stop
  }
}

ACTOR FusionBulletPoison : FastProjectile
{
  Radius 2
  Height 2
  Speed 80
  Damage 3
  PoisonDamage 5, 80, 25
  Projectile
  +RANDOMIZE
  +BLOODSPLATTER
  Obituary "%o was shot to pieces"
  Decal "bulletchip"
  States
  {
  Spawn:
    BLT1 A 1 Bright
    Loop
  Death:
    BLT1 A 1 Bright A_spawnitem("bulletpuff")
    Stop
  XDeath:
    BLT1 A 0
    Stop
  }
}

ACTOR FusionBulletFire : FastProjectile
{
  Radius 2
  Height 2
  Speed 80
  Damage 3
  Projectile
  +RANDOMIZE
  Obituary "%o was shot to pieces"
  Decal "bulletchip"
  States
  {
  Spawn:
    BLT1 A 1 Bright
    Loop
  Death:
	 BLT1 A 1 A_PlaySound("Afrit/Hellfire")
     BLT1 A 1 Bright A_spawnitem("Hellfire1")
     Stop
	xDeath:
	 BLT1 A 1 A_PlaySound("Afrit/Hellfire")
	 BLT1 A 1 Bright A_spawnitem("Hellfire1")
	 stop
	}
}

Actor GiveFire : Inventory
{
	Inventory.maxamount 1
}

ACTOR FusionMag : Ammo
{
  Inventory.PickupMessage ""
  Inventory.Amount 0
  Inventory.MaxAmount 3
  Ammo.BackpackAmount 0
  Ammo.BackpackMaxAmount 3
  Inventory.PickupSound ""
}

Post by **_mental_** » Mon Jun 10, 2019 1:29 am

You need to post a minimal runnable sample that causes the problem.

Alexagon · Post by **Alexagon** » Mon Jun 10, 2019 2:13 am

_mental_ wrote:You need to post a minimal runnable sample that causes the problem.

What exactly do you mean?

Post by **_mental_** » Mon Jun 10, 2019 2:38 am

Runnable sample means a .wad/.pk3/.pk7 file that anyone can load with GZDoom in order to reproduce this issue.
The most obvious problem with your code is missing definition of base class ModWeapon. Nobody can read your mind to figure out what this class is.

Alexagon · Post by **Alexagon** » Mon Jun 10, 2019 3:45 am

_mental_ wrote:Runnable sample means a .wad/.pk3/.pk7 file that anyone can load with GZDoom in order to reproduce this issue.
The most obvious problem with your code is missing definition of base class ModWeapon. Nobody can read your mind to figure out what this class is.

Here it is.

https://drive.google.com/file/d/10Ykaok ... sp=sharing

Post by **_mental_** » Mon Jun 10, 2019 4:10 am

Well, minimal sample means everything required to reproduce the problem, not a whole mod.
Anyway, I loaded the mod, did summon FusionPistol in console, picked it up, ran around, killed some enemies. It works for me.

Alexagon · Post by **Alexagon** » Mon Jun 10, 2019 4:14 am

_mental_ wrote:Well, minimal sample means everything required to reproduce the problem, not a whole mod.
Anyway, I loaded the mod, did summon FusionPistol in console, picked it up, ran around, killed some enemies. It works for me.

It's easier just to post the whole thing. Doesn't really matter all that much.

Were you able to complete any levels? Last time I tried it I made it through Entryway, but then it froze when I went back and tried it in plutonia. I know it's not plutonia because it HAS frozen on the standard maps, it's just not consistent when and where it happens.

Alexagon · Post by **Alexagon** » Tue Jun 11, 2019 12:55 am

Turns out it as the takeinventory tag at the end of deselect causing the freeze. Took that out and it seems to be running fine.

Matt · Post by **Matt** » Tue Jun 11, 2019 9:20 am

This is the takeinventory frame I see on the OP right now:

Code: Select all

   TNT1 A 0 A_TaKeInventory ("givefire", 999)
   Wait

"Wait" means basically "loop just that last frame". This mean you've got a zero-length loop right there.

This would fix it:

Code: Select all

   TNT1 A 1{ //make sure this is at least 1 tick
    A_TaKeInventory ("givefire") //if you don't specify a # it takes all
    A_Lower
   }
   Wait

Alexagon · Post by **Alexagon** » Wed Jun 12, 2019 1:51 am

Matt wrote:This is the takeinventory frame I see on the OP right now:
Code: Select all
   TNT1 A 0 A_TaKeInventory ("givefire", 999)
   Wait
"Wait" means basically "loop just that last frame". This mean you've got a zero-length loop right there.

This would fix it:
Code: Select all
   TNT1 A 1{ //make sure this is at least 1 tick
    A_TaKeInventory ("givefire") //if you don't specify a # it takes all
    A_Lower
   }
   Wait

Thank you. I appreciate the help.

Welcome to the ZDoom Forums!

[SOLVED] Custom weapon causing freezes?

[SOLVED] Custom weapon causing freezes?

Re: Custom weapon causing freezes?

Re: Custom weapon causing freezes?

Re: Custom weapon causing freezes?

Re: Custom weapon causing freezes?

Re: Custom weapon causing freezes?

Re: Custom weapon causing freezes?

Re: Custom weapon causing freezes?

Re: Custom weapon causing freezes?

Re: Custom weapon causing freezes?