Texture warping broken since texture refactor

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
User avatar
Rachael
Posts: 13923
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her

Re: Texture warping broken since texture refactor

Post by Rachael »

The "* 2" could be reduced to "* 4/3" to be honest - that's to hold the mipmaps.

You'll crash without it, otherwise, if you try to run this in the truecolor renderer with mipmaps enabled.

"hq_texture_hqresizemult" tells the texture resizer how big you want your textures. The value has to be squared when allocating for a warp texture.
User avatar
drfrag
Vintage GZDoom Developer
Posts: 3179
Joined: Fri Apr 23, 2004 3:51 am
Location: Spain

Re: Texture warping broken since texture refactor

Post by drfrag »

Now i've noticed that it only crashed and glitched with mipmaps enabled, so it was that. :)
User avatar
Rachael
Posts: 13923
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her

Re: Texture warping broken since texture refactor

Post by Rachael »

I've merged the patch as thus.

With one caveat: While yes, I am confident in the code, and I know it fixes the underlying issue, I know it still could be made better, as discussed in this thread. I did a squash commit so that if it's decided to redo this a completely different way, it's easier to revert 1 commit than 4.

At any rate, as far as my involvement goes, this issue is fixed.

Return to “Closed Bugs [GZDoom]”