Multithread sw render buffer overflow

Moderator: GZDoom Developers

Forum rules
Please construct and post a simple demo whenever possible for all bug reports. Please provide links to everything.

If you can include a wad demonstrating the problem, please do so. Bug reports that include fully-constructed demos have a much better chance of being investigated in a timely manner than those that don't.

Please make a new topic for every bug. Don't combine multiple bugs into a single topic. Thanks!
Edward-san
Posts: 1774
Joined: Sat Oct 17, 2009 9:40 am

Multithread sw render buffer overflow

Post by Edward-san »

The titlemap of Square1 makes GZDoom multithread sw renderer (except vid_rendermode 0) instantaneously crash with the address sanitizer, as seen below:
Spoiler:
I got the values of the args of the crashing function:

Code: Select all

(uint32_t) width = 32
(uint32_t) height = 32
(uint32_t) xone = 134217728
(uint32_t) yone = 134217728
(uint32_t) xstep = 39396284
(uint32_t) ystep = 0
(uint32_t) xfrac = 786861999
(uint32_t) yfrac = 1632337501
(const uint32_t *) source = 0x00006290018d2200
User avatar
Rachael
Admin
Posts: 13084
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her

Re: Multithread sw render buffer overflow

Post by Rachael »

These are very difficult to solve.

At one point, it was the fog boundaries causing it, and that was fixed, and while it did mitigate some of the crashing it did not fix all of it.

Return to “Classic ("Carmack") Software Renderer Bugs”